Issue 843 in moose-technology: ROLightlyHighlightable drains element colour - Moose-dev

moose-technology＠googlecode.com

24 Sep 24 Sep

4:18 p.m.

New subject: Issue 843 in moose-technology: ROLightlyHighlightable drains element colour

Updates: Status: Fixed Labels: Component-Roassal Comment #1 on issue 843 by alexandr...(a)gmail.com: ROLightlyHighlightable drains element colour http://code.google.com/p/moose-technology/issues/detail?id=843 In Roassal 1.129. Thanks Ben!

Reply

Dennis Schenk

26 Sep 26 Sep

12:43 p.m.

New subject: Issue 843 in moose-technology: ROLightlyHighlightable drains element colour

Hi, The code does not work for me, because attributes for the ROElement ist always nil, thus it can't set the original color. (Or did I miss ome thing? I updated Roassal to the newest version). I added - *attributes := Dictionary new.* to the init method of ROAbstractElement - The method attributes to ROAbstractElement to make it accessible. Else the code of ROLightlyHighlightable leads to an error. See the filed out ROAbstractElement here: http://cl.ly/code/2J0T3x3y1F0y Cheers, Dennis On Mon, Sep 24, 2012 at 8:01 PM, <moose-technology(a)googlecode.com> wrote:

...

Comment #2 on issue 843 by google....(a)ben.coman.com.au: ROLightlyHighlightable drains element colour http://code.google.com/p/**moose-technology/issues/**detail?id=843<http:… Works for me. Thanks Alex. ______________________________**_________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/**mailman/listinfo/moose-dev<https://www.iam.un…

Reply

Dennis Schenk

2 Oct 2 Oct

5:17 p.m.

New subject: Issue 843 in moose-technology: ROLightlyHighlightable drains element colour

No, actually I do have the latest version and the bug is still present, but it does concern ROEdges, not ROElements. See the following script where I want to add a highlighter to an edge. -------------------- *| view rawView node1 node2 edge |* *rawView := ROView new.* *view := ROMondrianViewBuilder view: rawView.* *node1 := ROLabel elementOn: 'node1'. * *node2 := ROLabel elementOn: 'node2'.* *node1 @ RODraggable.* *node2 @ RODraggable.* *edge := ROEdge lineFrom: node1 to: node2.* *edge + (ROLine red).* * * *edge @ ROLightlyHighlightable.* * * *rawView add: edge; add: node1; add: node2.* *ROHorizontalLineLayout on: (Array with: node1 with: node2).* * * *ROEaselMorphic new populateMenuOn: view.* *view noLayout.* *view open* -------------------- This is why we have to add the changes to ROAbstractElement. Cheers, Dennis On Thu, Sep 27, 2012 at 12:04 AM, Alexandre Bergel <alexandre.bergel(a)me.com>wrote;wrote:

...

Hi Dennis, I have the impression that you do not use the last version of Roassal. In Pharo 1.4 and 2.0, with the last version of Roassal I have the script that does let the second circle changes its color. -------------------- el1 := (ROElement on: 1) height: 50; width:50. el1 + (ROCircle color: Color lightGreen). el2 := (ROElement on: 1) height: 50; width:50. el2 + (ROCircle color: Color lightGreen) @ ROLightlyHighlightable. rawView := ROView new @ RODraggable. rawView add: el1. rawView add: el2. ROHorizontalLineLayout on: rawView elements. rawView open. -------------------- Alexandre On Sep 26, 2012, at 7:43 AM, Dennis Schenk <d.schenk(a)students.unibe.ch> wrote:

Hi, The code does not work for me, because attributes for the ROElement ist

always nil, thus it can't set the original color.

(Or did I miss ome thing? I updated Roassal to the newest version). I added - attributes := Dictionary new. to the init method of ROAbstractElement - The method attributes to ROAbstractElement to make it accessible. Else the code of ROLightlyHighlightable leads to an error. See the filed out ROAbstractElement here: http://cl.ly/code/2J0T3x3y1F0y Cheers, Dennis On Mon, Sep 24, 2012 at 8:01 PM, <moose-technology(a)googlecode.com>

wrote:

Comment #2 on issue 843 by google....(a)ben.coman.com.au:

ROLightlyHighlightable drains element colour

http://code.google.com/p/moose-technology/issues/detail?id=843 Works for me. Thanks Alex. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Dennis Schenk

9:28 a.m.

New subject: Issue 843 in moose-technology: ROLightlyHighlightable drains element colour

Thanks Alex. Concerning the lineFrom: The code is from a Roassal example in the easel: Examples -> ROExample -> Basic -> Lines. So we should fix that there. Also the code *edge + (ROLine red)* does not make the line red in the example, thats probably related? Cheers, Dennis On Wed, Oct 3, 2012 at 1:04 AM, Alexandre Bergel <alexandre.bergel(a)me.com>wrote;wrote:

...

Hi Dennis! Well spotted!! I was able to reproduce and fix the problem. The last version of Roassal should do what you expect. By the way, you should have "ROEdge from: node1 to: node2." and not "ROEdge lineFrom: node1 to: node2." because with lineFrom: you add a shape. Cheers, Alexandre On Oct 2, 2012, at 12:17 PM, Dennis Schenk <d.schenk(a)students.unibe.ch> wrote:

No, actually I do have the latest version and the bug is still present,

but it does concern ROEdges, not ROElements. See the following script where I want to add a highlighter to an edge.

-------------------- | view rawView node1 node2 edge | rawView := ROView new. view := ROMondrianViewBuilder view: rawView. node1 := ROLabel elementOn: 'node1'. node2 := ROLabel elementOn: 'node2'. node1 @ RODraggable. node2 @ RODraggable. edge := ROEdge lineFrom: node1 to: node2. edge + (ROLine red). edge @ ROLightlyHighlightable. rawView add: edge; add: node1; add: node2. ROHorizontalLineLayout on: (Array with: node1 with: node2). ROEaselMorphic new populateMenuOn: view. view noLayout. view open -------------------- This is why we have to add the changes to ROAbstractElement. Cheers, Dennis On Thu, Sep 27, 2012 at 12:04 AM, Alexandre Bergel <

alexandre.bergel(a)me.com> wrote:

Hi Dennis, I have the impression that you do not use the last version of Roassal. In Pharo 1.4 and 2.0, with the last version of Roassal I have the script

that does let the second circle changes its color.

-------------------- el1 := (ROElement on: 1) height: 50; width:50. el1 + (ROCircle color: Color lightGreen). el2 := (ROElement on: 1) height: 50; width:50. el2 + (ROCircle color: Color lightGreen) @ ROLightlyHighlightable. rawView := ROView new @ RODraggable. rawView add: el1. rawView add: el2. ROHorizontalLineLayout on: rawView elements. rawView open. -------------------- Alexandre On Sep 26, 2012, at 7:43 AM, Dennis Schenk <d.schenk(a)students.unibe.ch>

wrote:

> Hi, > > The code does not work for me, because attributes for the ROElement

ist always nil, thus it can't set the original color.

> > (Or did I miss ome thing? I updated Roassal to the newest version). > > I added > - attributes := Dictionary new. to the init method of ROAbstractElement > - The method attributes to ROAbstractElement to make it accessible. > > Else the code of ROLightlyHighlightable leads to an error. > > See the filed out ROAbstractElement here: > > http://cl.ly/code/2J0T3x3y1F0y > > Cheers, > Dennis > > On Mon, Sep 24, 2012 at 8:01 PM, <moose-technology(a)googlecode.com>

wrote:

> > Comment #2 on issue 843 by google....(a)ben.coman.com.au:

ROLightlyHighlightable drains element colour

http://code.google.com/p/moose-technology/issues/detail?id=843 Works for me. Thanks Alex. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

moose-technology＠googlecode.com

3 Mar 3 Mar

2:14 p.m.

New subject: Issue 843 in moose-technology: ROLightlyHighlightable drains element colour

Updates: Labels: Milestone-4.7 Comment #3 on issue 843 by tu...(a)tudorgirba.com: ROLightlyHighlightable drains element colour http://code.google.com/p/moose-technology/issues/detail?id=843 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings

Reply

Tudor Girba

4:54 p.m.

New subject: Issue 843 in moose-technology: ROLightlyHighlightable drains element colour

It should be enough given that each person associated with a fix should receive an explicit notification. Cheers, Doru On Mon, Sep 24, 2012 at 4:20 PM, Alexandre Bergel <alexandre.bergel(a)me.com> wrote:

...

I've just fixed it. Quick question: does it make sense that I confirm that I fixed the issue or is the google notification enough? Since Ben's email is not set in the author or in the Cc: field of the issue, I am not sure. @ Ben, do you see the mail sent by moose-technology(a)googlecode.com that confirms I have closed the issue? Cheers, Alexandre On Sep 23, 2012, at 8:55 AM, moose-technology(a)googlecode.com wrote:

Status: New Owner: ---- Labels: Type-Defect Priority-Medium New issue 843 by google....(a)ben.coman.com.au: ROLightlyHighlightable drains element colour http://code.google.com/p/moose-technology/issues/detail?id=843 The following code snippet results in the attached image, showing that ROLightlyHighlightable drains the original colour from el2 - leaving it drab and dreary. I think we need to liven up the party for poor old el2, and give him back his colour. -------------------- el1 := (ROElement on: 1) height: 50; width:50. el1 + (ROCircle color: Color lightGreen). el2 := (ROElement on: 1) height: 50; width:50. el2 + (ROCircle color: Color lightGreen) @ ROLightlyHighlightable. rawView := ROView new @ RODraggable. rawView add: el1. rawView add: el2. ROHorizontalLineLayout on: rawView elements. rawView open. -------------------- Attachments: ROLightlyHighlightable-drains-colour-from-element.png 3.6 KB _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "Every thing has its own flow"

Reply

Tudor Girba

5:22 p.m.

New subject: Issue 843 in moose-technology: ROLightlyHighlightable drains element colour

The originator should get an email. Doru On Mon, Sep 24, 2012 at 5:17 PM, Alexandre Bergel <alexandre.bergel(a)me.com> wrote:

...

Ah okay, even if no author or cc field is set. Alexandre On Sep 24, 2012, at 11:54 AM, Tudor Girba <tudor(a)tudorgirba.com> wrote:

It should be enough given that each person associated with a fix should receive an explicit notification. Cheers, Doru On Mon, Sep 24, 2012 at 4:20 PM, Alexandre Bergel <alexandre.bergel(a)me.com> wrote:

I've just fixed it. Quick question: does it make sense that I confirm that I fixed the issue or is the google notification enough? Since Ben's email is not set in the author or in the Cc: field of the issue, I am not sure. @ Ben, do you see the mail sent by moose-technology(a)googlecode.com that confirms I have closed the issue? Cheers, Alexandre On Sep 23, 2012, at 8:55 AM, moose-technology(a)googlecode.com wrote:

Status: New Owner: ---- Labels: Type-Defect Priority-Medium New issue 843 by google....(a)ben.coman.com.au: ROLightlyHighlightable drains element colour http://code.google.com/p/moose-technology/issues/detail?id=843 The following code snippet results in the attached image, showing that ROLightlyHighlightable drains the original colour from el2 - leaving it drab and dreary. I think we need to liven up the party for poor old el2, and give him back his colour. -------------------- el1 := (ROElement on: 1) height: 50; width:50. el1 + (ROCircle color: Color lightGreen). el2 := (ROElement on: 1) height: 50; width:50. el2 + (ROCircle color: Color lightGreen) @ ROLightlyHighlightable. rawView := ROView new @ RODraggable. rawView add: el1. rawView add: el2. ROHorizontalLineLayout on: rawView elements. rawView open. -------------------- Attachments: ROLightlyHighlightable-drains-colour-from-element.png 3.6 KB _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "Every thing has its own flow" _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "Every thing has its own flow"

Reply