27 Jun
2011
27 Jun
'11
3:45 p.m.
Status: Accepted
Owner: damien.c...(a)gmail.com
CC: tudor.gi...(a)gmail.com
Labels: Type-Defect Priority-Critical Component-Glamour
New issue 656 by damien.c...(a)gmail.com: [Glamour] Finder doesn't copy
browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
I would like each finder's pane to be a simple browser instead of just
a presentation. The following does not work and I can't make it work.
When the #selection port is triggered, a new pane is correctly added
to the finder, but all of the finder's panes are updated with the same
content as the new one.
|navigator finder|
navigator := GLMTabulator new.
navigator row: #content.
navigator transmit to: #content; andShow: [:a | a list display:
#allSuperclasses].
navigator transmit from: #content; toOutsidePort: #selection.
finder := GLMFinder new.
finder show: [:a | a custom: navigator].
finder openOn: String
27 Jun
27 Jun
9:28 p.m.
Updates:
Labels: Milestone-4.6
Comment #1 on issue 656 by tu...(a)tudorgirba.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
Hmm, it looks like the copying is correct at the level of the Glamour
model. These all return the correct result:
finder panes collect: [:each | each presentations first ].
finder panes collect: [:each | (each port: #entity) value ].
finder panes collect: [:each | each presentations first panes first port:
#entity ]
So, maybe it's only at the rendering level.
9:48 p.m.
Comment #2 on issue 656 by tu...(a)tudorgirba.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
Ok, now I have a test that fails, but I still do not know the cause:
Name: Glamour-Tests-Morphic-TudorGirba.46
Author: TudorGirba
Time: 27 June 2011, 9:47:45 pm
UUID: 4bbc414a-7fa3-4955-8a83-d2976684b436
Ancestors: Glamour-Tests-Morphic-cyrilledelaunay.45
written a failing test to capture
Issue 656: [Glamour] Finder doesn't copy browsers inside its panes
28 Jun
28 Jun
2:58 p.m.
Updates:
Status: Fixed
Comment #3 on issue 656 by tu...(a)tudorgirba.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
Fixed finally in the latest Glamour-Core.
The problem was that the Pane copied the announcement registrations when
being copied. It should work now. Two tests testify to this :)
3:57 p.m.
Updates:
Status: Accepted
Comment #4 on issue 656 by tu...(a)tudorgirba.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
It looks like there are still problems with more complex browsers:
navigator := GLMTabulator new.
navigator row: #content; row: #details.
navigator transmit to: #content; andShow: [:a | a list display:
#allSuperclasses].
navigator transmit from: #content; to: #details; andShow: [ :a | a text ].
navigator transmit from: #content; toOutsidePort: #selection.
finder := GLMFinder new.
finder show: [:a | a custom: navigator].
window := finder openOn: String.
Try selecting another item in the first pane and the bottom preview does
not update.
2 Jul
2 Jul
10:02 p.m.
Comment #5 on issue 656 by damien.c...(a)gmail.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
I've implemented GLMFinderTest>>testValidSubscriptionsInComplexBrowser
which should reproduce mentionned behavior but does not. I guess the
problem does not appear in the Core but only in Morphic.
10:06 p.m.
Comment #6 on issue 656 by damien.c...(a)gmail.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
Doru implemented
GLMFinderMorphicTest>>testEmbeddedBrowserRefreshesRendering which
reproduces the problem with Morphic
10:54 p.m.
Comment #7 on issue 656 by tu...(a)tudorgirba.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
The problem is not in how the Glamour model works.
The problem is in the announcements that the model raises.
9 Jul
9 Jul
5:04 p.m.
Comment #8 on issue 656 by damien.c...(a)gmail.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
I've updated GLMFinderMorphicTest>>testEmbeddedBrowserRefreshesRendering to
show where the error is more clearly. However, I'm completely lost in
Glamour architecture, it might be too complex.
11 Jul
11 Jul
12:21 p.m.
Comment #9 on issue 656 by tu...(a)tudorgirba.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
Fixed the issue with copying announcement registry when copying the Glamour
objects. The problem was that when copying the panes and presentation, the
announcer got reset, but the registry variable was not copied.
Now, everything should work fine.
12 Jul
12 Jul
10:17 a.m.
Updates:
Status: Fixed
Comment #10 on issue 656 by damien.c...(a)gmail.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
Works perfectly, thank you very much. Would you please tell me how you used
the visualization to find the problem source?
10:32 a.m.
Comment #11 on issue 656 by tu...(a)tudorgirba.com: [Glamour] Finder doesn't
copy browsers inside its panes
http://code.google.com/p/moose-technology/issues/detail?id=656
The visualization was not useful to identify directly the cause, but it was
useful to provide a hint: it showed that the same renderer object was being
announced to render multiple Glamour objects (the red lines). That meant
that the the announcements were not copied properly when we copied the
Glamour objects.
4680
days inactive
4695
days old
11 comments
1 participants
participants (1)
-
moose-technology＠googlecode.com