8 Mar
2013
8 Mar
'13
11:24 a.m.
Hi,
Test MooseSmalltalkImporterRoelTyperTest>>testASTCore is falling because at
some point it is using class TypeCollector, which is no longer in the
system.
So what should we do:
- Remove this importer?
- Bring back TypeCollector?
========
SmalltalkImporter>>createAttribute: name for: aClass
...
ifTrue: [
possibleTypes := (TypeCollector typeInstvar: name asSymbol
ofClassWithLookup: aClass ) types.
possibleTypes size = 1
ifTrue: [attribute declaredType: (self ensureClass: possibleTypes first
theNonMetaClass) ].
].
^ attribute
=========
--
Andre Hora
8 Mar
8 Mar
11:38 a.m.
On Fri, Mar 8, 2013 at 11:24 AM, Andre Hora <andrehoraa(a)gmail.com> wrote:
> ========
> SmalltalkImporter>>createAttribute:
name for: aClass
> ...
> ifTrue: [
> possibleTypes := (TypeCollector typeInstvar: name asSymbol
> ofClassWithLookup: aClass ) types.
> possibleTypes size = 1
> ifTrue: [attribute declaredType: (self ensureClass: possibleTypes first
> theNonMetaClass) ].
> ].
> ^ attribute
> =========
> --
> Andre Hora
>
_______________________________________________
> Moose-dev mailing list
> Moose-dev(a)iam.unibe.ch
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Hi,
Test MooseSmalltalkImporterRoelTyperTest>>testASTCore is falling because
at some point it is using class TypeCollector, which is no longer in the
system.
So what should we do:
- Remove this importer?
and throw away Roel-typer, all its tests, etc?
Btw, its also used in NECompletionModel package
(NECContext>>guessWithRoelTyper: aString class: aClass).
Is it normal that we have NECompletion in Moose?
- Bring back TypeCollector?
12 Mar
12 Mar
10:46 p.m.
Ideally, we should not remove RoelTyper, especially that now Stef says that the tests run
in 2.0.
Cheers,
Doru
On Mar 8, 2013, at 11:38 AM, Usman Bhatti <usman.bhatti(a)gmail.com> wrote:
On Fri, Mar 8, 2013 at 11:24 AM, Andre Hora <andrehoraa(a)gmail.com> wrote:
Hi,
Test MooseSmalltalkImporterRoelTyperTest>>testASTCore is falling because at some
point it is using class TypeCollector, which is no longer in the system.
So what should we do:
- Remove this importer?
and throw away Roel-typer, all its tests, etc?
Btw, its also used in NECompletionModel package (NECContext>>guessWithRoelTyper:
aString class: aClass).
Is it normal that we have NECompletion in Moose?
- Bring back TypeCollector?
========
SmalltalkImporter>>createAttribute: name for: aClass
...
ifTrue: [
possibleTypes := (TypeCollector typeInstvar: name asSymbol ofClassWithLookup: aClass )
types.
possibleTypes size = 1
ifTrue: [attribute declaredType: (self ensureClass: possibleTypes first
theNonMetaClass) ].
].
^ attribute
=========
--
Andre Hora
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"Some battles are better lost than fought."
8 Mar
8 Mar
9:35 p.m.
The TypeCollector is part of the RoelTyper. I am not sure what the status of this package
is. Does anybody know?
Cheers,
Doru
On Mar 8, 2013, at 11:24 AM, Andre Hora <andrehoraa(a)gmail.com> wrote:
Hi,
Test MooseSmalltalkImporterRoelTyperTest>>testASTCore is falling because at some
point it is using class TypeCollector, which is no longer in the system.
So what should we do:
- Remove this importer?
- Bring back TypeCollector?
========
SmalltalkImporter>>createAttribute: name for: aClass
...
ifTrue: [
possibleTypes := (TypeCollector typeInstvar: name asSymbol ofClassWithLookup: aClass )
types.
possibleTypes size = 1
ifTrue: [attribute declaredType: (self ensureClass: possibleTypes first
theNonMetaClass) ].
].
^ attribute
=========
--
Andre Hora
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"We cannot reach the flow of things unless we let go."
9 Mar
9 Mar
5:24 p.m.
On Mar 8, 2013, at 9:35 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote:
The TypeCollector is part of the RoelTyper. I am not
sure what the status of this package is. Does anybody know?
I migrated.
I checked the code and it is cleaned (no VW subpart)
All tests are green.
Now the question is if we want to load it or not.
Stef
Hi,
Test MooseSmalltalkImporterRoelTyperTest>>testASTCore is falling because at some
point it is using class TypeCollector, which is no longer in the system.
So what should we do:
- Remove this importer?
- Bring back TypeCollector?
========
SmalltalkImporter>>createAttribute: name for: aClass
...
ifTrue: [
possibleTypes := (TypeCollector typeInstvar: name asSymbol ofClassWithLookup: aClass )
types.
possibleTypes size = 1
ifTrue: [attribute declaredType: (self ensureClass: possibleTypes first
theNonMetaClass) ].
].
^ attribute
=========
--
Andre Hora
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"We cannot reach the flow of things unless we let go."
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev 
13 Mar
13 Mar
10:05 a.m.
On the other hand, is it really used?
There is also a small cost for keeping things around
nicolas
On 03/08/2013 09:35 PM, Tudor Girba wrote:
The TypeCollector is part of the RoelTyper. I am not
sure what the status of this package is. Does anybody know?
Cheers,
Doru
On Mar 8, 2013, at 11:24 AM, Andre Hora <andrehoraa(a)gmail.com> wrote:
--
Nicolas Anquetil -- RMod research team (Inria)
Hi,
Test MooseSmalltalkImporterRoelTyperTest>>testASTCore is falling because at some
point it is using class TypeCollector, which is no longer in the system.
So what should we do:
- Remove this importer?
- Bring back TypeCollector?
========
SmalltalkImporter>>createAttribute: name for: aClass
...
ifTrue: [
possibleTypes := (TypeCollector typeInstvar: name asSymbol ofClassWithLookup: aClass )
types.
possibleTypes size = 1
ifTrue: [attribute declaredType: (self ensureClass: possibleTypes first
theNonMetaClass) ].
].
^ attribute
=========
--
Andre Hora
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"We cannot reach the flow of things unless we let go."
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
14 Mar
14 Mar
8:07 a.m.
Hi,
Yes, it is used for Smalltalk import, and there is even a test for it that fails:
https://ci.inria.fr/moose/job/Moose-latest-dev-4.8/59/testReport/Moose.Test…
But, there was a bug at least in 1.4 and we could not use it at its full potential.
Cheers,
Doru
On Mar 13, 2013, at 10:05 AM, Nicolas Anquetil <Nicolas.Anquetil(a)inria.fr> wrote:
On the other hand, is it really used?
There is also a small cost for keeping things around
nicolas
On 03/08/2013 09:35 PM, Tudor Girba wrote:
--
www.tudorgirba.com
"From an abstract enough point of view, any two things are similar."
The TypeCollector is part of the RoelTyper. I am
not sure what the status of this package is. Does anybody know?
Cheers,
Doru
On Mar 8, 2013, at 11:24 AM, Andre Hora <andrehoraa(a)gmail.com> wrote:
--
Nicolas Anquetil -- RMod research team (Inria)
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev Hi,
Test MooseSmalltalkImporterRoelTyperTest>>testASTCore is falling because at some
point it is using class TypeCollector, which is no longer in the system.
So what should we do:
- Remove this importer?
- Bring back TypeCollector?
========
SmalltalkImporter>>createAttribute: name for: aClass
...
ifTrue: [
possibleTypes := (TypeCollector typeInstvar: name asSymbol ofClassWithLookup: aClass )
types.
possibleTypes size = 1
ifTrue: [attribute declaredType: (self ensureClass: possibleTypes first
theNonMetaClass) ].
].
^ attribute
=========
--
Andre Hora
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"We cannot reach the flow of things unless we let go."
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
4079
days inactive
4085
days old
6 comments
5 participants
participants (5)
-
Andre Hora -
Nicolas Anquetil -
stephane ducasse -
Tudor Girba -
Usman Bhatti