Hi Alex,
Could you please review the code in RTPNGExporter? We still get a little problem when exporting because it seems that there is a bit of clipping happening on the bottom and to the right.
Cheers, Doru
Hi!
Yes, I will have a look at it! Probably tomorrow.
Alexandre
Hi Doru!
I have reviewer & improved the PNG exporter. I have tried it in my different situation, it seems to work well. I have taken the decision to __not__ render fixed trachel shapes. I think this is okay in most of the cases we will face.
Let me know!
Cheers, Alexandre
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
Hi,
I did not see this mail until now.
What do you think the problem is?
Doru
On Thu, Nov 13, 2014 at 8:11 PM, Alexandre Bergel alexandre.bergel@me.com wrote:
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 13, 2014, at 12:36 PM, Alexandre Bergel alexandre.bergel@me.com wrote:
Hi Doru!
I have reviewer & improved the PNG exporter. I have tried it in my different situation, it seems to work well. I have taken the decision to __not__ render fixed trachel shapes. I think this is okay in most of the cases we will face.
Let me know!
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 12, 2014, at 12:43 PM, Tudor Girba tudor@tudorgirba.com wrote:
Hi Alex,
Could you please review the code in RTPNGExporter? We still get a little problem when exporting because it seems that there is a bit of clipping happening on the bottom and to the right.
Cheers, Doru
-- www.tudorgirba.com
"Every thing has its own flow"
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
2014-11-13 20:11 GMT+01:00 Alexandre Bergel alexandre.bergel@me.com:
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
this may be an issue with cairo rending on a (really) big surface. I bet you won't be able to render that big images with morphic. (morphic only renders/exports the visible part).
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 13, 2014, at 12:36 PM, Alexandre Bergel alexandre.bergel@me.com wrote:
Hi Doru!
I have reviewer & improved the PNG exporter. I have tried it in my different situation, it seems to work well. I have taken the decision to __not__ render fixed trachel shapes. I think this is okay in most of the cases we will face.
Let me know!
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 12, 2014, at 12:43 PM, Tudor Girba tudor@tudorgirba.com wrote:
Hi Alex,
Could you please review the code in RTPNGExporter? We still get a little problem when exporting because it seems that there is a bit of clipping happening on the bottom and to the right.
Cheers, Doru
-- www.tudorgirba.com
"Every thing has its own flow"
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Nah, morphic works. What you do is have it write to a canvas big enough to hold the drawing, then get the form under it, and then save that out. So, something like this in the morph:
asForm | canvas | canvas := FormCanvas extent: self extent. self drawOn: canvas. ^canvas contentsOfArea: bounds
and write it out with:
PNGReadWriter putForm: morph asForm onFileNamed: 'someFileName.png'
I've used this with rediculously large diagrams before.
-chris
On Thu, Nov 13, 2014 at 3:40 PM, Nicolai Hess nicolaihess@web.de wrote:
2014-11-13 20:11 GMT+01:00 Alexandre Bergel alexandre.bergel@me.com:
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
this may be an issue with cairo rending on a (really) big surface. I bet you won't be able to render that big images with morphic. (morphic only renders/exports the visible part).
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 13, 2014, at 12:36 PM, Alexandre Bergel alexandre.bergel@me.com wrote:
Hi Doru!
I have reviewer & improved the PNG exporter. I have tried it in my different situation, it seems to work well. I have taken the decision to __not__ render fixed trachel shapes. I think this is okay in most of the cases we will face.
Let me know!
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 12, 2014, at 12:43 PM, Tudor Girba tudor@tudorgirba.com wrote:
Hi Alex,
Could you please review the code in RTPNGExporter? We still get a little problem when exporting because it seems that there is a bit of clipping happening on the bottom and to the right.
Cheers, Doru
-- www.tudorgirba.com
"Every thing has its own flow"
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Hi, how did you make it export whole TRCanvas, not only current view? My exporter temporarily resizes morph to match canvas extent and then it calls this your code, but I have issues for large canvases, like for alexandre's example few mails ago. Issues like canvas shifted to the side replaced by black color, whole image white, etc.
I was originally using PNGReadWriter putForm: canvas morph imageForm onFileNamed: fileName but there seem to come such problems even with smaller canvases.
Jan
Chris Cunningham wrote
Nah, morphic works. What you do is have it write to a canvas big enough to hold the drawing, then get the form under it, and then save that out. So, something like this in the morph:
asForm | canvas | canvas := FormCanvas extent: self extent. self drawOn: canvas. ^canvas contentsOfArea: bounds
and write it out with:
PNGReadWriter putForm: morph asForm onFileNamed: 'someFileName.png'
I've used this with rediculously large diagrams before.
-chris
On Thu, Nov 13, 2014 at 3:40 PM, Nicolai Hess <
nicolaihess@
> wrote:
2014-11-13 20:11 GMT+01:00 Alexandre Bergel <
alexandre.bergel@
>:
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
this may be an issue with cairo rending on a (really) big surface. I bet you won't be able to render that big images with morphic. (morphic only renders/exports the visible part).
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 13, 2014, at 12:36 PM, Alexandre Bergel <
alexandre.bergel@
>
wrote:
Hi Doru!
I have reviewer & improved the PNG exporter. I have tried it in my different situation, it seems to work well. I have taken the decision to __not__ render fixed trachel shapes. I think this is okay in most of the cases we will face.
Let me know!
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 12, 2014, at 12:43 PM, Tudor Girba <
tudor@
> wrote:
Hi Alex,
Could you please review the code in RTPNGExporter? We still get a little problem when exporting because it seems that there is a bit of clipping happening on the bottom and to the right.
Cheers, Doru
-- www.tudorgirba.com
"Every thing has its own flow"
Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list
Moose-dev@.unibe
Moose-dev mailing list
Moose-dev@.unibe
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790147.html Sent from the Moose mailing list archive at Nabble.com.
Well, it seems mine is unable to export large pictures too, just for different reason: memory. Exported BMP for 7500*7500 px image has over 160 MB and Pharo's Windows VM memory limit is only 500 MB
Jan
abergel wrote
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790146.html Sent from the Moose mailing list archive at Nabble.com.
Jan, I went through your exporter, and it seems to do an interesting job. I will be happy to include it in Roassal for others to have a look at it.
Alexandre
Great. Could you commit it. I could take a look?
Doru
On Fri, Nov 14, 2014 at 3:11 PM, Alexandre Bergel alexandre.bergel@me.com wrote:
Jan, I went through your exporter, and it seems to do an interesting job. I will be happy to include it in Roassal for others to have a look at it.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:03 AM, Jan B. bliznjan@fit.cvut.cz wrote:
Well, it seems mine is unable to export large pictures too, just for different reason: memory. Exported BMP for 7500*7500 px image has over 160 MB and Pharo's Windows VM memory limit is only 500 MB
Jan
abergel wrote
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790146.html Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Thanks, however, in my exporter is exactly same problem as in yours, just where your stops creating files, my creates just white background. Interesting thing is that sometimes when it is unable to export, I save and quit Pharo, reopen and it exports fine. I would say something about memory related something, but when I opened 500 windows, it did not stop working because of that. Plus my exporting via morph seems to have another limitation, which is 10000 px on width and height, anything beyond it gets cropped. Anyway, here it is, just updated with scaling down when too large, few fixes (like exporting canvas which is not open anywhere): http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
Jan
abergel wrote
Jan, I went through your exporter, and it seems to do an interesting job. I will be happy to include it in Roassal for others to have a look at it.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:03 AM, Jan B. <
bliznjan@.cvut
> wrote:
Well, it seems mine is unable to export large pictures too, just for different reason: memory. Exported BMP for 7500*7500 px image has over 160 MB and Pharo's Windows VM memory limit is only 500 MB
Jan
abergel wrote
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790146.html Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list
Moose-dev@.unibe
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790238.html Sent from the Moose mailing list archive at Nabble.com.
Anyone want to play with Jan’s exporter? I like the fact that you can select whether you want to have fixed shapes or not.
Cheers, Alexandre
Yes. Where is the code?
-- www.tudorgirba.com
"Every thing has its own flow"
On 14 Nov 2014, at 18:19, Alexandre Bergel alexandre.bergel@me.com wrote:
Anyone want to play with Jan’s exporter? I like the fact that you can select whether you want to have fixed shapes or not.
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:06 PM, Jan B. bliznjan@fit.cvut.cz wrote:
Thanks, however, in my exporter is exactly same problem as in yours, just where your stops creating files, my creates just white background. Interesting thing is that sometimes when it is unable to export, I save and quit Pharo, reopen and it exports fine. I would say something about memory related something, but when I opened 500 windows, it did not stop working because of that. Plus my exporting via morph seems to have another limitation, which is 10000 px on width and height, anything beyond it gets cropped. Anyway, here it is, just updated with scaling down when too large, few fixes (like exporting canvas which is not open anywhere): http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
Jan
abergel wrote
Jan, I went through your exporter, and it seems to do an interesting job. I will be happy to include it in Roassal for others to have a look at it.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:03 AM, Jan B. <
bliznjan@.cvut
> wrote:
Well, it seems mine is unable to export large pictures too, just for different reason: memory. Exported BMP for 7500*7500 px image has over 160 MB and Pharo's Windows VM memory limit is only 500 MB
Jan
abergel wrote
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790146.html Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list
Moose-dev@.unibe
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790238.html Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
I did not get a chance of going over it. Anyone else?
We need a resolution this week so that we can release next week.
Cheers, Doru
On Fri, Nov 14, 2014 at 8:56 PM, Alexandre Bergel alexandre.bergel@me.com wrote:
http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 3:37 PM, Tudor Girba tudor@tudorgirba.com wrote:
Yes. Where is the code?
-- www.tudorgirba.com
"Every thing has its own flow"
On 14 Nov 2014, at 18:19, Alexandre Bergel alexandre.bergel@me.com wrote:
Anyone want to play with Jan’s exporter? I like the fact that you can select whether you want to have fixed shapes or not.
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:06 PM, Jan B. bliznjan@fit.cvut.cz wrote:
Thanks, however, in my exporter is exactly same problem as in yours, just where your stops creating files, my creates just white background. Interesting thing is that sometimes when it is unable to export, I save and quit Pharo, reopen and it exports fine. I would say something about memory related something, but when I opened 500 windows, it did not stop working because of that. Plus my exporting via morph seems to have another limitation, which is 10000 px on width and height, anything beyond it gets cropped. Anyway, here it is, just updated with scaling down when too large, few fixes (like exporting canvas which is not open anywhere): http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
Jan
abergel wrote
Jan, I went through your exporter, and it seems to do an interesting job. I will be happy to include it in Roassal for others to have a look at it.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:03 AM, Jan B. <
bliznjan@.cvut
> wrote:
Well, it seems mine is unable to export large pictures too, just for different reason: memory. Exported BMP for 7500*7500 px image has over 160 MB and Pharo's Windows VM memory limit is only 500 MB
Jan
abergel wrote
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790146.html Sent from the Moose mailing list archive at Nabble.com http://nabble.com/. _______________________________________________ Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790238.html Sent from the Moose mailing list archive at Nabble.com http://nabble.com/. _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
2014-11-18 13:51 GMT+01:00 Tudor Girba tudor@tudorgirba.com:
I did not get a chance of going over it. Anyone else?
We need a resolution this week so that we can release next week.
which one, the DCTRCanvasExporter? I didn't test the code, just looked at the source.
It looks good and I like the scaleToMorphLimits
What I don't like is the "construct-class-name-from-image-extension-name":
Smalltalk at: (imageFormatUC , 'ReadWriter') asSymbol
Cheers, Doru
On Fri, Nov 14, 2014 at 8:56 PM, Alexandre Bergel <alexandre.bergel@me.com
wrote:
http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 3:37 PM, Tudor Girba tudor@tudorgirba.com wrote:
Yes. Where is the code?
-- www.tudorgirba.com
"Every thing has its own flow"
On 14 Nov 2014, at 18:19, Alexandre Bergel alexandre.bergel@me.com wrote:
Anyone want to play with Jan’s exporter? I like the fact that you can select whether you want to have fixed shapes or not.
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:06 PM, Jan B. bliznjan@fit.cvut.cz wrote:
Thanks, however, in my exporter is exactly same problem as in yours, just where your stops creating files, my creates just white background. Interesting thing is that sometimes when it is unable to export, I save and quit Pharo, reopen and it exports fine. I would say something about memory related something, but when I opened 500 windows, it did not stop working because of that. Plus my exporting via morph seems to have another limitation, which is 10000 px on width and height, anything beyond it gets cropped. Anyway, here it is, just updated with scaling down when too large, few fixes (like exporting canvas which is not open anywhere): http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
Jan
abergel wrote
Jan, I went through your exporter, and it seems to do an interesting job. I will be happy to include it in Roassal for others to have a look at it.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:03 AM, Jan B. <
bliznjan@.cvut
> wrote:
Well, it seems mine is unable to export large pictures too, just for different reason: memory. Exported BMP for 7500*7500 px image has over 160 MB and Pharo's Windows VM memory limit is only 500 MB
Jan
abergel wrote
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790146.html Sent from the Moose mailing list archive at Nabble.com http://nabble.com/. _______________________________________________ Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790238.html Sent from the Moose mailing list archive at Nabble.com http://nabble.com/. _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Every thing has its own flow"
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Hi
Well, that's not the first time I hear that I should try to avoid symbols in interface and calls outside my class, I'm just not yet sure why is that. Might it be refactoring, which would not change names in symbols?
Anyway, there is version without them... export: method replaced by asPNG, asBMP etc. and without constructing class names
http://www.mediafire.com/download/htnazneiizll539/DCTRCanvasExporter02.st
Jan
Nicolai Hess wrote
2014-11-18 13:51 GMT+01:00 Tudor Girba <
tudor@
>:
I did not get a chance of going over it. Anyone else?
We need a resolution this week so that we can release next week.
which one, the DCTRCanvasExporter? I didn't test the code, just looked at the source.
It looks good and I like the scaleToMorphLimits
What I don't like is the "construct-class-name-from-image-extension-name":
Smalltalk at: (imageFormatUC , 'ReadWriter') asSymbol
Cheers, Doru
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4792320.html Sent from the Moose mailing list archive at Nabble.com.
2014-11-26 12:24 GMT+01:00 Jan B. bliznjan@fit.cvut.cz:
Hi
Well, that's not the first time I hear that I should try to avoid symbols in interface and calls outside my class, I'm just not yet sure why is that. Might it be refactoring, which would not change names in symbols?
Yes, and a search like "users of" or "references to " ( SystemNavigation default browseAllCallsOnClass:PNGReadWriter ) Can not find code where the class name is constructed with string concatenation.
Anyway, there is version without them... export: method replaced by asPNG, asBMP etc. and without constructing class names
http://www.mediafire.com/download/htnazneiizll539/DCTRCanvasExporter02.st
Jan
Nicolai Hess wrote
2014-11-18 13:51 GMT+01:00 Tudor Girba <
tudor@
>:
I did not get a chance of going over it. Anyone else?
We need a resolution this week so that we can release next week.
which one, the DCTRCanvasExporter? I didn't test the code, just looked at the source.
It looks good and I like the scaleToMorphLimits
What I don't like is the
"construct-class-name-from-image-extension-name":
Smalltalk at: (imageFormatUC , 'ReadWriter') asSymbol
Cheers, Doru
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4792320.html Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
+1.
Let's leave string concatenation for other languages :)
Doru
On Wed, Nov 26, 2014 at 8:47 PM, Nicolai Hess nicolaihess@web.de wrote:
2014-11-26 12:24 GMT+01:00 Jan B. bliznjan@fit.cvut.cz:
Hi
Well, that's not the first time I hear that I should try to avoid symbols in interface and calls outside my class, I'm just not yet sure why is that. Might it be refactoring, which would not change names in symbols?
Yes, and a search like "users of" or "references to " ( SystemNavigation default browseAllCallsOnClass:PNGReadWriter ) Can not find code where the class name is constructed with string concatenation.
Anyway, there is version without them... export: method replaced by asPNG, asBMP etc. and without constructing class names
http://www.mediafire.com/download/htnazneiizll539/DCTRCanvasExporter02.st
Jan
Nicolai Hess wrote
2014-11-18 13:51 GMT+01:00 Tudor Girba <
tudor@
>:
I did not get a chance of going over it. Anyone else?
We need a resolution this week so that we can release next week.
which one, the DCTRCanvasExporter? I didn't test the code, just looked at the source.
It looks good and I like the scaleToMorphLimits
What I don't like is the
"construct-class-name-from-image-extension-name":
Smalltalk at: (imageFormatUC , 'ReadWriter') asSymbol
Cheers, Doru
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4792320.html Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Hi!
It took me some time. I have included your PNG exporter in Roassal.
Cheers, Alexandre
On Nov 14, 2014, at 1:06 PM, Jan B. bliznjan@fit.cvut.cz wrote:
Thanks, however, in my exporter is exactly same problem as in yours, just where your stops creating files, my creates just white background. Interesting thing is that sometimes when it is unable to export, I save and quit Pharo, reopen and it exports fine. I would say something about memory related something, but when I opened 500 windows, it did not stop working because of that. Plus my exporting via morph seems to have another limitation, which is 10000 px on width and height, anything beyond it gets cropped. Anyway, here it is, just updated with scaling down when too large, few fixes (like exporting canvas which is not open anywhere): http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
Jan
abergel wrote
Jan, I went through your exporter, and it seems to do an interesting job. I will be happy to include it in Roassal for others to have a look at it.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On Nov 14, 2014, at 1:03 AM, Jan B. <
bliznjan@.cvut
> wrote:
Well, it seems mine is unable to export large pictures too, just for different reason: memory. Exported BMP for 7500*7500 px image has over 160 MB and Pharo's Windows VM memory limit is only 500 MB
Jan
abergel wrote
no no no :-(
It does not work for large pictures. Consider the following:
| b | b := RTMondrianViewBuilder new. b shape rectangle withBorder; width: [ :cls | cls numberOfVariables * 5]; height: #numberOfMethods; linearFillColor: #numberOfLinesOfCode within: RTObject withAllSubclasses. b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000). b edgesFrom: #superclass. b treeLayout. b build. ^ b view
Nothing gets on the disk when you save :-(
Jan B. sent me a morphic based exporter.
Alexandre
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790146.html Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list
Moose-dev@.unibe
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790238.html Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-
Alexandre Bergel -
Chris Cunningham -
Jan B. -
Nicolai Hess -
Tudor Girba