2014-11-26 12:24 GMT+01:00 Jan B. <bliznjan@fit.cvut.cz>:

Hi

Well, that's not the first time I hear that I should try to avoid symbols in
interface and calls outside my class, I'm just not yet sure why is that.
Might it be refactoring, which would not change names in symbols?

Yes, and a search like "users of" or "references to " ( SystemNavigation default browseAllCallsOnClass:PNGReadWriter )

Can not find code where the class name is constructed with string concatenation.

 

Anyway, there is version without them...
export: method replaced by asPNG, asBMP etc. and without constructing class
names

http://www.mediafire.com/download/htnazneiizll539/DCTRCanvasExporter02.st

Jan


Nicolai Hess wrote
> 2014-11-18 13:51 GMT+01:00 Tudor Girba &lt;

> tudor@

> &gt;:
>
>> I did not get a chance of going over it. Anyone else?
>>
>> We need a resolution this week so that we can release next week.
>>
>
> which one, the DCTRCanvasExporter?
> I didn't test the code, just looked at the source.
>
> It looks good and I like the scaleToMorphLimits
>
> What I don't like is the "construct-class-name-from-image-extension-name":
>
> Smalltalk at: (imageFormatUC , 'ReadWriter') asSymbol
>
>
>
>
>
>
>>
>> Cheers,
>> Doru
>>





--
View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4792320.html

Sent from the Moose mailing list archive at Nabble.com.
_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________
Moose-dev mailing list
Moose-dev@iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev