30 Aug
2013
30 Aug
'13
9:31 p.m.
Nicolas wrote:
did you run the tests before?
I believe I saw some of them fail in the past ... ?
Uhm, we broke the build from 981 to 984,
but I'm not aware of earlier problems.
Stephan
1 Sep
1 Sep
7:56 a.m.
New subject: Change in FAME
Hi,
I went a bit over your code. Interesting finding. We had a similar idea
with MooseMinimalState, but you are bringing it forward.
After loading your improvement, I get on the ArgoUML 0.34:
FMNullMultivalueLink allInstances size ==> 567234
FMMultivalueLink allInstances size ==> 103591
This is signifiant! Good catch.
However, there is still an issue with the way you are dynamically
transforming the null value into a real value:
noMoreNull
self owner instVarNamed: self selector put:
(FMMultivalueLink on: self owner opposite: self opposite).
^(self owner perform: self selector)
Here you are assuming that there is an instance variable with the name of
the selector. This is brittle. We need to find a better way.
Doru
On Fri, Aug 30, 2013 at 9:31 PM, Stephan Eggermont <stephan(a)stack.nl> wrote:
Nicolas wrote:
--
www.tudorgirba.com
"Every thing has its own flow"
did you run the tests before?
I believe I saw some of them fail in the past ... ?
Uhm, we broke the build from 981 to 984,
but I'm not aware of earlier problems.
Stephan
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
4 Sep
4 Sep
1:50 p.m.
New subject: Change in FAME
Hi,
The introduction of FMNullMultivalueLink leads to error in Orion. So we made some
modifications.
Most specifically, the remark of Doru concerning the assumed presence of a selector with
the same name raised issues in Orion. To correct that, noMoreNull has been modified to:
noMoreNull
^ (self owner instVarNamed: self selector put:
(FMMultivalueLink on: self owner opposite: self opposite)).
We also modified FMNullMultivalueLink >>unsafeadd (by adding the return):
unsafeAdd: anElement
^self noMoreNull unsafeAdd: anElement
And finally, we remove the species method in order it returns a FMNullMultivalueLink and
not an OrderedCollection.
We committed these changes and the tests of Moose remain green. The tests of Orion are now
green.
Anne
Le 1 sept. 2013 à 07:56, Tudor Girba a écrit :
Hi,
I went a bit over your code. Interesting finding. We had a similar idea with
MooseMinimalState, but you are bringing it forward.
After loading your improvement, I get on the ArgoUML 0.34:
FMNullMultivalueLink allInstances size ==> 567234
FMMultivalueLink allInstances size ==> 103591
This is signifiant! Good catch.
However, there is still an issue with the way you are dynamically transforming the null
value into a real value:
noMoreNull
self owner instVarNamed: self selector put:
(FMMultivalueLink on: self owner opposite: self opposite).
^(self owner perform: self selector)
Here you are assuming that there is an instance variable with the name of the selector.
This is brittle. We need to find a better way.
Doru
On Fri, Aug 30, 2013 at 9:31 PM, Stephan Eggermont <stephan(a)stack.nl> wrote:
Nicolas wrote:
did you run the tests before?
I believe I saw some of them fail in the past ... ?
Uhm, we broke the build from 981 to 984,
but I'm not aware of earlier problems.
Stephan
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"Every thing has its own flow"
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
3880
days inactive
3885
days old
2 comments
3 participants
participants (3)
-
Anne Etien -
Stephan Eggermont -
Tudor Girba