sourceText method wrong implementation

List overview All Threads
Download

newer

older

PetitJava status

Parse VisualAge Smalltalk st files...

Fabrizio Perin

4 Mar 2013 4 Mar '13

5:12 p.m.

Attachments:

attachment.htm (text/html — 606 bytes)

Show replies by date

Tudor Girba

5 Mar 5 Mar

7:49 a.m.

Indeed. Good catch. Just make sure you commit it to SmalltalkHub. You should give us the user so that we can add you. Cheers, Doru On Mar 4, 2013, at 5:12 PM, Fabrizio Perin <fabrizio.perin(a)gmail.com> wrote:

...

Hi, I have noticed that both FAMIXClass and FAMIXMethod sourceText methods starts with: self mooseModel isSmalltalk I think this is wrong. It should always be: self sourceLanguage isSmalltalk This way if a FAMIX element has a language which is default language for the model you can capture that. Do you agree? Cheers, Fabrizio _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "Sometimes the best solution is not the best solution."

Fabrizio Perin

8:33 a.m.

Hi Doru, just created an account, the user name is: FabrizioPerin Cheers, Fabrizio 2013/3/5 Tudor Girba <tudor(a)tudorgirba.com>

...

Hi, I have noticed that both FAMIXClass and FAMIXMethod sourceText methods

starts with:

self mooseModel isSmalltalk I think this is wrong. It should always be: self sourceLanguage isSmalltalk This way if a FAMIX element has a language which is default language for

the model you can capture that.

Do you agree? Cheers, Fabrizio _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba

8:37 a.m.

You are in. Doru On Tue, Mar 5, 2013 at 8:33 AM, Fabrizio Perin <fabrizio.perin(a)gmail.com>wrote;wrote:

...

Hi Doru, just created an account, the user name is: FabrizioPerin Cheers, Fabrizio 2013/3/5 Tudor Girba <tudor(a)tudorgirba.com>

Hi, I have noticed that both FAMIXClass and FAMIXMethod sourceText methods

starts with:

self mooseModel isSmalltalk I think this is wrong. It should always be: self sourceLanguage isSmalltalk This way if a FAMIX element has a language which is default language

for the model you can capture that.

Do you agree? Cheers, Fabrizio _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "Every thing has its own flow"

Fabrizio Perin

3 p.m.

...

You are in. Doru On Tue, Mar 5, 2013 at 8:33 AM, Fabrizio Perin <fabrizio.perin(a)gmail.com>wrote;wrote:

Hi Doru, just created an account, the user name is: FabrizioPerin Cheers, Fabrizio 2013/3/5 Tudor Girba <tudor(a)tudorgirba.com>

Hi, I have noticed that both FAMIXClass and FAMIXMethod sourceText methods

starts with:

self mooseModel isSmalltalk I think this is wrong. It should always be: self sourceLanguage isSmalltalk This way if a FAMIX element has a language which is default language

for the model you can capture that.

Do you agree? Cheers, Fabrizio _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "Every thing has its own flow" _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba

10:17 p.m.

Thanks. Doru On Mar 5, 2013, at 3:00 PM, Fabrizio Perin <fabrizio.perin(a)gmail.com> wrote:

...

Thanks I will commit this evening on the repo because from the office I cannot access external repositories. (you know, security policies) Cheers, Fabrizio 2013/3/5 Tudor Girba <tudor(a)tudorgirba.com> You are in. Doru On Tue, Mar 5, 2013 at 8:33 AM, Fabrizio Perin <fabrizio.perin(a)gmail.com> wrote: Hi Doru, just created an account, the user name is: FabrizioPerin Cheers, Fabrizio 2013/3/5 Tudor Girba <tudor(a)tudorgirba.com> Indeed. Good catch. Just make sure you commit it to SmalltalkHub. You should give us the user so that we can add you. Cheers, Doru On Mar 4, 2013, at 5:12 PM, Fabrizio Perin <fabrizio.perin(a)gmail.com> wrote:

-- www.tudorgirba.com "Sometimes the best solution is not the best solution." _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "Every thing has its own flow" _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "Yesterday is a fact. Tomorrow is a possibility. Today is a challenge."

4310

days inactive

4311

days old

moose-dev@list.inf.unibe.ch

Manage subscription

5 comments

2 participants

tags (0)

participants (2)

Fabrizio Perin
Tudor Girba