Dark-theme compatibility :) - Moose-dev

Andrei Chis

2 May 2 May

11:11 a.m.

Hi, I had a look and Glamour hardcodes in a few places the color white :) GLMMorphicTextRenderer>>textMorphForModel: GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: GLMMorphicListingRenderer>>treeMorphFor:and: If you comment the line setting the color in the three methods above most of the moose related tools would work with the dark theme. I do not have time right now, but I can have a look later to set the color through the theme. Cheers, Andrei On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

...

Hi everyone, now there is a dark theme for Pharo that I was waiting for a long time. Is it hard to make Moose-related tools be compatible with it? First thing that I noticed is GTInspector background: Cheers Uko _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Stephan Eggermont

11:34 a.m.

...

On 2 mei 2014, at 11:27, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: and also that’s the path to follow: no application should have hardcoded colors (unless really part of the model, like showing graphics :P).

+1 and the same goes for font sizes & extents Stephan

Reply

Yuriy Tymchuk

2:42 a.m.

On 04 May 2014, at 01:51, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

...

On 02 May 2014, at 11:27, Esteban Lorenzano <estebanlm(a)gmail.com> wrote:

On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

Hi, I had a look and Glamour hardcodes in a few places the color white :) GLMMorphicTextRenderer>>textMorphForModel: GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: GLMMorphicListingRenderer>>treeMorphFor:and: If you comment the line setting the color in the three methods above most of the moose related tools would work with the dark theme. I do not have time right now, but I can have a look later to set the color through the theme. Cheers, Andrei

and also that’s the path to follow: no application should have hardcoded colors (unless really part of the model, like showing graphics :P).

Wait, UITheme does not have backgroundColor? It it added with dark theme package?

My bad. It should be #windowColor, right? Uko

...

Uko

Esteban

On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: Hi everyone, now there is a dark theme for Pharo that I was waiting for a long time. Is it hard to make Moose-related tools be compatible with it? First thing that I noticed is GTInspector background: <2014-05-02 at 10.40.57.png> Cheers Uko _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Andrei Chis

8:01 p.m.

On Sun, May 4, 2014 at 2:44 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

...

Thank you Andrei, I’ve just made changes and it works well. Do you know where can be a list’s selected item’s colour set? Because I failed to find it.

Does Glamour use another color, than then the default one, for the selected item? Can you give me an example. The debugger colors the stack items differently. You have to change: GTGenericStackDebugger>>textAttributesForStackEntry: Cheers, Andrei

...

Uko On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: Hi, I had a look and Glamour hardcodes in a few places the color white :) GLMMorphicTextRenderer>>textMorphForModel: GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: GLMMorphicListingRenderer>>treeMorphFor:and: If you comment the line setting the color in the three methods above most of the moose related tools would work with the dark theme. I do not have time right now, but I can have a look later to set the color through the theme. Cheers, Andrei On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com>wrote;wrote:

Hi everyone, now there is a dark theme for Pharo that I was waiting for a long time. Is it hard to make Moose-related tools be compatible with it? First thing that I noticed is GTInspector background: <2014-05-02 at 10.40.57.png> Cheers Uko _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Andrei Chis

5 May 5 May

11:11 a.m.

You forgot the screenshot :) On Sun, May 4, 2014 at 9:09 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

...

As you can see on a screenshot, selected item’s background is light grey and it interferes with white colour of a text. As far as I understand selected item’s colour in a dark theme is close to blue: UITheme current selectionColor -> (Color r: 0.027 g: 0.388 b: 0.678 alpha: 1.0) Uko On 04 May 2014, at 20:01, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: On Sun, May 4, 2014 at 2:44 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

Thank you Andrei, I’ve just made changes and it works well. Do you know where can be a list’s selected item’s colour set? Because I failed to find it.

Does Glamour use another color, than then the default one, for the selected item? Can you give me an example. The debugger colors the stack items differently. You have to change: GTGenericStackDebugger>>textAttributesForStackEntry: Cheers, Andrei

Uko On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: Hi, I had a look and Glamour hardcodes in a few places the color white :) GLMMorphicTextRenderer>>textMorphForModel: GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: GLMMorphicListingRenderer>>treeMorphFor:and: If you comment the line setting the color in the three methods above most of the moose related tools would work with the dark theme. I do not have time right now, but I can have a look later to set the color through the theme. Cheers, Andrei On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

Hi everyone, now there is a dark theme for Pharo that I was waiting for a long time. Is it hard to make Moose-related tools be compatible with it? First thing that I noticed is GTInspector background: <2014-05-02 at 10.40.57.png> Cheers Uko _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Andrei Chis

11:35 a.m.

I missed that :) If you're referring to the light gray color used to show the header of a table you can change that from MorphTreeColumnButton>>initialize Cheers, Andrei On Mon, May 5, 2014 at 11:15 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

...

It was it the very first email :) On 05 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: You forgot the screenshot :) On Sun, May 4, 2014 at 9:09 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com>wrote;wrote:

As you can see on a screenshot, selected item’s background is light grey and it interferes with white colour of a text. As far as I understand selected item’s colour in a dark theme is close to blue: UITheme current selectionColor -> (Color r: 0.027 g: 0.388 b: 0.678 alpha: 1.0) Uko On 04 May 2014, at 20:01, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: On Sun, May 4, 2014 at 2:44 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

Thank you Andrei, I’ve just made changes and it works well. Do you know where can be a list’s selected item’s colour set? Because I failed to find it.

Does Glamour use another color, than then the default one, for the selected item? Can you give me an example. The debugger colors the stack items differently. You have to change: GTGenericStackDebugger>>textAttributesForStackEntry: Cheers, Andrei

Uko On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: Hi, I had a look and Glamour hardcodes in a few places the color white :) GLMMorphicTextRenderer>>textMorphForModel: GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: GLMMorphicListingRenderer>>treeMorphFor:and: If you comment the line setting the color in the three methods above most of the moose related tools would work with the dark theme. I do not have time right now, but I can have a look later to set the color through the theme. Cheers, Andrei On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

Hi everyone, now there is a dark theme for Pharo that I was waiting for a long time. Is it hard to make Moose-related tools be compatible with it? First thing that I noticed is GTInspector background: <2014-05-02 at 10.40.57.png> Cheers Uko _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Andrei Chis

3:02 p.m.

Hi Usman, That could be an option. Just from a quick look it's not very clear what has to be modified to add it consistently to Glamour. But I could dig deeper. If you want better contrast another option could be altering the lightBaseColor of the dark theme, as that setting is responsible with the background in Glamour. Cheers, Andrei On Wed, May 7, 2014 at 1:12 PM, Usman Bhatti <usman.bhatti(a)gmail.com> wrote:

...

Hi Andrei, Now, we have the default theme color as the default color for all presentations/panes in Glamour except a few, sometimes, black on gray is not desirable. Does it make sense to add a backgroundColor: for GLMFormatedPresentation so that we that custom browsers do not have to rely on the default theme color? I found color: but it seems to change the border color only. tx. usman On Mon, May 5, 2014 at 11:35 AM, Andrei Chis <chisvasileandrei(a)gmail.com>wrote;wrote:

I missed that :) If you're referring to the light gray color used to show the header of a table you can change that from MorphTreeColumnButton>>initialize Cheers, Andrei On Mon, May 5, 2014 at 11:15 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com>wrote;wrote:

It was it the very first email :) On 05 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: You forgot the screenshot :) On Sun, May 4, 2014 at 9:09 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com>wrote;wrote:

As you can see on a screenshot, selected item’s background is light grey and it interferes with white colour of a text. As far as I understand selected item’s colour in a dark theme is close to blue: UITheme current selectionColor -> (Color r: 0.027 g: 0.388 b: 0.678 alpha: 1.0) Uko On 04 May 2014, at 20:01, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: On Sun, May 4, 2014 at 2:44 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > Thank you Andrei, I’ve just made changes and it works well. Do you > know where can be a list’s selected item’s colour set? Because I failed to > find it. > Does Glamour use another color, than then the default one, for the selected item? Can you give me an example. The debugger colors the stack items differently. You have to change: GTGenericStackDebugger>>textAttributesForStackEntry: Cheers, Andrei > Uko > > On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> > wrote: > > Hi, > > I had a look and Glamour hardcodes in a few places the color white :) > > GLMMorphicTextRenderer>>textMorphForModel: > GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: > GLMMorphicListingRenderer>>treeMorphFor:and: > > If you comment the line setting the color in the three methods above > most of the moose related tools would work with the dark theme. > I do not have time right now, but I can have a look later to set the > color through the theme. > > Cheers, > Andrei > > > > On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> > wrote: > >> Hi everyone, >> >> now there is a dark theme for Pharo that I was waiting for a long >> time. Is it hard to make Moose-related tools be compatible with it? First >> thing that I noticed is GTInspector background: >> >> <2014-05-02 at 10.40.57.png> >> >> Cheers >> Uko >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Yuriy Tymchuk

31 May 31 May

11:45 a.m.

Hi, the background of GTInspector became white for me again. Were there any changes around that recently? Uko On 07 May 2014, at 18:55, Usman Bhatti <usman.bhatti(a)gmail.com> wrote:

...

On Wed, May 7, 2014 at 3:02 PM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: Hi Usman, That could be an option. Just from a quick look it's not very clear what has to be modified to add it consistently to Glamour. But I could dig deeper. If you want better contrast another option could be altering the lightBaseColor of the dark theme, as that setting is responsible with the background in Glamour. Yes. I saw that there was a way to play with theme to change the background color of the browsers. If you have time to look into customizing the colors for individual presentations, it'll be great. usman Cheers, Andrei On Wed, May 7, 2014 at 1:12 PM, Usman Bhatti <usman.bhatti(a)gmail.com> wrote: Hi Andrei, Now, we have the default theme color as the default color for all presentations/panes in Glamour except a few, sometimes, black on gray is not desirable. Does it make sense to add a backgroundColor: for GLMFormatedPresentation so that we that custom browsers do not have to rely on the default theme color? I found color: but it seems to change the border color only. tx. usman On Mon, May 5, 2014 at 11:35 AM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: I missed that :) If you're referring to the light gray color used to show the header of a table you can change that from MorphTreeColumnButton>>initialize Cheers, Andrei On Mon, May 5, 2014 at 11:15 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: It was it the very first email :) On 05 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

You forgot the screenshot :) On Sun, May 4, 2014 at 9:09 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: As you can see on a screenshot, selected item’s background is light grey and it interferes with white colour of a text. As far as I understand selected item’s colour in a dark theme is close to blue: UITheme current selectionColor -> (Color r: 0.027 g: 0.388 b: 0.678 alpha: 1.0) Uko On 04 May 2014, at 20:01, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

On Sun, May 4, 2014 at 2:44 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: Thank you Andrei, I’ve just made changes and it works well. Do you know where can be a list’s selected item’s colour set? Because I failed to find it. Does Glamour use another color, than then the default one, for the selected item? Can you give me an example. The debugger colors the stack items differently. You have to change: GTGenericStackDebugger>>textAttributesForStackEntry: Cheers, Andrei Uko On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

Hi, I had a look and Glamour hardcodes in a few places the color white :) GLMMorphicTextRenderer>>textMorphForModel: GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: GLMMorphicListingRenderer>>treeMorphFor:and: If you comment the line setting the color in the three methods above most of the moose related tools would work with the dark theme. I do not have time right now, but I can have a look later to set the color through the theme. Cheers, Andrei On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: Hi everyone, now there is a dark theme for Pharo that I was waiting for a long time. Is it hard to make Moose-related tools be compatible with it? First thing that I noticed is GTInspector background: <2014-05-02 at 10.40.57.png> Cheers Uko _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Yuriy Tymchuk

8:36 p.m.

Are there any suggestions where to look for hardcoded colour? Uko On 31 May 2014, at 23:34, Tudor Girba <tudor(a)tudorgirba.com> wrote:

...

Yes. The inspector is shifting a bit as we are moving to Rubric. Thanks for reporting. Cheers, Doru On Sat, May 31, 2014 at 11:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: Hi, the background of GTInspector became white for me again. Were there any changes around that recently? Uko On 07 May 2014, at 18:55, Usman Bhatti <usman.bhatti(a)gmail.com> wrote:

On Wed, May 7, 2014 at 3:02 PM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: Hi Usman, That could be an option. Just from a quick look it's not very clear what has to be modified to add it consistently to Glamour. But I could dig deeper. If you want better contrast another option could be altering the lightBaseColor of the dark theme, as that setting is responsible with the background in Glamour. Yes. I saw that there was a way to play with theme to change the background color of the browsers. If you have time to look into customizing the colors for individual presentations, it'll be great. usman Cheers, Andrei On Wed, May 7, 2014 at 1:12 PM, Usman Bhatti <usman.bhatti(a)gmail.com> wrote: Hi Andrei, Now, we have the default theme color as the default color for all presentations/panes in Glamour except a few, sometimes, black on gray is not desirable. Does it make sense to add a backgroundColor: for GLMFormatedPresentation so that we that custom browsers do not have to rely on the default theme color? I found color: but it seems to change the border color only. tx. usman On Mon, May 5, 2014 at 11:35 AM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: I missed that :) If you're referring to the light gray color used to show the header of a table you can change that from MorphTreeColumnButton>>initialize Cheers, Andrei On Mon, May 5, 2014 at 11:15 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: It was it the very first email :) On 05 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

You forgot the screenshot :) On Sun, May 4, 2014 at 9:09 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: As you can see on a screenshot, selected item’s background is light grey and it interferes with white colour of a text. As far as I understand selected item’s colour in a dark theme is close to blue: UITheme current selectionColor -> (Color r: 0.027 g: 0.388 b: 0.678 alpha: 1.0) Uko On 04 May 2014, at 20:01, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

On Sun, May 4, 2014 at 2:44 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: Thank you Andrei, I’ve just made changes and it works well. Do you know where can be a list’s selected item’s colour set? Because I failed to find it. Does Glamour use another color, than then the default one, for the selected item? Can you give me an example. The debugger colors the stack items differently. You have to change: GTGenericStackDebugger>>textAttributesForStackEntry: Cheers, Andrei Uko On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > Hi, > > I had a look and Glamour hardcodes in a few places the color white :) > > GLMMorphicTextRenderer>>textMorphForModel: > GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: > GLMMorphicListingRenderer>>treeMorphFor:and: > > If you comment the line setting the color in the three methods above most of the moose related tools would work with the dark theme. > I do not have time right now, but I can have a look later to set the color through the theme. > > Cheers, > Andrei > > > > On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > Hi everyone, > > now there is a dark theme for Pharo that I was waiting for a long time. Is it hard to make Moose-related tools be compatible with it? First thing that I noticed is GTInspector background: > > <2014-05-02 at 10.40.57.png> > > Cheers > Uko > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "Every thing has its own flow" _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Yuriy Tymchuk

2:06 p.m.

cool, thank you! On 01 Jun 2014, at 17:33, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

...

I updated the rubric renderer to use the theme color (Smalltalk ui theme windowColor). Still setting the color of the editor to the window color only works for the white/black theme. If I switch to the Pharo theme the color will be gray. I haven't check but maybe there is a textBackground color in the theme. Cheers, Andrei On Sat, May 31, 2014 at 8:36 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: Are there any suggestions where to look for hardcoded colour? Uko On 31 May 2014, at 23:34, Tudor Girba <tudor(a)tudorgirba.com> wrote:

Yes. The inspector is shifting a bit as we are moving to Rubric. Thanks for reporting. Cheers, Doru On Sat, May 31, 2014 at 11:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: Hi, the background of GTInspector became white for me again. Were there any changes around that recently? Uko On 07 May 2014, at 18:55, Usman Bhatti <usman.bhatti(a)gmail.com> wrote:

On Wed, May 7, 2014 at 3:02 PM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: Hi Usman, That could be an option. Just from a quick look it's not very clear what has to be modified to add it consistently to Glamour. But I could dig deeper. If you want better contrast another option could be altering the lightBaseColor of the dark theme, as that setting is responsible with the background in Glamour. Yes. I saw that there was a way to play with theme to change the background color of the browsers. If you have time to look into customizing the colors for individual presentations, it'll be great. usman Cheers, Andrei On Wed, May 7, 2014 at 1:12 PM, Usman Bhatti <usman.bhatti(a)gmail.com> wrote: Hi Andrei, Now, we have the default theme color as the default color for all presentations/panes in Glamour except a few, sometimes, black on gray is not desirable. Does it make sense to add a backgroundColor: for GLMFormatedPresentation so that we that custom browsers do not have to rely on the default theme color? I found color: but it seems to change the border color only. tx. usman On Mon, May 5, 2014 at 11:35 AM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: I missed that :) If you're referring to the light gray color used to show the header of a table you can change that from MorphTreeColumnButton>>initialize Cheers, Andrei On Mon, May 5, 2014 at 11:15 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: It was it the very first email :) On 05 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

You forgot the screenshot :) On Sun, May 4, 2014 at 9:09 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: As you can see on a screenshot, selected item’s background is light grey and it interferes with white colour of a text. As far as I understand selected item’s colour in a dark theme is close to blue: UITheme current selectionColor -> (Color r: 0.027 g: 0.388 b: 0.678 alpha: 1.0) Uko On 04 May 2014, at 20:01, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > > > > On Sun, May 4, 2014 at 2:44 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: > Thank you Andrei, I’ve just made changes and it works well. Do you know where can be a list’s selected item’s colour set? Because I failed to find it. > > Does Glamour use another color, than then the default one, for the selected item? Can you give me an example. > > The debugger colors the stack items differently. You have to change: GTGenericStackDebugger>>textAttributesForStackEntry: > > > Cheers, > Andrei > > > Uko > > On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: > >> Hi, >> >> I had a look and Glamour hardcodes in a few places the color white :) >> >> GLMMorphicTextRenderer>>textMorphForModel: >> GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: >> GLMMorphicListingRenderer>>treeMorphFor:and: >> >> If you comment the line setting the color in the three methods above most of the moose related tools would work with the dark theme. >> I do not have time right now, but I can have a look later to set the color through the theme. >> >> Cheers, >> Andrei >> >> >> >> On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote: >> Hi everyone, >> >> now there is a dark theme for Pharo that I was waiting for a long time. Is it hard to make Moose-related tools be compatible with it? First thing that I noticed is GTInspector background: >> >> <2014-05-02 at 10.40.57.png> >> >> Cheers >> Uko >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "Every thing has its own flow" _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Andrei Chis

11:26 p.m.

Yes I agree backgroundColor is a much better choice. Just right now moose is still based on Pharo 3. As soon as it moves to Pharo 4 I'll refactor this. Cheers, Andrei On Sun, Jun 1, 2014 at 3:51 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote:

...

btw… now that the changes for dark theme are integrated, I have to say that #windowColor and #backgroundColor *are not* equivalent. While #backgroundColor provides the color to show inside panels (like a text area), #windowColor defines the color of the windows (like his borders), so if you use it for define inner colors, you will be making a mistake (that we will need to refactorise later). cheers, Esteban On 01 Jun 2014, at 09:03, Andrei Chis <chisvasileandrei(a)gmail.com> wrote: I updated the rubric renderer to use the theme color (Smalltalk ui theme windowColor). Still setting the color of the editor to the window color only works for the white/black theme. If I switch to the Pharo theme the color will be gray. I haven't check but maybe there is a textBackground color in the theme. Cheers, Andrei On Sat, May 31, 2014 at 8:36 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

Are there any suggestions where to look for hardcoded colour? Uko On 31 May 2014, at 23:34, Tudor Girba <tudor(a)tudorgirba.com> wrote: Yes. The inspector is shifting a bit as we are moving to Rubric. Thanks for reporting. Cheers, Doru On Sat, May 31, 2014 at 11:45 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> wrote:

Hi, the background of GTInspector became white for me again. Were there any changes around that recently? Uko On 07 May 2014, at 18:55, Usman Bhatti <usman.bhatti(a)gmail.com> wrote: On Wed, May 7, 2014 at 3:02 PM, Andrei Chis <chisvasileandrei(a)gmail.com> wrote:

Hi Usman, That could be an option. Just from a quick look it's not very clear what has to be modified to add it consistently to Glamour. But I could dig deeper. If you want better contrast another option could be altering the lightBaseColor of the dark theme, as that setting is responsible with the background in Glamour.

Yes. I saw that there was a way to play with theme to change the background color of the browsers. If you have time to look into customizing the colors for individual presentations, it'll be great. usman

Cheers, Andrei On Wed, May 7, 2014 at 1:12 PM, Usman Bhatti <usman.bhatti(a)gmail.com> wrote: > Hi Andrei, > > Now, we have the default theme color as the default color for all > presentations/panes in Glamour except a few, sometimes, black on gray is > not desirable. Does it make sense to add a backgroundColor: for > GLMFormatedPresentation so that we that custom browsers do not have to rely > on the default theme color? I found color: but it seems to change the > border color only. > > tx. > > usman > > > On Mon, May 5, 2014 at 11:35 AM, Andrei Chis < > chisvasileandrei(a)gmail.com> wrote: > >> I missed that :) >> >> If you're referring to the light gray color used to show the header >> of a table you can change that from MorphTreeColumnButton>>initialize >> >> Cheers, >> Andrei >> >> >> On Mon, May 5, 2014 at 11:15 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> >> wrote: >> >>> It was it the very first email :) >>> >>> On 05 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> >>> wrote: >>> >>> You forgot the screenshot :) >>> >>> >>> On Sun, May 4, 2014 at 9:09 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com> >>> wrote: >>> >>>> As you can see on a screenshot, selected item’s background is light >>>> grey and it interferes with white colour of a text. As far as I understand >>>> selected item’s colour in a dark theme is close to blue: UITheme current >>>> selectionColor -> (Color r: 0.027 g: 0.388 b: 0.678 alpha: 1.0) >>>> >>>> Uko >>>> >>>> On 04 May 2014, at 20:01, Andrei Chis <chisvasileandrei(a)gmail.com> >>>> wrote: >>>> >>>> >>>> >>>> >>>> On Sun, May 4, 2014 at 2:44 AM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com >>>> > wrote: >>>> >>>>> Thank you Andrei, I’ve just made changes and it works well. Do you >>>>> know where can be a list’s selected item’s colour set? Because I failed to >>>>> find it. >>>>> >>>> >>>> Does Glamour use another color, than then the default one, for the >>>> selected item? Can you give me an example. >>>> >>>> The debugger colors the stack items differently. You have to >>>> change: GTGenericStackDebugger>>textAttributesForStackEntry: >>>> >>>> >>>> Cheers, >>>> Andrei >>>> >>>> >>>> >>>>> Uko >>>>> >>>>> On 02 May 2014, at 11:11, Andrei Chis <chisvasileandrei(a)gmail.com> >>>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> I had a look and Glamour hardcodes in a few places the color white >>>>> :) >>>>> >>>>> GLMMorphicTextRenderer>>textMorphForModel: >>>>> GLMMorphicSmalltalkCodeRenderer>>textMorphForModel: >>>>> GLMMorphicListingRenderer>>treeMorphFor:and: >>>>> >>>>> If you comment the line setting the color in the three methods >>>>> above most of the moose related tools would work with the dark theme. >>>>> I do not have time right now, but I can have a look later to set >>>>> the color through the theme. >>>>> >>>>> Cheers, >>>>> Andrei >>>>> >>>>> >>>>> >>>>> On Fri, May 2, 2014 at 10:45 AM, Yuriy Tymchuk < >>>>> yuriy.tymchuk(a)me.com> wrote: >>>>> >>>>>> Hi everyone, >>>>>> >>>>>> now there is a dark theme for Pharo that I was waiting for a long >>>>>> time. Is it hard to make Moose-related tools be compatible with it? First >>>>>> thing that I noticed is GTInspector background: >>>>>> >>>>>> <2014-05-02 at 10.40.57.png> >>>>>> >>>>>> Cheers >>>>>> Uko >>>>>> >>>>>> _______________________________________________ >>>>>> Moose-dev mailing list >>>>>> Moose-dev(a)iam.unibe.ch >>>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>>>> >>>>>> >>>>> _______________________________________________ >>>>> Moose-dev mailing list >>>>> Moose-dev(a)iam.unibe.ch >>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Moose-dev mailing list >>>>> Moose-dev(a)iam.unibe.ch >>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>>> >>>>> >>>> _______________________________________________ >>>> Moose-dev mailing list >>>> Moose-dev(a)iam.unibe.ch >>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>> >>>> >>>> >>>> _______________________________________________ >>>> Moose-dev mailing list >>>> Moose-dev(a)iam.unibe.ch >>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>> >>>> >>> _______________________________________________ >>> Moose-dev mailing list >>> Moose-dev(a)iam.unibe.ch >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>> >>> >>> >>> _______________________________________________ >>> Moose-dev mailing list >>> Moose-dev(a)iam.unibe.ch >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>> >>> >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "Every thing has its own flow" _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply