23 Mar
2011
23 Mar
'11
8:19 a.m.
Hi,
On 23 Mar 2011, at 01:58, Alexandre Bergel wrote:
Yes.
You are
looking at an old code. I already removed DudeDuplication>>mooseName.
Oups sorry!
But, there are still a couple of mooseNames
around. We should move all of them into mooseNameOn:
I fixed all I could find.
What about removing all implementors of mooseUniqueName ? They are deprecated since March 2009.
I fixed FAMIXParameterizedType>>mooseNameOn: but I am not particularly happy. I
had to check if parameterizableClass is a string or not. This stems from the method
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
FAMIXParameterizedType>>parameterizableClass
<MSEProperty: #parameterizableClass type: #FAMIXParameterizableClass>
<MSEComment: 'Base type of this parameterized type.'>
^self privateState attributeAt: #parameterizableClass ifAbsent: ['']
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Should it really be '' in case of absent? Why not nil?
Yes. This was a mistake.
Cheers,
Doru
Cheers,
Alexandre
--
www.tudorgirba.com
"It's not how it is, it is how we see it."
On 22 Mar 2011, at 22:17, Alexandre Bergel wrote:
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev Hi!
One of the test is yellow because of the mismatching there is of mooseName
DudeDuplication>>mooseName
((signature isNil or: [ referenceCode isNil ]) or: [ duplicateCode isNil ])
ifTrue: [ ^ 'Error' ].
^ 'Chain: ', signature, ' between: ', referenceCode mooseName, ' and
', duplicateCode mooseName
It is wrong to override mooseName. mooseNameOn: should be overridden instead.
Shall I update mooseName into mooseNameOn:?
Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know
her."
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev