Thanks! I checked the implementation of allRecursiveTypes It went from
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= FAMIXType>>allRecursiveTypes "Retrieves all types recursively"
^ self types union: (self types flatCollect: [:each | each allRecursiveTypes]). -=-=-=-=-=-=-=-=-=-=-=-=-=-=-= to
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= FAMIXType>>allRecursiveTypes "Retrieves all nested types recursively (including directly nested types and those nested in methods)" | result | result := Set new. self allRecursiveTypesDo: [:each | result add: each ]. ^ result -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
I am a bit puzzled. How comes that a new version of #union: break down so many tests. #union: is a simple operation.
Refactoring what is already existing. How should I refactor: -=-=-=-=-=-=-=-=-=-=-=-= FAMIXType>>providerNamespaces "returns a set of all the namespaces that the receiver depends on (they include some classes that the receiver inherites, staticly accesses, or uses some of their methods)" ^ self inheritedNamespaces union: self invokedNamespaces -=-=-=-=-=-=-=-=-=-=-=-=
I have the impression that we are bumping into something we should not have bumped into.
Cheers, Alexandre
On 18 Mar 2012, at 16:59, Tudor Girba wrote:
I fixed the problems related to allRecursiveTypes. However, there are still several usages of union: in the KGB API. I would be so happy if we would take the opportunity to simply remove most of this API and use Chef instead.
Anyone interested? :)
Doru
On 18 Mar 2012, at 20:41, Tudor Girba wrote:
Hi,
A ton of tests are still failing due to the issue of Collection>>union:. Most of these issues seem to come from the metrics that seem to overuse this functionality: http://ci.moosetechnology.org/job/moose-latest-dev/lastCompletedBuild/testRe...
It would be great if the authors would look over it.
Cheers, Doru
-- www.tudorgirba.com
"Live like you mean it."
-- www.tudorgirba.com
"Problem solving should be focused on describing the problem in a way that makes the solution obvious."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev