Thanks! I checked the implementation of allRecursiveTypes
It went from
"Retrieves all types recursively"
^ self types union: (self types flatCollect: [:each | each allRecursiveTypes]).
"Retrieves all nested types recursively (including directly nested types and those
nested in methods)"
| result |
result := Set new.
self allRecursiveTypesDo: [:each | result add: each ].
I am a bit puzzled. How comes that a new version of #union: break down so many tests.
#union: is a simple operation.
Refactoring what is already existing. How should I refactor:
"returns a set of all the namespaces that the receiver depends on (they include some
classes that the receiver inherites, staticly accesses, or uses some of their
^ self inheritedNamespaces union: self invokedNamespaces
I have the impression that we are bumping into something we should not have bumped into.
On 18 Mar 2012, at 16:59, Tudor Girba wrote:
I fixed the problems related to allRecursiveTypes. However, there are
still several usages of union: in the KGB API. I would be so happy if we would take the
opportunity to simply remove most of this API and use Chef instead.
Anyone interested? :)
On 18 Mar 2012, at 20:41, Tudor Girba wrote:
> A ton of tests are still failing due to the issue of Collection>>union:. Most
of these issues seem to come from the metrics that seem to overuse this functionality:
> It would be great if the authors would look over it.
> "Live like you mean it."
"Problem solving should be focused on describing
the problem in a way that makes the solution obvious."
Moose-dev mailing list
Alexandre Bergel http://www.bergel.eu