Ideally, we should not remove RoelTyper, especially that now Stef says that the tests run in 2.0.
Cheers, Doru
On Mar 8, 2013, at 11:38 AM, Usman Bhatti usman.bhatti@gmail.com wrote:
On Fri, Mar 8, 2013 at 11:24 AM, Andre Hora andrehoraa@gmail.com wrote: Hi,
Test MooseSmalltalkImporterRoelTyperTest>>testASTCore is falling because at some point it is using class TypeCollector, which is no longer in the system.
So what should we do:
- Remove this importer?
and throw away Roel-typer, all its tests, etc? Btw, its also used in NECompletionModel package (NECContext>>guessWithRoelTyper: aString class: aClass). Is it normal that we have NECompletion in Moose?
- Bring back TypeCollector?
========
SmalltalkImporter>>createAttribute: name for: aClass ... ifTrue: [ possibleTypes := (TypeCollector typeInstvar: name asSymbol ofClassWithLookup: aClass ) types. possibleTypes size = 1 ifTrue: [attribute declaredType: (self ensureClass: possibleTypes first theNonMetaClass) ]. ]. ^ attribute =========
-- Andre Hora
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Some battles are better lost than fought."