Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not.

Alex, could you take a look at that?

The next question is that if the border color is called all the time, what is the use of the bitmap cache?

> ====== > |view o | > view := MOViewRenderer new. > o := OrderedCollection new: 100. > 1 to: 100 do:[:i | o add: i]. > (view shape: (MORectangleShape new > width: [:e | 200]; > height: 200; > withBorder; > borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). > view nodes: o. > view layout: (MOGridLayout new gapSize: 1). > view open > ======

Hi Alex, >> Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not. > > I was wondering whether it would make sense to do this for all the metrics. Apparently yes, I then continued. All shape parameters should be cached. >> Alex, could you take a look at that? > > Done. Mondrian-Alexandre_Bergel.470 Great. I checked a bit the implementation, and I would only suggest to check for isCached in the attributeAt:ifAbsent: method, instead of in every *For: methods. >> The next question is that if the border color is called all the time, what is the use of the bitmap cache? > > The bitmap is for not having to display inner nodes. Recursion takes times. I know, but if you compute it once why do you still need to re-render? Cheers, Doru >>> ====== >>> |view o | >>> view := MOViewRenderer new. >>> o := OrderedCollection new: 100. >>> 1 to: 100 do:[:i | o add: i]. >>> (view shape: (MORectangleShape new >>> width: [:e | 200]; >>> height: 200; >>> withBorder; >>> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). >>> view nodes: o. >>> view layout: (MOGridLayout new gapSize: 1). >>> view open >>> ====== > > A better version could be > -=-=-=-=-=-=-=-=-=-=-=-= > |view o a | > a := {0}. > view := MOViewRenderer new. > o := OrderedCollection new: 100. > 1 to: 100 do:[:i | o add: i]. > (view shape: (MORectangleShape new > width: [:e | 200]; > height: 200; > withBorder; > borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). > view nodes: o. > view layout: (MOGridLayout new gapSize: 1). > view open. > a > -=-=-=-=-=-=-=-=-=-=-=-= > > Just inspect the expression, and see if the array a changes over the time. > > Is there any remaining problem left in Mondrian related to the speed issue? > > Cheers, > Alexandre > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "Some battles are better lost than fought."

Hi, Doru, do you do a DSM or a eDSM ? With a eDSM, I do not see difference, I think there are some computation somewhere else. Alex, do you cache all things ? Thanks, Jannik On Jun 17, 2010, at 17:47 , Tudor Girba wrote: > I tested on a regular DSM with 259 namespaces and I can now > properly scroll once it gets displayed. > > Jannik, Veronica, could you check in your cases? > > Cheers, > Doru > > > > On 17 Jun 2010, at 16:30, Tudor Girba wrote: > >> Hi Alex, >> >>>> Indeed, this caching should happen for all properties and for >>>> all shapes (both for nodes and for edges). I think that Alex >>>> stopped in the middle because he did not know whether this >>>> caching had an effect or not. >>> >>> I was wondering whether it would make sense to do this for all >>> the metrics. Apparently yes, I then continued. All shape >>> parameters should be cached. >>>> Alex, could you take a look at that? >>> >>> Done. Mondrian-Alexandre_Bergel.470 >> >> Great. I checked a bit the implementation, and I would only >> suggest to check for isCached in the attributeAt:ifAbsent: >> method, instead of in every *For: methods. >> >>>> The next question is that if the border color is called all >>>> the time, what is the use of the bitmap cache? >>> >>> The bitmap is for not having to display inner nodes. Recursion >>> takes times. >> >> I know, but if you compute it once why do you still need to re- >> render? >> >> Cheers, >> Doru >> >> >> >>>>> ====== >>>>> |view o | >>>>> view := MOViewRenderer new. >>>>> o := OrderedCollection new: 100. >>>>> 1 to: 100 do:[:i | o add: i]. >>>>> (view shape: (MORectangleShape new >>>>> width: [:e | 200]; >>>>> height: 200; >>>>> withBorder; >>>>> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color >>>>> gray])). >>>>> view nodes: o. >>>>> view layout: (MOGridLayout new gapSize: 1). >>>>> view open >>>>> ====== >>> >>> A better version could be >>> -=-=-=-=-=-=-=-=-=-=-=-= >>> |view o a | >>> a := {0}. >>> view := MOViewRenderer new. >>> o := OrderedCollection new: 100. >>> 1 to: 100 do:[:i | o add: i]. >>> (view shape: (MORectangleShape new >>> width: [:e | 200]; >>> height: 200; >>> withBorder; >>> borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). >>> view nodes: o. >>> view layout: (MOGridLayout new gapSize: 1). >>> view open. >>> a >>> -=-=-=-=-=-=-=-=-=-=-=-= >>> >>> Just inspect the expression, and see if the array a changes >>> over the time. >>> >>> Is there any remaining problem left in Mondrian related to the >>> speed issue? >>> >>> Cheers, >>> Alexandre >>> >>> >>> _______________________________________________ >>> Moose-dev mailing list >>> Moose-dev(a)iam.unibe.ch >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> -- >> www.tudorgirba.com >> >> "Some battles are better lost than fought." >> >> >> > > -- > www.tudorgirba.com > > "Some battles are better lost than fought." > > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev --- Jannik Laval _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Strange, it seems to be in a at:. I use it only to get the class name. Do you have some classes without name or with a name with size < 2 ? I change the code, now it should work. Cheers, Jannik On Jun 18, 2010, at 11:53 , Tudor Girba wrote: > Hi Jannik, > > I tried a DSM. The eDSM gives me a subscript out of bounds error > somewhere deep in the contentOfCell: aView for: aCell with: > aPackage out: aBoolean method. > > I applied this on the namespaces of JUnit. I attached the debug > log. > > Cheers, > Doru > > > <debug.log> > On 18 Jun 2010, at 07:19, Laval Jannik wrote: > >> Hi, >> >> Doru, do you do a DSM or a eDSM ? >> With a eDSM, I do not see difference, I think there are some >> computation somewhere else. >> Alex, do you cache all things ? >> >> Thanks, >> Jannik >> >> On Jun 17, 2010, at 17:47 , Tudor Girba wrote: >> >>> I tested on a regular DSM with 259 namespaces and I can now >>> properly scroll once it gets displayed. >>> >>> Jannik, Veronica, could you check in your cases? >>> >>> Cheers, >>> Doru >>> >>> >>> >>> On 17 Jun 2010, at 16:30, Tudor Girba wrote: >>> >>>> Hi Alex, >>>> >>>>>> Indeed, this caching should happen for all properties and >>>>>> for all shapes (both for nodes and for edges). I think that >>>>>> Alex stopped in the middle because he did not know whether >>>>>> this caching had an effect or not. >>>>> >>>>> I was wondering whether it would make sense to do this for >>>>> all the metrics. Apparently yes, I then continued. All shape >>>>> parameters should be cached. >>>>>> Alex, could you take a look at that? >>>>> >>>>> Done. Mondrian-Alexandre_Bergel.470 >>>> >>>> Great. I checked a bit the implementation, and I would only >>>> suggest to check for isCached in the attributeAt:ifAbsent: >>>> method, instead of in every *For: methods. >>>> >>>>>> The next question is that if the border color is called all >>>>>> the time, what is the use of the bitmap cache? >>>>> >>>>> The bitmap is for not having to display inner nodes. >>>>> Recursion takes times. >>>> >>>> I know, but if you compute it once why do you still need to >>>> re-render? >>>> >>>> Cheers, >>>> Doru >>>> >>>> >>>> >>>>>>> ====== >>>>>>> |view o | >>>>>>> view := MOViewRenderer new. >>>>>>> o := OrderedCollection new: 100. >>>>>>> 1 to: 100 do:[:i | o add: i]. >>>>>>> (view shape: (MORectangleShape new >>>>>>> width: [:e | 200]; >>>>>>> height: 200; >>>>>>> withBorder; >>>>>>> borderColor: [:e | (Delay forMilliseconds: 50) wait. >>>>>>> Color gray])). >>>>>>> view nodes: o. >>>>>>> view layout: (MOGridLayout new gapSize: 1). >>>>>>> view open >>>>>>> ====== >>>>> >>>>> A better version could be >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> |view o a | >>>>> a := {0}. >>>>> view := MOViewRenderer new. >>>>> o := OrderedCollection new: 100. >>>>> 1 to: 100 do:[:i | o add: i]. >>>>> (view shape: (MORectangleShape new >>>>> width: [:e | 200]; >>>>> height: 200; >>>>> withBorder; >>>>> borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). >>>>> view nodes: o. >>>>> view layout: (MOGridLayout new gapSize: 1). >>>>> view open. >>>>> a >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> >>>>> Just inspect the expression, and see if the array a changes >>>>> over the time. >>>>> >>>>> Is there any remaining problem left in Mondrian related to >>>>> the speed issue? >>>>> >>>>> Cheers, >>>>> Alexandre >>>>> >>>>> >>>>> _______________________________________________ >>>>> Moose-dev mailing list >>>>> Moose-dev(a)iam.unibe.ch >>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>> >>>> -- >>>> www.tudorgirba.com >>>> >>>> "Some battles are better lost than fought." >>>> >>>> >>>> >>> >>> -- >>> www.tudorgirba.com >>> >>> "Some battles are better lost than fought." >>> >>> >>> >>> _______________________________________________ >>> Moose-dev mailing list >>> Moose-dev(a)iam.unibe.ch >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> --- >> Jannik Laval >> >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > -- > www.tudorgirba.com > > "It's not how it is, it is how we see it." > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev --- Jannik Laval _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Hi Alex, >> Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not. > > I was wondering whether it would make sense to do this for all the metrics. Apparently yes, I then continued. All shape parameters should be cached. >> Alex, could you take a look at that? > > Done. Mondrian-Alexandre_Bergel.470 Great. I checked a bit the implementation, and I would only suggest to check for isCached in the attributeAt:ifAbsent: method, instead of in every *For: methods. >> The next question is that if the border color is called all the time, what is the use of the bitmap cache? > > The bitmap is for not having to display inner nodes. Recursion takes times. I know, but if you compute it once why do you still need to re-render? Cheers, Doru >>> ====== >>> |view o | >>> view := MOViewRenderer new. >>> o := OrderedCollection new: 100. >>> 1 to: 100 do:[:i | o add: i]. >>> (view shape: (MORectangleShape new >>> width: [:e | 200]; >>> height: 200; >>> withBorder; >>> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). >>> view nodes: o. >>> view layout: (MOGridLayout new gapSize: 1). >>> view open >>> ====== > > A better version could be > -=-=-=-=-=-=-=-=-=-=-=-= > |view o a | > a := {0}. > view := MOViewRenderer new. > o := OrderedCollection new: 100. > 1 to: 100 do:[:i | o add: i]. > (view shape: (MORectangleShape new > width: [:e | 200]; > height: 200; > withBorder; > borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). > view nodes: o. > view layout: (MOGridLayout new gapSize: 1). > view open. > a > -=-=-=-=-=-=-=-=-=-=-=-= > > Just inspect the expression, and see if the array a changes over the time. > > Is there any remaining problem left in Mondrian related to the speed issue? > > Cheers, > Alexandre > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "Some battles are better lost than fought."

Alex, do you cache all things ?

Thanks, Jannik On Jun 17, 2010, at 17:47 , Tudor Girba wrote: > I tested on a regular DSM with 259 namespaces and I can now properly scroll once it gets displayed. > > Jannik, Veronica, could you check in your cases? > > Cheers, > Doru > > > > On 17 Jun 2010, at 16:30, Tudor Girba wrote: > >> Hi Alex, >> >>>> Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not. >>> >>> I was wondering whether it would make sense to do this for all the metrics. Apparently yes, I then continued. All shape parameters should be cached. >>>> Alex, could you take a look at that? >>> >>> Done. Mondrian-Alexandre_Bergel.470 >> >> Great. I checked a bit the implementation, and I would only suggest to check for isCached in the attributeAt:ifAbsent: method, instead of in every *For: methods. >> >>>> The next question is that if the border color is called all the time, what is the use of the bitmap cache? >>> >>> The bitmap is for not having to display inner nodes. Recursion takes times. >> >> I know, but if you compute it once why do you still need to re-render? >> >> Cheers, >> Doru >> >> >> >>>>> ====== >>>>> |view o | >>>>> view := MOViewRenderer new. >>>>> o := OrderedCollection new: 100. >>>>> 1 to: 100 do:[:i | o add: i]. >>>>> (view shape: (MORectangleShape new >>>>> width: [:e | 200]; >>>>> height: 200; >>>>> withBorder; >>>>> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). >>>>> view nodes: o. >>>>> view layout: (MOGridLayout new gapSize: 1). >>>>> view open >>>>> ====== >>> >>> A better version could be >>> -=-=-=-=-=-=-=-=-=-=-=-= >>> |view o a | >>> a := {0}. >>> view := MOViewRenderer new. >>> o := OrderedCollection new: 100. >>> 1 to: 100 do:[:i | o add: i]. >>> (view shape: (MORectangleShape new >>> width: [:e | 200]; >>> height: 200; >>> withBorder; >>> borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). >>> view nodes: o. >>> view layout: (MOGridLayout new gapSize: 1). >>> view open. >>> a >>> -=-=-=-=-=-=-=-=-=-=-=-= >>> >>> Just inspect the expression, and see if the array a changes over the time. >>> >>> Is there any remaining problem left in Mondrian related to the speed issue? >>> >>> Cheers, >>> Alexandre >>> >>> >>> _______________________________________________ >>> Moose-dev mailing list >>> Moose-dev(a)iam.unibe.ch >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> -- >> www.tudorgirba.com >> >> "Some battles are better lost than fought." >> >> >> > > -- > www.tudorgirba.com > > "Some battles are better lost than fought." > > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev --- Jannik Laval _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Hi Alex, There is something I do not understand. Why do you use a cache and not the state of the object ? Isn't it more efficient to store values in instance variable instead of a cache construct with a collection, or another complex structure. I'm sure you use cache for good reasons, and maybe my vision is too naive. But we have several problems which will appear in a near future: - if we do not use cache, visualization is slow. - if we use a cache, the space used by pharo will explode (for now, in a vm with original parameters, it is not possible to load 7 times the MooseModel of Moose itself) Now, if we have a state for a shape, there are no problem of cache or of refresh. But as I said before, my vision is maybe too naive. Please, explain your choice :) Thank you Cheers, Jannik PS: for a result, eDSM is always slow, so some parameters are not cached anymore ? On Jun 18, 2010, at 14:50 , Alexandre Bergel wrote: >> Alex, do you cache all things ? > > All the parameters in a shape that could be cached are now cached (e.g., width: height: fillColor: borderColor: ...) > > Cheers, > Alexandre > >> >> Thanks, >> Jannik >> >> On Jun 17, 2010, at 17:47 , Tudor Girba wrote: >> >>> I tested on a regular DSM with 259 namespaces and I can now properly scroll once it gets displayed. >>> >>> Jannik, Veronica, could you check in your cases? >>> >>> Cheers, >>> Doru >>> >>> >>> >>> On 17 Jun 2010, at 16:30, Tudor Girba wrote: >>> >>>> Hi Alex, >>>> >>>>>> Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not. >>>>> >>>>> I was wondering whether it would make sense to do this for all the metrics. Apparently yes, I then continued. All shape parameters should be cached. >>>>>> Alex, could you take a look at that? >>>>> >>>>> Done. Mondrian-Alexandre_Bergel.470 >>>> >>>> Great. I checked a bit the implementation, and I would only suggest to check for isCached in the attributeAt:ifAbsent: method, instead of in every *For: methods. >>>> >>>>>> The next question is that if the border color is called all the time, what is the use of the bitmap cache? >>>>> >>>>> The bitmap is for not having to display inner nodes. Recursion takes times. >>>> >>>> I know, but if you compute it once why do you still need to re-render? >>>> >>>> Cheers, >>>> Doru >>>> >>>> >>>> >>>>>>> ====== >>>>>>> |view o | >>>>>>> view := MOViewRenderer new. >>>>>>> o := OrderedCollection new: 100. >>>>>>> 1 to: 100 do:[:i | o add: i]. >>>>>>> (view shape: (MORectangleShape new >>>>>>> width: [:e | 200]; >>>>>>> height: 200; >>>>>>> withBorder; >>>>>>> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). >>>>>>> view nodes: o. >>>>>>> view layout: (MOGridLayout new gapSize: 1). >>>>>>> view open >>>>>>> ====== >>>>> >>>>> A better version could be >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> |view o a | >>>>> a := {0}. >>>>> view := MOViewRenderer new. >>>>> o := OrderedCollection new: 100. >>>>> 1 to: 100 do:[:i | o add: i]. >>>>> (view shape: (MORectangleShape new >>>>> width: [:e | 200]; >>>>> height: 200; >>>>> withBorder; >>>>> borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). >>>>> view nodes: o. >>>>> view layout: (MOGridLayout new gapSize: 1). >>>>> view open. >>>>> a >>>>> -=-=-=-=-=-=-=-=-=-=-=-= >>>>> >>>>> Just inspect the expression, and see if the array a changes over the time. >>>>> >>>>> Is there any remaining problem left in Mondrian related to the speed issue? >>>>> >>>>> Cheers, >>>>> Alexandre >>>>> >>>>> >>>>> _______________________________________________ >>>>> Moose-dev mailing list >>>>> Moose-dev(a)iam.unibe.ch >>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >>>> >>>> -- >>>> www.tudorgirba.com >>>> >>>> "Some battles are better lost than fought." >>>> >>>> >>>> >>> >>> -- >>> www.tudorgirba.com >>> >>> "Some battles are better lost than fought." >>> >>> >>> >>> _______________________________________________ >>> Moose-dev mailing list >>> Moose-dev(a)iam.unibe.ch >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> --- >> Jannik Laval >> >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev --- Jannik Laval _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Hi All, I do a "profile all UI" and a scroll in a eDSM. The eDSM has been built on MooseModel of Moose itself and made with the 77 model packages. I hope the result can help. Results follows: ============ -------------------------------- Process: (40s) 211550208: nil -------------------------------- 58.7% {12320ms} WorldState>>doOneCycleFor: 56.8% {11921ms} WorldState>>doOneCycleNowFor: |54.9% {11522ms} WorldState>>displayWorldSafely: | |54.9% {11522ms} PasteUpMorph>>displayWorld | | 54.9% {11522ms} PasteUpMorph>>privateOuterDisplayWorld | | 54.9% {11522ms} WorldState>>displayWorld:submorphs: | | 54.9% {11522ms} WorldState>>drawWorld:submorphs:invalidAreasOn: | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: | | 54.9% {11522ms} StandardWindow(Morph)>>fullDrawOn: | | 54.9% {11522ms} StandardWindow(Morph)>>drawSubmorphsOn: | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: | | 54.9% {11522ms} ScrollPane(Morph)>>fullDrawOn: | | 54.9% {11522ms} ScrollPane(Morph)>>drawSubmorphsOn: | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: | | 54.9% {11522ms} TransformMorph(Morph)>>fullDrawOn: | | 54.8% {11501ms} TransformMorph>>drawSubmorphsOn: | | 54.8% {11501ms} FormCanvas(Canvas)>>fullDrawMorph: | | 54.8% {11501ms} FormCanvas(Canvas)>>fullDraw: | | 54.8% {11501ms} MOCanvas(Morph)>>fullDrawOn: | | 54.8% {11501ms} FormCanvas(Canvas)>>drawMorph: | | 54.8% {11501ms} FormCanvas(Canvas)>>draw: | | 54.8% {11501ms} MOCanvas>>drawOn: | | 54.8% {11501ms} MORoot(MONode)>>displayOn: | | 30.9% {6485ms} MONode>>displayOn: | | |18.1% {3799ms} MOEdge>>displayOn: | | | |17.1% {3589ms} MOStraightLineShape>>display:on: | | | | 5.8% {1217ms} FormCanvas>>line:to:width:color: | | | | |2.9% {609ms} FormCanvas>>setFillColor: | | | | | |1.4% {294ms} GrafPort>>fillPattern: | | | | | | 1.2% {252ms} GrafPort(BitBlt)>>fillColor: | | | | |1.1% {231ms} GrafPort(BitBlt)>>drawFrom:to: | | | | 3.3% {693ms} MOStraightLineShape(MOLineShape)>>colorFor: | | | | |3.1% {651ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: | | | | | 2.7% {567ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: | | | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: | | | | | 1.9% {399ms} IdentityDictionary(Dictionary)>>at:ifAbsent: | | | | | 1.2% {252ms} IdentityDictionary(HashedCollection)>>findElementOrNil: | | | | 2.5% {525ms} MOStraightLineShape(MOLineShape)>>widthFor: | | | | |2.3% {483ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: | | | | | 1.7% {357ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: | | | | | 1.5% {315ms} IdentityDictionary(Dictionary)>>at:ifAbsent: | | | | | 1.1% {231ms} IdentityDictionary(HashedCollection)>>findElementOrNil: | | | | 2.3% {483ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: | | | | |1.9% {399ms} MONode(MOGraphElement)>>isNotSelected | | | | | 1.3% {273ms} MONode(MOGraphElement)>>isSelected | | | | 1.1% {231ms} Point>>abs | | |12.2% {2561ms} MONode>>displayOn: | | | 8.4% {1763ms} MOEdge>>displayOn: | | | |8.0% {1679ms} MOStraightLineShape>>display:on: | | | | 2.6% {546ms} FormCanvas>>line:to:width:color: | | | | |1.3% {273ms} FormCanvas>>setFillColor: | | | | 1.5% {315ms} MOStraightLineShape(MOLineShape)>>colorFor: | | | | |1.4% {294ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: | | | | | 1.3% {273ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: | | | | 1.3% {273ms} MOStraightLineShape(MOLineShape)>>widthFor: | | | | |1.2% {252ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: | | | | 1.1% {231ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: | | | 2.9% {609ms} MONode>>displayOn: | | | 2.1% {441ms} MOEdge>>displayOn: | | | 2.0% {420ms} MOStraightLineShape>>display:on: | | 23.4% {4911ms} MOEdge>>displayOn: | | 22.0% {4617ms} MOStraightLineShape>>display:on: | | 7.5% {1574ms} FormCanvas>>line:to:width:color: | | |3.5% {735ms} FormCanvas>>setFillColor: | | | |1.7% {357ms} GrafPort>>fillPattern: | | | | 1.5% {315ms} GrafPort(BitBlt)>>fillColor: | | | | 1.2% {252ms} DisplayScreen(Form)>>bitPatternFor: | | |1.4% {294ms} GrafPort(BitBlt)>>drawFrom:to: | | 3.9% {819ms} MOStraightLineShape(MOLineShape)>>colorFor: | | |3.7% {777ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: | | | 3.2% {672ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: | | | 2.4% {504ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsent: | | | 1.3% {273ms} IdentityDictionary(HashedCollection)>>findElementOrNil: | | 3.5% {735ms} MOStraightLineShape(MOLineShape)>>widthFor: | | |3.1% {651ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: | | | 2.3% {483ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsent: | | | 1.5% {315ms} IdentityDictionary(HashedCollection)>>findElementOrNil: | | | 1.0% {210ms} IdentityDictionary>>scanFor: | | 3.1% {651ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: | | |2.6% {546ms} MONode(MOGraphElement)>>isNotSelected | | | 1.7% {357ms} MONode(MOGraphElement)>>isSelected | | 1.4% {294ms} Point>>abs ============== Cheers, Jannik _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Hi Jannik, From this trace, it looks like the time is spent on rendering. I understand it is still slow, but did you notice any improvement since the caching? When I tried eDSM, it looked significantly faster. I mean before I could not scroll at all, now I can even if only slowly. Could you confirm this?

Cheers, Doru On 19 Jun 2010, at 14:25, Laval Jannik wrote: > Hi All, > > I do a "profile all UI" and a scroll in a eDSM. > The eDSM has been built on MooseModel of Moose itself and made with the 77 model packages. > > I hope the result can help. > Results follows: > > ============ > -------------------------------- > Process: (40s) 211550208: nil > -------------------------------- > 58.7% {12320ms} WorldState>>doOneCycleFor: > 56.8% {11921ms} WorldState>>doOneCycleNowFor: > |54.9% {11522ms} WorldState>>displayWorldSafely: > | |54.9% {11522ms} PasteUpMorph>>displayWorld > | | 54.9% {11522ms} PasteUpMorph>>privateOuterDisplayWorld > | | 54.9% {11522ms} WorldState>>displayWorld:submorphs: > | | 54.9% {11522ms} WorldState>>drawWorld:submorphs:invalidAreasOn: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: > | | 54.9% {11522ms} StandardWindow(Morph)>>fullDrawOn: > | | 54.9% {11522ms} StandardWindow(Morph)>>drawSubmorphsOn: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: > | | 54.9% {11522ms} ScrollPane(Morph)>>fullDrawOn: > | | 54.9% {11522ms} ScrollPane(Morph)>>drawSubmorphsOn: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: > | | 54.9% {11522ms} TransformMorph(Morph)>>fullDrawOn: > | | 54.8% {11501ms} TransformMorph>>drawSubmorphsOn: > | | 54.8% {11501ms} FormCanvas(Canvas)>>fullDrawMorph: > | | 54.8% {11501ms} FormCanvas(Canvas)>>fullDraw: > | | 54.8% {11501ms} MOCanvas(Morph)>>fullDrawOn: > | | 54.8% {11501ms} FormCanvas(Canvas)>>drawMorph: > | | 54.8% {11501ms} FormCanvas(Canvas)>>draw: > | | 54.8% {11501ms} MOCanvas>>drawOn: > | | 54.8% {11501ms} MORoot(MONode)>>displayOn: > | | 30.9% {6485ms} MONode>>displayOn: > | | |18.1% {3799ms} MOEdge>>displayOn: > | | | |17.1% {3589ms} MOStraightLineShape>>display:on: > | | | | 5.8% {1217ms} FormCanvas>>line:to:width:color: > | | | | |2.9% {609ms} FormCanvas>>setFillColor: > | | | | | |1.4% {294ms} GrafPort>>fillPattern: > | | | | | | 1.2% {252ms} GrafPort(BitBlt)>>fillColor: > | | | | |1.1% {231ms} GrafPort(BitBlt)>>drawFrom:to: > | | | | 3.3% {693ms} MOStraightLineShape(MOLineShape)>>colorFor: > | | | | |3.1% {651ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: > | | | | | 2.7% {567ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: > | | | | | 1.9% {399ms} IdentityDictionary(Dictionary)>>at:ifAbsent: > | | | | | 1.2% {252ms} IdentityDictionary(HashedCollection)>>findElementOrNil: > | | | | 2.5% {525ms} MOStraightLineShape(MOLineShape)>>widthFor: > | | | | |2.3% {483ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | | | 1.7% {357ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: > | | | | | 1.5% {315ms} IdentityDictionary(Dictionary)>>at:ifAbsent: > | | | | | 1.1% {231ms} IdentityDictionary(HashedCollection)>>findElementOrNil: > | | | | 2.3% {483ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: > | | | | |1.9% {399ms} MONode(MOGraphElement)>>isNotSelected > | | | | | 1.3% {273ms} MONode(MOGraphElement)>>isSelected > | | | | 1.1% {231ms} Point>>abs > | | |12.2% {2561ms} MONode>>displayOn: > | | | 8.4% {1763ms} MOEdge>>displayOn: > | | | |8.0% {1679ms} MOStraightLineShape>>display:on: > | | | | 2.6% {546ms} FormCanvas>>line:to:width:color: > | | | | |1.3% {273ms} FormCanvas>>setFillColor: > | | | | 1.5% {315ms} MOStraightLineShape(MOLineShape)>>colorFor: > | | | | |1.4% {294ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: > | | | | | 1.3% {273ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | | 1.3% {273ms} MOStraightLineShape(MOLineShape)>>widthFor: > | | | | |1.2% {252ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | | 1.1% {231ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: > | | | 2.9% {609ms} MONode>>displayOn: > | | | 2.1% {441ms} MOEdge>>displayOn: > | | | 2.0% {420ms} MOStraightLineShape>>display:on: > | | 23.4% {4911ms} MOEdge>>displayOn: > | | 22.0% {4617ms} MOStraightLineShape>>display:on: > | | 7.5% {1574ms} FormCanvas>>line:to:width:color: > | | |3.5% {735ms} FormCanvas>>setFillColor: > | | | |1.7% {357ms} GrafPort>>fillPattern: > | | | | 1.5% {315ms} GrafPort(BitBlt)>>fillColor: > | | | | 1.2% {252ms} DisplayScreen(Form)>>bitPatternFor: > | | |1.4% {294ms} GrafPort(BitBlt)>>drawFrom:to: > | | 3.9% {819ms} MOStraightLineShape(MOLineShape)>>colorFor: > | | |3.7% {777ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: > | | | 3.2% {672ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | 2.4% {504ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: > | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsent: > | | | 1.3% {273ms} IdentityDictionary(HashedCollection)>>findElementOrNil: > | | 3.5% {735ms} MOStraightLineShape(MOLineShape)>>widthFor: > | | |3.1% {651ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | 2.3% {483ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: > | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsent: > | | | 1.5% {315ms} IdentityDictionary(HashedCollection)>>findElementOrNil: > | | | 1.0% {210ms} IdentityDictionary>>scanFor: > | | 3.1% {651ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: > | | |2.6% {546ms} MONode(MOGraphElement)>>isNotSelected > | | | 1.7% {357ms} MONode(MOGraphElement)>>isSelected > | | 1.4% {294ms} Point>>abs > ============== > > Cheers, > Jannik > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "What we can governs what we wish." _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Hi Jannik, From this trace, it looks like the time is spent on rendering. I understand it is still slow, but did you notice any improvement since the caching? When I tried eDSM, it looked significantly faster. I mean before I could not scroll at all, now I can even if only slowly. Could you confirm this?

Cheers, Doru On 19 Jun 2010, at 14:25, Laval Jannik wrote: > Hi All, > > I do a "profile all UI" and a scroll in a eDSM. > The eDSM has been built on MooseModel of Moose itself and made with the 77 model packages. > > I hope the result can help. > Results follows: > > ============ > -------------------------------- > Process: (40s) 211550208: nil > -------------------------------- > 58.7% {12320ms} WorldState>>doOneCycleFor: > 56.8% {11921ms} WorldState>>doOneCycleNowFor: > |54.9% {11522ms} WorldState>>displayWorldSafely: > | |54.9% {11522ms} PasteUpMorph>>displayWorld > | | 54.9% {11522ms} PasteUpMorph>>privateOuterDisplayWorld > | | 54.9% {11522ms} WorldState>>displayWorld:submorphs: > | | 54.9% {11522ms} WorldState>>drawWorld:submorphs:invalidAreasOn: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: > | | 54.9% {11522ms} StandardWindow(Morph)>>fullDrawOn: > | | 54.9% {11522ms} StandardWindow(Morph)>>drawSubmorphsOn: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: > | | 54.9% {11522ms} ScrollPane(Morph)>>fullDrawOn: > | | 54.9% {11522ms} ScrollPane(Morph)>>drawSubmorphsOn: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDrawMorph: > | | 54.9% {11522ms} FormCanvas(Canvas)>>fullDraw: > | | 54.9% {11522ms} TransformMorph(Morph)>>fullDrawOn: > | | 54.8% {11501ms} TransformMorph>>drawSubmorphsOn: > | | 54.8% {11501ms} FormCanvas(Canvas)>>fullDrawMorph: > | | 54.8% {11501ms} FormCanvas(Canvas)>>fullDraw: > | | 54.8% {11501ms} MOCanvas(Morph)>>fullDrawOn: > | | 54.8% {11501ms} FormCanvas(Canvas)>>drawMorph: > | | 54.8% {11501ms} FormCanvas(Canvas)>>draw: > | | 54.8% {11501ms} MOCanvas>>drawOn: > | | 54.8% {11501ms} MORoot(MONode)>>displayOn: > | | 30.9% {6485ms} MONode>>displayOn: > | | |18.1% {3799ms} MOEdge>>displayOn: > | | | |17.1% {3589ms} MOStraightLineShape>>display:on: > | | | | 5.8% {1217ms} FormCanvas>>line:to:width:color: > | | | | |2.9% {609ms} FormCanvas>>setFillColor: > | | | | | |1.4% {294ms} GrafPort>>fillPattern: > | | | | | | 1.2% {252ms} GrafPort(BitBlt)>>fillColor: > | | | | |1.1% {231ms} GrafPort(BitBlt)>>drawFrom:to: > | | | | 3.3% {693ms} MOStraightLineShape(MOLineShape)>>colorFor: > | | | | |3.1% {651ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: > | | | | | 2.7% {567ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: > | | | | | 1.9% {399ms} IdentityDictionary(Dictionary)>>at:ifAbsent: > | | | | | 1.2% {252ms} IdentityDictionary(HashedCollection)>>findElementOrNil: > | | | | 2.5% {525ms} MOStraightLineShape(MOLineShape)>>widthFor: > | | | | |2.3% {483ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | | | 1.7% {357ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: > | | | | | 1.5% {315ms} IdentityDictionary(Dictionary)>>at:ifAbsent: > | | | | | 1.1% {231ms} IdentityDictionary(HashedCollection)>>findElementOrNil: > | | | | 2.3% {483ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: > | | | | |1.9% {399ms} MONode(MOGraphElement)>>isNotSelected > | | | | | 1.3% {273ms} MONode(MOGraphElement)>>isSelected > | | | | 1.1% {231ms} Point>>abs > | | |12.2% {2561ms} MONode>>displayOn: > | | | 8.4% {1763ms} MOEdge>>displayOn: > | | | |8.0% {1679ms} MOStraightLineShape>>display:on: > | | | | 2.6% {546ms} FormCanvas>>line:to:width:color: > | | | | |1.3% {273ms} FormCanvas>>setFillColor: > | | | | 1.5% {315ms} MOStraightLineShape(MOLineShape)>>colorFor: > | | | | |1.4% {294ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: > | | | | | 1.3% {273ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | | 1.3% {273ms} MOStraightLineShape(MOLineShape)>>widthFor: > | | | | |1.2% {252ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | | 1.1% {231ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: > | | | 2.9% {609ms} MONode>>displayOn: > | | | 2.1% {441ms} MOEdge>>displayOn: > | | | 2.0% {420ms} MOStraightLineShape>>display:on: > | | 23.4% {4911ms} MOEdge>>displayOn: > | | 22.0% {4617ms} MOStraightLineShape>>display:on: > | | 7.5% {1574ms} FormCanvas>>line:to:width:color: > | | |3.5% {735ms} FormCanvas>>setFillColor: > | | | |1.7% {357ms} GrafPort>>fillPattern: > | | | | 1.5% {315ms} GrafPort(BitBlt)>>fillColor: > | | | | 1.2% {252ms} DisplayScreen(Form)>>bitPatternFor: > | | |1.4% {294ms} GrafPort(BitBlt)>>drawFrom:to: > | | 3.9% {819ms} MOStraightLineShape(MOLineShape)>>colorFor: > | | |3.7% {777ms} MOEdge(MOGraphElement)>>cachedNamed:ifAbsentInitializeWith: > | | | 3.2% {672ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | 2.4% {504ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: > | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsent: > | | | 1.3% {273ms} IdentityDictionary(HashedCollection)>>findElementOrNil: > | | 3.5% {735ms} MOStraightLineShape(MOLineShape)>>widthFor: > | | |3.1% {651ms} MOEdge(MOGraphElement)>>attributeAt:ifAbsent: > | | | 2.3% {483ms} IdentityDictionary(Dictionary)>>at:ifAbsentPut: > | | | 2.1% {441ms} IdentityDictionary(Dictionary)>>at:ifAbsent: > | | | 1.5% {315ms} IdentityDictionary(HashedCollection)>>findElementOrNil: > | | | 1.0% {210ms} IdentityDictionary>>scanFor: > | | 3.1% {651ms} MOStraightLineShape(MOLineShape)>>getAttachPointsFor: > | | |2.6% {546ms} MONode(MOGraphElement)>>isNotSelected > | | | 1.7% {357ms} MONode(MOGraphElement)>>isSelected > | | 1.4% {294ms} Point>>abs > ============== > > Cheers, > Jannik > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "What we can governs what we wish." _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not.

Alex, could you take a look at that?

The next question is that if the border color is called all the time, what is the use of the bitmap cache?

> ====== > |view o | > view := MOViewRenderer new. > o := OrderedCollection new: 100. > 1 to: 100 do:[:i | o add: i]. > (view shape: (MORectangleShape new > width: [:e | 200]; > height: 200; > withBorder; > borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). > view nodes: o. > view layout: (MOGridLayout new gapSize: 1). > view open > ======

Hi Alex, >> Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not. > > I was wondering whether it would make sense to do this for all the metrics. Apparently yes, I then continued. All shape parameters should be cached. >> Alex, could you take a look at that? > > Done. Mondrian-Alexandre_Bergel.470 Great. I checked a bit the implementation, and I would only suggest to check for isCached in the attributeAt:ifAbsent: method, instead of in every *For: methods. >> The next question is that if the border color is called all the time, what is the use of the bitmap cache? > > The bitmap is for not having to display inner nodes. Recursion takes times. I know, but if you compute it once why do you still need to re-render? Cheers, Doru >>> ====== >>> |view o | >>> view := MOViewRenderer new. >>> o := OrderedCollection new: 100. >>> 1 to: 100 do:[:i | o add: i]. >>> (view shape: (MORectangleShape new >>> width: [:e | 200]; >>> height: 200; >>> withBorder; >>> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). >>> view nodes: o. >>> view layout: (MOGridLayout new gapSize: 1). >>> view open >>> ====== > > A better version could be > -=-=-=-=-=-=-=-=-=-=-=-= > |view o a | > a := {0}. > view := MOViewRenderer new. > o := OrderedCollection new: 100. > 1 to: 100 do:[:i | o add: i]. > (view shape: (MORectangleShape new > width: [:e | 200]; > height: 200; > withBorder; > borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). > view nodes: o. > view layout: (MOGridLayout new gapSize: 1). > view open. > a > -=-=-=-=-=-=-=-=-=-=-=-= > > Just inspect the expression, and see if the array a changes over the time. > > Is there any remaining problem left in Mondrian related to the speed issue? > > Cheers, > Alexandre > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev -- www.tudorgirba.com "Some battles are better lost than fought."

Hi, Can't test? where is MOLabelShape, why was it deleted?? I use it and now is gone!!! I even had a specialization of it for Torch... Veronica On 17 Jun 2010, at 17:47, Tudor Girba wrote: > I tested on a regular DSM with 259 namespaces and I can now properly scroll once it gets displayed. > > Jannik, Veronica, could you check in your cases? > > Cheers, > Doru > > > > On 17 Jun 2010, at 16:30, Tudor Girba wrote: > >> Hi Alex, >> >>>> Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not. >>> >>> I was wondering whether it would make sense to do this for all the metrics. Apparently yes, I then continued. All shape parameters should be cached. >>>> Alex, could you take a look at that? >>> >>> Done. Mondrian-Alexandre_Bergel.470 >> >> Great. I checked a bit the implementation, and I would only suggest to check for isCached in the attributeAt:ifAbsent: method, instead of in every *For: methods. >> >>>> The next question is that if the border color is called all the time, what is the use of the bitmap cache? >>> >>> The bitmap is for not having to display inner nodes. Recursion takes times. >> >> I know, but if you compute it once why do you still need to re-render? >> >> Cheers, >> Doru >> >> >> >>>>> ====== >>>>> |view o | >>>>> view := MOViewRenderer new. >>>>> o := OrderedCollection new: 100. >>>>> 1 to: 100 do:[:i | o add: i]. >>>>> (view shape: (MORectangleShape new >>>>> width: [:e | 200]; >>>>> height: 200; >>>>> withBorder; >>>>> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). >>>>> view nodes: o. >>>>> view layout: (MOGridLayout new gapSize: 1). >>>>> view open >>>>> ====== >>> >>> A better version could be >>> -=-=-=-=-=-=-=-=-=-=-=-= >>> |view o a | >>> a := {0}. >>> view := MOViewRenderer new. >>> o := OrderedCollection new: 100. >>> 1 to: 100 do:[:i | o add: i]. >>> (view shape: (MORectangleShape new >>> width: [:e | 200]; >>> height: 200; >>> withBorder; >>> borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). >>> view nodes: o. >>> view layout: (MOGridLayout new gapSize: 1). >>> view open. >>> a >>> -=-=-=-=-=-=-=-=-=-=-=-= >>> >>> Just inspect the expression, and see if the array a changes over the time. >>> >>> Is there any remaining problem left in Mondrian related to the speed issue? >>> >>> Cheers, >>> Alexandre >>> >>> >>> _______________________________________________ >>> Moose-dev mailing list >>> Moose-dev(a)iam.unibe.ch >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> -- >> www.tudorgirba.com >> >> "Some battles are better lost than fought." >> >> >> > > -- > www.tudorgirba.com > > "Some battles are better lost than fought." > > > > _______________________________________________ > Moose-dev mailing list > Moose-dev(a)iam.unibe.ch > https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

I tested on a regular DSM with 259 namespaces and I can now properly scroll once it gets displayed. Jannik, Veronica, could you check in your cases? Cheers, Doru On 17 Jun 2010, at 16:30, Tudor Girba wrote: > Hi Alex, > >>> Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not. >> >> I was wondering whether it would make sense to do this for all the metrics. Apparently yes, I then continued. All shape parameters should be cached. >>> Alex, could you take a look at that? >> >> Done. Mondrian-Alexandre_Bergel.470 > > Great. I checked a bit the implementation, and I would only suggest to check for isCached in the attributeAt:ifAbsent: method, instead of in every *For: methods. > >>> The next question is that if the border color is called all the time, what is the use of the bitmap cache? >> >> The bitmap is for not having to display inner nodes. Recursion takes times. > > I know, but if you compute it once why do you still need to re-render? > > Cheers, > Doru > > > >>>> ====== >>>> |view o | >>>> view := MOViewRenderer new. >>>> o := OrderedCollection new: 100. >>>> 1 to: 100 do:[:i | o add: i]. >>>> (view shape: (MORectangleShape new >>>> width: [:e | 200]; >>>> height: 200; >>>> withBorder; >>>> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). >>>> view nodes: o. >>>> view layout: (MOGridLayout new gapSize: 1). >>>> view open >>>> ====== >> >> A better version could be >> -=-=-=-=-=-=-=-=-=-=-=-= >> |view o a | >> a := {0}. >> view := MOViewRenderer new. >> o := OrderedCollection new: 100. >> 1 to: 100 do:[:i | o add: i]. >> (view shape: (MORectangleShape new >> width: [:e | 200]; >> height: 200; >> withBorder; >> borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). >> view nodes: o. >> view layout: (MOGridLayout new gapSize: 1). >> view open. >> a >> -=-=-=-=-=-=-=-=-=-=-=-= >> >> Just inspect the expression, and see if the array a changes over the time. >> >> Is there any remaining problem left in Mondrian related to the speed issue? >> >> Cheers, >> Alexandre >> >> >> _______________________________________________ >> Moose-dev mailing list >> Moose-dev(a)iam.unibe.ch >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > -- > www.tudorgirba.com > > "Some battles are better lost than fought." > > > -- www.tudorgirba.com "Some battles are better lost than fought." _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

> Indeed, this caching should happen for all properties and for all shapes (both for nodes and for edges). I think that Alex stopped in the middle because he did not know whether this caching had an effect or not. I was wondering whether it would make sense to do this for all the metrics. Apparently yes, I then continued. All shape parameters should be cached. > Alex, could you take a look at that? Done. Mondrian-Alexandre_Bergel.470

> The next question is that if the border color is called all the time, what is the use of the bitmap cache? The bitmap is for not having to display inner nodes. Recursion takes times.

>> ====== >> |view o | >> view := MOViewRenderer new. >> o := OrderedCollection new: 100. >> 1 to: 100 do:[:i | o add: i]. >> (view shape: (MORectangleShape new >> width: [:e | 200]; >> height: 200; >> withBorder; >> borderColor: [:e | (Delay forMilliseconds: 50) wait. Color gray])). >> view nodes: o. >> view layout: (MOGridLayout new gapSize: 1). >> view open >> ====== A better version could be -=-=-=-=-=-=-=-=-=-=-=-= |view o a | a := {0}. view := MOViewRenderer new. o := OrderedCollection new: 100. 1 to: 100 do:[:i | o add: i]. (view shape: (MORectangleShape new width: [:e | 200]; height: 200; withBorder; borderColor: [:e | a at: 1 put: (a first + 1). Color gray])). view nodes: o. view layout: (MOGridLayout new gapSize: 1). view open. a -=-=-=-=-=-=-=-=-=-=-=-= Just inspect the expression, and see if the array a changes over the time. Is there any remaining problem left in Mondrian related to the speed issue? Cheers, Alexandre _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev