a DNU on SmallInteger>>#add: workaround

List overview All Threads
Download

newer

older

Blueprint migrated into Roassal

Jenkins build is back to stable :...

Esteban Lorenzano

24 Apr 2013 24 Apr '13

6:39 p.m.

Hi, Thanks to Usman, I found a problem in the VM with some kind of assignment structures. Of course it should work, but in the mean time, I commited a patch for 2.0 and 3.0 (in metacello, that was preventing some configurations to be loaded), but the same problem is present too in GLMMorphicTabulatorRenderer>>renderCustomColumn:ofPane:inUI:inBrowser: you might want to workaround it also. You just need to change: self renderCustomRow: each ofPane: aPane inUI: (pane := GLMMorphic containerMorph) inBrowser: aBrowser. for: pane := GLMMorphic containerMorph. self renderCustomRow: each ofPane: aPane inUI: pane inBrowser: aBrowser. yes, I know...this whould work, and *will* work, but in the mean time... cheers, Esteban

Show replies by date

Tudor Girba

24 Apr 24 Apr

9:27 p.m.

Hi Esteban, Thanks a lot. I committed the fix in Glamour. It is anyway a nicer practice to have the assignment separate. But, concerning Metacello: Is there anything we should do to benefit from the fixes? Cheers, Doru On Apr 24, 2013, at 6:39 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote:

...

-- www.tudorgirba.com "Every thing should have the right to be different."

Esteban Lorenzano

10:20 p.m.

the fix will be on latest 3.0 and backported to 2.0, I suppose tomorrow. you could take the slice and apply it by yourself too if you want.... is 10396, if my memory doesn't betray me :) Esteban On Apr 24, 2013, at 9:27 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote:

...

-- www.tudorgirba.com "Every thing should have the right to be different." _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Usman Bhatti

11:03 p.m.

tx a lot Esteban for fixing this. On Wed, Apr 24, 2013 at 10:20 PM, Esteban Lorenzano <estebanlm(a)gmail.com>wrote;wrote:

...

Hi Esteban, Thanks a lot. I committed the fix in Glamour. It is anyway a nicer

practice to have the assignment separate.

But, concerning Metacello: Is there anything we should do to benefit

from the fixes?

Cheers, Doru On Apr 24, 2013, at 6:39 PM, Esteban Lorenzano <estebanlm(a)gmail.com>

wrote:

> Hi, > > Thanks to Usman, I found a problem in the VM with some kind of

assignment structures. Of course it should work, but in the mean time, I commited a patch for 2.0 and 3.0 (in metacello, that was preventing some configurations to be loaded), but the same problem is present too in

> > GLMMorphicTabulatorRenderer>>renderCustomColumn:ofPane:inUI:inBrowser: > > you might want to workaround it also. You just need to change: > > self > renderCustomRow: each > ofPane: aPane > inUI: (pane := GLMMorphic

containerMorph)

inBrowser: aBrowser. for: pane := GLMMorphic containerMorph. self renderCustomRow: each ofPane: aPane inUI: pane inBrowser: aBrowser. yes, I know...this whould work, and *will* work, but in the mean time... cheers, Esteban _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Tudor Girba

11:08 p.m.

Indeed, thanks a lot. Regarding the integration, the issue is not pressing us, and once it is backported to 2.0, we should get it in the build given that we use the very latest version of Pharo (both image and vm). Cheers, Doru On Apr 24, 2013, at 11:03 PM, Usman Bhatti <usman.bhatti(a)gmail.com> wrote:

...

tx a lot Esteban for fixing this. On Wed, Apr 24, 2013 at 10:20 PM, Esteban Lorenzano <estebanlm(a)gmail.com> wrote: the fix will be on latest 3.0 and backported to 2.0, I suppose tomorrow. you could take the slice and apply it by yourself too if you want.... is 10396, if my memory doesn't betray me :) Esteban On Apr 24, 2013, at 9:27 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote:

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com "The coherence of a trip is given by the clearness of the goal."

4261

days inactive

4261

days old

moose-dev@list.inf.unibe.ch

Manage subscription

4 comments

3 participants

tags (0)

participants (3)

Esteban Lorenzano
Tudor Girba
Usman Bhatti