To enhance the look&feel in dark theme, I suggest to change renderAction like that:
renderAction: anAction ^(UITheme current newButtonIn: nil for: anAction getState: nil action: #morphicActOn: arguments: {} getEnabled: nil label: (AlphaImageMorph new image: anAction icon) help: (anAction title, Character tab asString, anAction shortcutAsString) trimBoth) valueOfProperty: #noBorder ifAbsentPut: [true]; "this is a hack to tell the GLMUITheme to not draw the border and the fill" valueOfProperty: #noFill ifAbsentPut: [true]; setProperty: #wantsKeyboardFocusNavigation toValue: false; "to disable the focus" borderWidth: 0; yourself
basically, just add #borderWidth: 0. It will remove the border (invisible in the regular theme), and then dark theme will behave the same… and it will look a lot better:
before:
after:
cheers, Esteban
ps: yes, we still need to play with the icons, but this small step is anyway needed :)
Seems ok :) Did you already commit the change or shell I do it?
Cheers, Andrei
On Fri, Oct 17, 2014 at 5:28 AM, Esteban Lorenzano estebanlm@gmail.com wrote:
To enhance the look&feel in dark theme, I suggest to change renderAction like that:
renderAction: anAction ^(UITheme current newButtonIn: nil for: anAction getState: nil action: #morphicActOn: arguments: {} getEnabled: nil label: (AlphaImageMorph new image: anAction icon) help: (anAction title, Character tab asString, anAction shortcutAsString) trimBoth) valueOfProperty: #noBorder ifAbsentPut: [true]; "this is a hack to tell the GLMUITheme to not draw the border and the fill" valueOfProperty: #noFill ifAbsentPut: [true]; setProperty: #wantsKeyboardFocusNavigation toValue: false; "to disable the focus" borderWidth: 0; yourself
basically, just add #borderWidth: 0. It will remove the border (invisible in the regular theme), and then dark theme will behave the same… and it will look a lot better:
before:
after:
cheers, Esteban
ps: yes, we still need to play with the icons, but this small step is anyway needed :)
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
committing now :)
On 18 Oct 2014, at 02:40, Andrei Chis chisvasileandrei@gmail.com wrote:
Seems ok :) Did you already commit the change or shell I do it?
Cheers, Andrei
On Fri, Oct 17, 2014 at 5:28 AM, Esteban Lorenzano <estebanlm@gmail.com mailto:estebanlm@gmail.com> wrote: To enhance the look&feel in dark theme, I suggest to change renderAction like that:
renderAction: anAction ^(UITheme current newButtonIn: nil for: anAction getState: nil action: #morphicActOn: arguments: {} getEnabled: nil label: (AlphaImageMorph new image: anAction icon) help: (anAction title, Character tab asString, anAction shortcutAsString) trimBoth) valueOfProperty: #noBorder ifAbsentPut: [true]; "this is a hack to tell the GLMUITheme to not draw the border and the fill" valueOfProperty: #noFill ifAbsentPut: [true]; setProperty: #wantsKeyboardFocusNavigation toValue: false; "to disable the focus" borderWidth: 0; yourself
basically, just add #borderWidth: 0. It will remove the border (invisible in the regular theme), and then dark theme will behave the same… and it will look a lot better:
before:
<before.png>
after:
<after.png>
cheers, Esteban
ps: yes, we still need to play with the icons, but this small step is anyway needed :)
Moose-dev mailing list Moose-dev@iam.unibe.ch mailto:Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-
Andrei Chis -
Esteban Lorenzano