Great.
Doru
On Mon, Nov 14, 2011 at 10:49 AM, Stéphane Ducasse <
stephane.ducasse(a)inria.fr> wrote:
ok
Now how do we proceed?
Just go ahead with your proposal of changing the names of the Task
hierarchy. Just
do not add the plugin mechanism in the importer.
Yes it should be above in the MooseTask
Stef
Doru
>>> because if you read my proposal it was concrete.
>>>
>>> Then introducing a compositeTask can be ok but it should not be a
superclass of MooseCompositeImporterTask
>>> because else the logic will be a
nightmare
>>>
>>> What I proposed is to get a MooseTask hierarchy nice and clean
>>> and a sub hierarchy only dealing with the extraction of Smalltalk
code
into
>>>
>>> SmalltalkExtractingTask
>>
>> This is great.
>>
>> But you also proposed to introduce the plugin mechanism in the
Importer
class, and I said that we should use a real CompositeTask for this
use case. That was all. There was no disagreement on having to refactor the
Smalltalk-related tasks. Just about where to add the new plugin mechanism.
>>
>> Cheers,
>> Doru
>>
>>
>>>> Hi,
>>>>
>>>> What I meant with my initial comment is that we have to rename the
current CompositeTask into something Smalltalk specific and add a real
generic CompositeTask.
>>>>
>>>> I was simply arguing that having another hook for operators is not
the way to go, because tasks should provide this composeability in the
first place.
>>>>
>>>> Doru
>>>>
>>>>
>>>> On 13 Nov 2011, at 22:03, Stéphane Ducasse wrote:
>>>>
>>>>>
>>>>>
>>>>> the only composite we have so far is that one and it is only for
Smalltalk.
>>>>> I *****KNOW****** that
MooseTask is not only for Smalltalk.
>>>>> Believe I read that code.
>>>>>
>>>>> I spent one afternoon on it.
>>>>> Now we can keep it like that too.
>>>>>
>>>>>
>>>>> On Nov 8, 2011, at 7:07 PM, Usman Bhatti wrote:
>>>>>
>>>>>> MooseImportingTask - Renamed SmalltalkImportingTask (add
importerClass logic)
>>>>>>
MooseCompositeImporterTask
>>>>>> MooseSqueakClassPackageImporterTask
->
MoosePharoClassPackageExtractTask
>>>>>>
MooseSqueakClasssCategoriesImporterTask -
MoosePharoClassCategoriesExtractTask
>>>>>> MooseImportClassesTask ->
MooseExtractClassesTask
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Moose-dev mailing list
>>>>>> Moose-dev(a)iam.unibe.ch
>>>>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>>
>>>>> --
>>>>>
www.tudorgirba.com
>>>>>
>>>>> Things happen when they happen,
>>>>> not when you talk about them happening.
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> Moose-dev(a)iam.unibe.ch
>>>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> Moose-dev(a)iam.unibe.ch
>>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>> --
>>>
www.tudorgirba.com
>>>
>>> "Live like you mean it."
>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> Moose-dev(a)iam.unibe.ch
>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> Moose-dev(a)iam.unibe.ch
>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
>
www.tudorgirba.com
>
> "What is more important: To be happy, or to make happy?"
>
>
> _______________________________________________
> Moose-dev mailing list
> Moose-dev(a)iam.unibe.ch
>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev