Hi,
I have just found, there are two failing tests in MooseModelTest which have not been discovered by Jenkins. I can reproduce it in the newest Jeninks' build moose-latest-dev-4.8 and also in older too. Do you have the same issue?
Methods are #testAsMSEString and #testExport.
Problem is in initialization in method:
=== FMRepositoryVisitor>>run nb := 0. UIManager default displayProgress: 'Writing ', printer stream localName at: Sensor cursorPoint from: 1 to: self roots size during: [ :bar | progBar := bar. self basicRun] ===
There is "from: 1" and "to: self roots size". "self roots size" returns 1. And then in method
Job>>progress ^ (currentValue - min) / (max - min)
counts "(max - min)" as "(1 - 1)" = 0 and raises ZeroDivide.
Easy fix is to set "from: 0". I would do it, but I hesitate because Jenkins does not introduce this error.
Any idea?
Cheers, Jura
Good spotting.
The reason why this does not appear on Jenkins is that on Jenkins we are running in headless mode, and thus, we do not have a progress bar.
Please commit your fix.
Cheers, Doru
On Apr 3, 2013, at 3:31 PM, Juraj Kubelka Juraj.Kubelka@gmail.com wrote:
Hi,
I have just found, there are two failing tests in MooseModelTest which have not been discovered by Jenkins. I can reproduce it in the newest Jeninks' build moose-latest-dev-4.8 and also in older too. Do you have the same issue?
Methods are #testAsMSEString and #testExport.
Problem is in initialization in method:
=== FMRepositoryVisitor>>run nb := 0. UIManager default displayProgress: 'Writing ', printer stream localName at: Sensor cursorPoint from: 1 to: self roots size during: [ :bar | progBar := bar. self basicRun] ===
There is "from: 1" and "to: self roots size". "self roots size" returns 1. And then in method
Job>>progress ^ (currentValue - min) / (max - min)
counts "(max - min)" as "(1 - 1)" = 0 and raises ZeroDivide.
Easy fix is to set "from: 0". I would do it, but I hesitate because Jenkins does not introduce this error.
Any idea?
Cheers, Jura _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"No matter how many recipes we know, we still value a chef."
Thanks for explanation. I have just committed it (Fame-ImportExport-JurajKubelka.14).
Cheers, Jura
2013/4/3 Tudor Girba tudor@tudorgirba.com
Good spotting.
The reason why this does not appear on Jenkins is that on Jenkins we are running in headless mode, and thus, we do not have a progress bar.
Please commit your fix.
Cheers, Doru
On Apr 3, 2013, at 3:31 PM, Juraj Kubelka Juraj.Kubelka@gmail.com wrote:
Hi,
I have just found, there are two failing tests in MooseModelTest which
have not been discovered by Jenkins. I can reproduce it in the newest Jeninks' build moose-latest-dev-4.8 and also in older too. Do you have the same issue?
Methods are #testAsMSEString and #testExport.
Problem is in initialization in method:
=== FMRepositoryVisitor>>run nb := 0. UIManager default displayProgress: 'Writing ', printer stream localName at: Sensor cursorPoint from: 1 to: self roots size during: [ :bar | progBar := bar. self basicRun] ===
There is "from: 1" and "to: self roots size". "self roots size" returns
- And then in method
Job>>progress ^ (currentValue - min) / (max - min)
counts "(max - min)" as "(1 - 1)" = 0 and raises ZeroDivide.
Easy fix is to set "from: 0". I would do it, but I hesitate because
Jenkins does not introduce this error.
Any idea?
Cheers, Jura _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"No matter how many recipes we know, we still value a chef."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-
Juraj Kubelka -
Tudor Girba