Hi!
One of the test is yellow because of the mismatching there is of mooseName
DudeDuplication>>mooseName ((signature isNil or: [ referenceCode isNil ]) or: [ duplicateCode isNil ]) ifTrue: [ ^ 'Error' ].
^ 'Chain: ', signature, ' between: ', referenceCode mooseName, ' and ', duplicateCode mooseName
It is wrong to override mooseName. mooseNameOn: should be overridden instead.
Shall I update mooseName into mooseNameOn:?
Cheers, Alexandre
Hi Alex,
You are looking at an old code. I already removed DudeDuplication>>mooseName.
But, there are still a couple of mooseNames around. We should move all of them into mooseNameOn:
Cheers, Doru
On 22 Mar 2011, at 22:17, Alexandre Bergel wrote:
Hi!
One of the test is yellow because of the mismatching there is of mooseName
DudeDuplication>>mooseName ((signature isNil or: [ referenceCode isNil ]) or: [ duplicateCode isNil ]) ifTrue: [ ^ 'Error' ].
^ 'Chain: ', signature, ' between: ', referenceCode mooseName, ' and ', duplicateCode mooseName
It is wrong to override mooseName. mooseNameOn: should be overridden instead.
Shall I update mooseName into mooseNameOn:?
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
You are looking at an old code. I already removed DudeDuplication>>mooseName.
Oups sorry!
But, there are still a couple of mooseNames around. We should move all of them into mooseNameOn:
I fixed all I could find.
What about removing all implementors of mooseUniqueName ? They are deprecated since March 2009.
I fixed FAMIXParameterizedType>>mooseNameOn: but I am not particularly happy. I had to check if parameterizableClass is a string or not. This stems from the method -=-=-=-=-=-=-=-=-=-=-=-=-=-=-= FAMIXParameterizedType>>parameterizableClass <MSEProperty: #parameterizableClass type: #FAMIXParameterizableClass> <MSEComment: 'Base type of this parameterized type.'> ^self privateState attributeAt: #parameterizableClass ifAbsent: [''] -=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Should it really be '' in case of absent? Why not nil?
Cheers, Alexandre
On 22 Mar 2011, at 22:17, Alexandre Bergel wrote:
Hi!
One of the test is yellow because of the mismatching there is of mooseName
DudeDuplication>>mooseName ((signature isNil or: [ referenceCode isNil ]) or: [ duplicateCode isNil ]) ifTrue: [ ^ 'Error' ].
^ 'Chain: ', signature, ' between: ', referenceCode mooseName, ' and ', duplicateCode mooseName
It is wrong to override mooseName. mooseNameOn: should be overridden instead.
Shall I update mooseName into mooseNameOn:?
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Hi,
On 23 Mar 2011, at 01:58, Alexandre Bergel wrote:
You are looking at an old code. I already removed DudeDuplication>>mooseName.
Oups sorry!
But, there are still a couple of mooseNames around. We should move all of them into mooseNameOn:
I fixed all I could find.
What about removing all implementors of mooseUniqueName ?
Yes.
They are deprecated since March 2009.
I fixed FAMIXParameterizedType>>mooseNameOn: but I am not particularly happy. I had to check if parameterizableClass is a string or not. This stems from the method
FAMIXParameterizedType>>parameterizableClass <MSEProperty: #parameterizableClass type: #FAMIXParameterizableClass> <MSEComment: 'Base type of this parameterized type.'>
^self privateState attributeAt: #parameterizableClass ifAbsent: ['']
Should it really be '' in case of absent? Why not nil?
Yes. This was a mistake.
Cheers, Doru
Cheers, Alexandre
On 22 Mar 2011, at 22:17, Alexandre Bergel wrote:
Hi!
One of the test is yellow because of the mismatching there is of mooseName
DudeDuplication>>mooseName ((signature isNil or: [ referenceCode isNil ]) or: [ duplicateCode isNil ]) ifTrue: [ ^ 'Error' ].
^ 'Chain: ', signature, ' between: ', referenceCode mooseName, ' and ', duplicateCode mooseName
It is wrong to override mooseName. mooseNameOn: should be overridden instead.
Shall I update mooseName into mooseNameOn:?
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"It's not how it is, it is how we see it."
I fixed FAMIXParameterizedType>>parameterizableClass.
All tests are now green.
Great job, Alex and Vanessa!
Cheers, Doru
On 23 Mar 2011, at 08:19, Tudor Girba wrote:
Hi,
On 23 Mar 2011, at 01:58, Alexandre Bergel wrote:
You are looking at an old code. I already removed DudeDuplication>>mooseName.
Oups sorry!
But, there are still a couple of mooseNames around. We should move all of them into mooseNameOn:
I fixed all I could find.
What about removing all implementors of mooseUniqueName ?
Yes.
They are deprecated since March 2009.
I fixed FAMIXParameterizedType>>mooseNameOn: but I am not particularly happy. I had to check if parameterizableClass is a string or not. This stems from the method
FAMIXParameterizedType>>parameterizableClass <MSEProperty: #parameterizableClass type: #FAMIXParameterizableClass> <MSEComment: 'Base type of this parameterized type.'>
^self privateState attributeAt: #parameterizableClass ifAbsent: ['']
Should it really be '' in case of absent? Why not nil?
Yes. This was a mistake.
Cheers, Doru
Cheers, Alexandre
On 22 Mar 2011, at 22:17, Alexandre Bergel wrote:
Hi!
One of the test is yellow because of the mismatching there is of mooseName
DudeDuplication>>mooseName ((signature isNil or: [ referenceCode isNil ]) or: [ duplicateCode isNil ]) ifTrue: [ ^ 'Error' ].
^ 'Chain: ', signature, ' between: ', referenceCode mooseName, ' and ', duplicateCode mooseName
It is wrong to override mooseName. mooseNameOn: should be overridden instead.
Shall I update mooseName into mooseNameOn:?
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"It's not how it is, it is how we see it."
-- www.tudorgirba.com
"We are all great at making mistakes."
What about removing all implementors of mooseUniqueName ?
Yes.
Done. Moose-Hismo-AlexandreBergel.40
Alexandre
They are deprecated since March 2009.
I fixed FAMIXParameterizedType>>mooseNameOn: but I am not particularly happy. I had to check if parameterizableClass is a string or not. This stems from the method
FAMIXParameterizedType>>parameterizableClass <MSEProperty: #parameterizableClass type: #FAMIXParameterizableClass> <MSEComment: 'Base type of this parameterized type.'>
^self privateState attributeAt: #parameterizableClass ifAbsent: ['']
Should it really be '' in case of absent? Why not nil?
Yes. This was a mistake.
Cheers, Doru
Cheers, Alexandre
On 22 Mar 2011, at 22:17, Alexandre Bergel wrote:
Hi!
One of the test is yellow because of the mismatching there is of mooseName
DudeDuplication>>mooseName ((signature isNil or: [ referenceCode isNil ]) or: [ duplicateCode isNil ]) ifTrue: [ ^ 'Error' ].
^ 'Chain: ', signature, ' between: ', referenceCode mooseName, ' and ', duplicateCode mooseName
It is wrong to override mooseName. mooseNameOn: should be overridden instead.
Shall I update mooseName into mooseNameOn:?
Cheers, Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Next time you see your life passing by, say 'hi' and get to know her."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"It's not how it is, it is how we see it."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-
Alexandre Bergel -
Tudor Girba