Jan wrote:
I do not understand,...is it supposed to be failure, or is it marked as failure so that we don't see the failures in a build?
It is not supposed to fail, but it has been doing for a long time.
As long as I know, at least the Henry45 fails because of a missing PPContext object and this is definitely not expected...
No. It fails, and it then returns a nil PPContext. That is an additional problem.
Stephan
Hi,
So I spent some time with this issue and:
1) PetitRegex was never really working. I traced a history and implementation and a few tests were always failing. The problem is basically caused by the fact, that Petit does not backtrack (regex does) 2) Considering the fact, that PetitRegex parse only regular languages and with an extension I implemented for the islands and some extra effort, I was able to fix these errors. 3) The performance is probably bad, but it works (according to the test suite :) 4) I updated PPManifestMfParser to pass the tests as well
So in short, all the Petit* tests should pass now.
Cheers, Jan
On 10 November 2014 16:53, Stephan Eggermont stephan@stack.nl wrote:
Jan wrote:
I do not understand,...is it supposed to be failure, or is it marked as
failure so that we don't see the failures in a build?
It is not supposed to fail, but it has been doing for a long time.
As long as I know, at least the Henry45 fails because of a missing
PPContext object and this is definitely not expected...
No. It fails, and it then returns a nil PPContext. That is an additional problem.
Stephan _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Thanks!
Doru
On Wed, Nov 12, 2014 at 12:19 PM, Jan Kurš kurs.jan@gmail.com wrote:
Hi,
So I spent some time with this issue and:
- PetitRegex was never really working. I traced a history and
implementation and a few tests were always failing. The problem is basically caused by the fact, that Petit does not backtrack (regex does) 2) Considering the fact, that PetitRegex parse only regular languages and with an extension I implemented for the islands and some extra effort, I was able to fix these errors. 3) The performance is probably bad, but it works (according to the test suite :) 4) I updated PPManifestMfParser to pass the tests as well
So in short, all the Petit* tests should pass now.
Cheers, Jan
On 10 November 2014 16:53, Stephan Eggermont stephan@stack.nl wrote:
Jan wrote:
I do not understand,...is it supposed to be failure, or is it marked as
failure so that we don't see the failures in a build?
It is not supposed to fail, but it has been doing for a long time.
As long as I know, at least the Henry45 fails because of a missing
PPContext object and this is definitely not expected...
No. It fails, and it then returns a nil PPContext. That is an additional problem.
Stephan _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-
Jan Kurš -
Stephan Eggermont -
Tudor Girba