Hi,
I worked a bit on the FileStructureImporter to work with Filesystem.
The metric calculations are still wrong (see the red test in FileStructureImporterTest).
In the process, I also refactored a bit FAMIXFile to make it work with Filesystem. Perhaps this will impact CAnalyzer, but given that it was not really working before, I guess not in a bad sense. Please let me know if it broke anything.
There is one conflict in FAMIXFile>>readStream. Currently, there is an override in CAnalyzer with a wrong implementation. I wanted to commit the removal of the method, but I do not have commit rights.
Cheers, Doru
-- www.tudorgirba.com
"Value is always contextual."
Hi again,
All tests are now green, including the metrics.
I noticed that some of the code seemed to assume that name contained the entire path. This is now not the case as a FAMIXFile only knows the local name and the parent FAMIXFolder.
Cheers, Doru
On 28 Nov 2009, at 02:27, Tudor Girba wrote:
Hi,
I worked a bit on the FileStructureImporter to work with Filesystem.
The metric calculations are still wrong (see the red test in FileStructureImporterTest).
In the process, I also refactored a bit FAMIXFile to make it work with Filesystem. Perhaps this will impact CAnalyzer, but given that it was not really working before, I guess not in a bad sense. Please let me know if it broke anything.
There is one conflict in FAMIXFile>>readStream. Currently, there is an override in CAnalyzer with a wrong implementation. I wanted to commit the removal of the method, but I do not have commit rights.
Cheers, Doru
-- www.tudorgirba.com
"Value is always contextual."
-- www.tudorgirba.com
"Every successful trip needs a suitable vehicle."
-
Tudor Girba