Hi,
I noticed that FAMIXEntity has a comments property that points to a collection of Strings. We should instead have a FAMIXComment entity that also has a sourceAnchor.
Cheers, Doru
-- www.tudorgirba.com
"If you interrupt the barber while he is cutting your hair, you will end up with a messy haircut."
A class FAMIXComment already exist. I moved it into Famix-Core. Here the comments of my last commit:
- Moved FAMIXComment from Famix-File into Famix-Core - Cleaned a bit FAMIXComment - Adding a comment on a FAMIXEntity uses FAMIXComment instead of storing strings - Removed a self halt in testInvocationReification
Alexandre
On 11 Apr 2009, at 13:52, Tudor Girba wrote:
Hi,
I noticed that FAMIXEntity has a comments property that points to a collection of Strings. We should instead have a FAMIXComment entity that also has a sourceAnchor.
Cheers, Doru
-- www.tudorgirba.com
"If you interrupt the barber while he is cutting your hair, you will end up with a messy haircut."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
I noticed that FAMIXEntity has a comments property that points to a collection of Strings. We should instead have a FAMIXComment entity that also has a sourceAnchor.
In my previous mail, I forgot to mention that FAMIXEntity already has a sourceAnchor variable, no need for the comment to have one therefore.
Speaking about source code, I guess that FAMIXSourceAnchor shoud be made abstract. Subclasses will particularize source location. As subclasses of FAMIXSourceAnchor, I see: - PharoAnchor: the code has to be accessible from the Pharo meta model (e.g., CompiledMethod>>getSource, ClassDescription>>definitionST80) - FileAnchor: a file stored on the hard disk. This class should have a beginIndex and endIndex to designate portion only
Easy to envision a SVNAnchor, SqueakSourceAnchor, ...
Everybody is fine with this proposal?
Cheers, Alexandre
Hi Alex,
I noticed that FAMIXEntity has a comments property that points to a collection of Strings. We should instead have a FAMIXComment entity that also has a sourceAnchor.
In my previous mail, I forgot to mention that FAMIXEntity already has a sourceAnchor variable, no need for the comment to have one therefore.
That is what I meant.
Speaking about source code, I guess that FAMIXSourceAnchor shoud be made abstract. Subclasses will particularize source location. As subclasses of FAMIXSourceAnchor, I see:
- PharoAnchor: the code has to be accessible from the Pharo meta
model (e.g., CompiledMethod>>getSource, ClassDescription>>definitionST80)
- FileAnchor: a file stored on the hard disk. This class should
have a beginIndex and endIndex to designate portion only
Easy to envision a SVNAnchor, SqueakSourceAnchor, ...
Everybody is fine with this proposal?
Definitely.
Cheers, Doru
-- www.tudorgirba.com
"Every thing should have the right to be different."
Simon and I added a SourceAnchor, however some work is still necessary. We will probably have something to show at Sattose.
Cheers, Alexandre
On 13 Apr 2009, at 11:50, Tudor Girba wrote:
Hi Alex,
I noticed that FAMIXEntity has a comments property that points to a collection of Strings. We should instead have a FAMIXComment entity that also has a sourceAnchor.
In my previous mail, I forgot to mention that FAMIXEntity already has a sourceAnchor variable, no need for the comment to have one therefore.
That is what I meant.
Speaking about source code, I guess that FAMIXSourceAnchor shoud be made abstract. Subclasses will particularize source location. As subclasses of FAMIXSourceAnchor, I see:
- PharoAnchor: the code has to be accessible from the Pharo meta
model (e.g., CompiledMethod>>getSource, ClassDescription>>definitionST80)
- FileAnchor: a file stored on the hard disk. This class should
have a beginIndex and endIndex to designate portion only
Easy to envision a SVNAnchor, SqueakSourceAnchor, ...
Everybody is fine with this proposal?
Definitely.
Cheers, Doru
-- www.tudorgirba.com
"Every thing should have the right to be different."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-
Alexandre Bergel -
Alexandre Bergel -
Tudor Girba