FamixInheritance>>name seems superflous because it overrides a superclass method with the same behavior.
We tried to remove the entity but then a (seemingly unrelated) test is failing in FamixModelExtractionTest>>testReferenceModel.
We didn't commit this change in the repository fearing that something might fail.
Good finding. I just removed it and the test does not fail. Most likely the failure was generated by something else.
I committed.
Doru
On Wed, Nov 23, 2011 at 6:44 PM, Usman Bhatti usman.bhatti@gmail.com wrote:
FamixInheritance>>name seems superflous because it overrides a superclass method with the same behavior. We tried to remove the entity but then a (seemingly unrelated) test is failing in FamixModelExtractionTest>>testReferenceModel. We didn't commit this change in the repository fearing that something might fail.
Moose-dev mailing list Moose-dev@iam.uinibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Also we deleted
FAMIXReference>>name
and we committed it in the code.
On Wed, Nov 23, 2011 at 7:58 PM, Tudor Girba tudor@tudorgirba.com wrote:
Good finding. I just removed it and the test does not fail. Most likely the failure was generated by something else.
I committed.
Doru
On Wed, Nov 23, 2011 at 6:44 PM, Usman Bhatti usman.bhatti@gmail.com wrote:
FamixInheritance>>name seems superflous because it overrides a superclass method with the same behavior. We tried to remove the entity but then a (seemingly unrelated) test is failing in FamixModelExtractionTest>>testReferenceModel. We didn't commit this change in the repository fearing that something
might
fail.
Moose-dev mailing list Moose-dev@iam.uinibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com "Every thing has its own flow"
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Thanks.
Doru
On 23 Nov 2011, at 22:50, Usman Bhatti wrote:
Also we deleted
FAMIXReference>>name
and we committed it in the code.
On Wed, Nov 23, 2011 at 7:58 PM, Tudor Girba tudor@tudorgirba.com wrote: Good finding. I just removed it and the test does not fail. Most likely the failure was generated by something else.
I committed.
Doru
On Wed, Nov 23, 2011 at 6:44 PM, Usman Bhatti usman.bhatti@gmail.com wrote:
FamixInheritance>>name seems superflous because it overrides a superclass method with the same behavior. We tried to remove the entity but then a (seemingly unrelated) test is failing in FamixModelExtractionTest>>testReferenceModel. We didn't commit this change in the repository fearing that something might fail.
Moose-dev mailing list Moose-dev@iam.uinibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com "Every thing has its own flow"
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"We cannot reach the flow of things unless we let go."
-
Tudor Girba -
Usman Bhatti