21 Apr
2013
21 Apr
'13
9:35 p.m.
Hi Nicolas,
The following test fails right now:
FAMIXExtensionMetricTest>>testBunchCouplingFAMIXPackage
The failure was introduced when I added MooseQueryResult>>= (see details below).
However, I do not understand why this newly added method would have an influence.
The funny thing is that only one assertion is problematic:
self assert: (p3m2 bunchCouplingWith: p1m2) = (4/54) asFloat.
All the other assertion are valid. I looked at the code but could not see anything (also
because the computation is rather complex). Could you check please?
Cheers,
Doru
On Apr 5, 2013, at 10:27 PM, Tudor Girba <tudor(a)tudorgirba.com> wrote:
Thanks Alex,
I could manage to isolate the issue. The problem was that MooseQueryResult did not have =
defined, and thus, it did not behave like a collection. I added one now, and those tests
are green.
However, now we have another failing test that was somehow induced by the newly added =
method.
FAMIXExtensionMetricTest>>testBunchCouplingFAMIXPackage
@Nicolas, could you take a look. There is only one assertion that fails and I just cannot
see how the newly added method makes the difference in the bunch computation (I checked:
if you remove the method, the bunch test is green again).
Cheers,
Doru
On Apr 5, 2013, at 9:40 PM, Alexandre Bergel <alexandre.bergel(a)me.com> wrote:
--
www.tudorgirba.com
"Reasonable is what we are accustomed with."
Hi!
I had a look at the failing tests.
--
www.tudorgirba.com
"Sometimes the best solution is not the best solution."
•
Moose.Tests.SmalltalkImporter.Core.FamixPropertiesTest.testHasTheSamePropertiesAs
I've tried:
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
| c model |
model := MooseModel new.
c := FAMIXClass new.
c name: 'C'.
model add: c.
c hasTheSamePropertiesAs: c. " => false " "Should be true I
guess"
c allDeclaredProperties detect: [ :each | (each getFrom: c) ~= (each getFrom: c) ]
ifNone: [ 'Everything is okay!' ]
"=> a FM3PropertyDescription[FAMIX.Type.Provider classes]"
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
This FAMIX.Type.Provider classes comes from the following methods:
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
FAMIXType>>providerClasses
"returns a set of all the classes that the receiver depends on (inherites, staticly
accesses, or uses some of their methods)"
<MSEProperty: 'Provider classes' type: #FAMIXType> <multivalued>
^ self queryAllOutgoingAssociations atClassScope withoutSelfLoops
FAMIXMethod>>providerClasses
"returns a set of all the classes that the receiver depends on (inherites, staticly
accesses, or uses some of their methods)"
<MSEProperty: 'Provider classes' type: #FAMIXType> <multivalued>
^ self queryAllOutgoingAssociations atClassScope withoutSelfLoops
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
I guess the annotation should instead be: <MSEProperty: #providerClasses type:
#FAMIXType> <multivalued>
However the tests are fill yellow (I did not forget to reset the meta description).
Doru, Can you see what is wrong? Does this help?
•
SmallDude.Tests.Core.DudeMooseSmalltalkTest.testMSEImportExport
If we make #testHasTheSamePropertiesAs, then #testMSEImportExport will also be greener.
The latter depends on the first.
Alexandre
On Apr 5, 2013, at 3:24 AM, admin(a)moosetechnology.org wrote:
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
See
<https://ci.inria.fr/moose/job/moose-latest-dev-4.8/209/>
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"If you interrupt the barber while he is cutting your hair,
you will end up with a messy haircut."
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev