Thx Anne,
I have looked at your fix, and realized that I did not ask the correct question at the MooseState. I now introduced the message: "hasMooseModel" instead of testing wether the model is nil. So it is no longer necessary to set the name after adding it to the model. Running the tests however proved that I did not do it properly, as some tests fail again.
I think you should revert this part of your fix, since the cache is updated when you set a name of an object after you add this to the model. And when I understand your code correctly you now set the name after adding it to the model each time a new Orion object is added. This might be slow. But this would mean, that the storage also needs some revising.
Cheers, Diego
On Sep 20, 2013, at 6:56 PM, Anne Etien wrote:
Hi,
I reverted your fix and corrected all the tests in Orion (without touching Moose). So normally everything is back to normal.
Anne Le 20 sept. 2013 à 16:58, Diego Lont a écrit :
Hi all,
Ok, fixing orion is beyond me. At least beyond me to fix today. I can see it uses a moose model to store entities in, but how the moose name is build is a bit hazy. I made some small fixes that allows most of the tests to run, but now there are some failing tests left, that I do not know what exactly causes them.
If someone more into Orion can take a look, I would appreciate that.
Cheers, Diego
On Sep 20, 2013, at 4:39 PM, Diego Lont wrote:
Hi all,
We are checking the build server for failed tests, checking what the problem is: I found problems in Glamour. It used a wrong symbol in its configuration, that caused CollectionExtensions not to load. It caused test fails in GToolkit.
I found problems with method categories. There are some tests, that are more or less roassal tests, or at least use roassal, so do not belong in Moose-Algos. I think some methods should be moved to *roassal-paintings … or maybe *roassal-moose-algos and the tests should move along with them. I cannot write in roassal, if someone gives me a good method category and write access to roassal, I will move these methods.
I found failed tests in Orion, but it looks like we caused them with our change in moose entity, so I will take a closer look and fix it, or write another mail.
Cheers, Stephan and Diego _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev