Hi Jannik,
This sounds indeed like a very good job!
Cheers, Doru
On 5 Nov 2009, at 21:50, Stéphane Ducasse wrote:
jannik this is cool.
may we could have a post action to check duplicates. You see why the profiler chapter is important :)
Stef On Nov 5, 2009, at 10:38 AM, Laval Jannik wrote:
Hi all,
I did a MessageTally on MooseScript>>createModelForPharoOnlyPackageInCycle. Result: 6613413 msec (110 minutes) and most of time (80%) passed in FAMIXInvocation>>candidates:. precisely in FMMultivalueLink>>unsafeAdd: because of SequenceableCollection>>includes:
The parameter of candidates: is an OrderedCollection but it should not contained duplicated entities. So I do a method uncheckUnsafeAdd: which do not check if the entity is included.
Tests which I made give the same number of entities that the older importer. But time is divided by 10: 654300 msec (11 minutes)
For MooseScript>>createModelForMoose Result before: 73 seconds Result after: 43 second
All tests pass, I think we should test it on other models.
Cheers,
Jannik Laval PhD Student - Rmod Team - INRIA Certified Project Management Associate (IPMA) http://www.jannik-laval.eu http://rmod.lille.inria.fr
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"Value is always contextual."