19 Mar
2013
19 Mar
'13
9:41 a.m.
+1
On Tue, Mar 19, 2013 at 7:07 AM, Tudor Girba <tudor(a)tudorgirba.com> wrote:
Excellent catch!
You see, Yuriy: never underestimate the power of sticking to a problem.
It is not mastery that solves the problem. It is solving the problem that
leads to mastery.
Keep it up.
Cheers,
Doru
On Mon, Mar 18, 2013 at 11:22 PM, Yuriy Tymchuk <yuriy.tymchuk(a)me.com>wrote;wrote:
Hoorah. Busted 8 failures in one swipe:
https://ci.inria.fr/moose/job/moose-latest-dev-4.8/86/testReport/
So now about details. After Fabrizio's example it wasn't hard to find out
that "1." is treated as a number literal and "1. variable" is treated
as a
message send to a literal. After a fast talk with Marcus it turned out that
Number class>>readFrom: started to use ExtendedNumberParser instead
of SqNumberParser. So to fix the problem I've changed "Number
readFrom: stream" to "(SqNumberParser on: stream) nextNumber" in a
number
parser of PPSmalltalkGrammar.
Cheers,
Uko
On 14 бер. 2013, at 21:58, Fabrizio Perin-3 [via moose-dev] <[hidden
email] <http://user/SendEmail.jtp?type=node&node=4026533&i=0>> wrote:
Hi I was checking at the code quickly and there is problem that is
related to unary expression parsing. Something like this:
whatever + 1.
variable := 2+2
will be recognized as: "whatever" "+" "1. variable"
so the second term is not just "1" but includes everything up to ":".
Did
something changed with unary expression evaluation?
I tried to play with it but I couldn't fix it.
I will investigate further tomorrow.
Cheers,
Fabrizio
2013/3/13 Yuriy Tymchuk <<a
href="x-msg://1553/user/SendEmail.jtp?type=node&node=4026485&i=0"
target="_top" rel="nofollow" link="external">[hidden
email]>
--
www.tudorgirba.com
"Every thing has its own flow"
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Super. Now the only failing tests are the ones
that I've mentioned at the
beginning. Maybe in Pharo 2.0 something changed with streams, but all the
failing test have the same problem: parser finishes parsing before the
end
of the string. Maybe Lukas can take a look at it, because I'm quite new
to
the PP implementation
--
View this message in context:
http://moose-dev.97923.n3.nabble.com/Failing-PetitSmalltalk-tests-tp4026442…
Sent from the moose-dev mailing list archive at Nabble.com.
_______________________________________________
Moose-dev mailing list
<a
href="x-msg://1553/user/SendEmail.jtp?type=node&node=4026485&i=1"
target="_top" rel="nofollow" link="external">[hidden
email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
<a
href="x-msg://1553/user/SendEmail.jtp?type=node&node=4026485&i=2"
target="_top" rel="nofollow" link="external">[hidden
email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
------------------------------
If you reply to this email, your message will be added to the
discussion below:
http://moose-dev.97923.n3.nabble.com/Failing-PetitSmalltalk-tests-tp4026442…
To unsubscribe from Failing PetitSmalltalk tests, click here.
NAML<http://moose-dev.97923.n3.nabble.com/template/NamlServlet.jtp?macro…
------------------------------
View this message in context: Re: Failing PetitSmalltalk
tests<http://moose-dev.97923.n3.nabble.com/Failing-PetitSmalltalk-tests-…
Sent from the moose-dev mailing list
archive<http://moose-dev.97923.n3.nabble.com/>at Nabble.com.
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev