Hi,
Sorry, as you said it was a mistake. I'm going to be more careful with the changes. Alexandre did a merge that fix the problems. Cheers, Santiago
2011/11/23 Tudor Girba tudor@tudorgirba.com
Hi Santiago,
I noticed that you committed a change to Famix-Core.
The comment says that the intention of the commit was to add WMC to package. This is Ok.
The problem is that in the process, you also:
- deleted FAMIXClass>>isInterface and FAMIXClass>>isInterface:
- introduced null checks in core methods (classScope, packageScope and
namespaceScope)
I am sure that the first one was a mistake. But, for the second one you should have raise it for discussion because it has to do with changing the semantics of those methods.
In general, changes to Core classes should be treated with more care (this is valid for me as well) :)
Cheers, Doru
-- www.tudorgirba.com "Every thing has its own flow" _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev