Ok, I got it now! I commited the fix. You will be a contributor to the PP-Islands as soon as SmalltalkHub will be so kind and stops ignoring my requests.
Jan
On 3 September 2014 11:51, Tudor Girba tudor@tudorgirba.com wrote:
That is what I said that was missing. Only this should be packaged for the moment in PP-Islands, and I do not have access to commit there :).
Doru
On Wed, Sep 3, 2014 at 11:40 AM, Jan Kurš kurs@iam.unibe.ch wrote:
Hey, just add a method to StartOfLineParser:
StartOfLineParser>>isNullable2 ^ true
On 3 September 2014 11:33, Tudor Girba tudor@tudorgirba.com wrote:
Hmm. I do not see how this can be the case. I get a SubclassResponsibility when I try to do this:
((#startOfLine asParser , $! asParser) island ==> #second) star parse: '! asdasdasd asdasd ! asdasdasd'
Doru
On Wed, Sep 3, 2014 at 11:28 AM, Jan Kurš kurs@iam.unibe.ch wrote:
Hey, you mean StartOfLIneParser used with islands? I don't see any problem in the version committed into the trunk, or do I miss something?
In case you are talking about the PP-Islands, the isNullable2 should return true for that parser.
- isNullable2 (as the name indicates) is one of the dark corners of the
islands that needs to be cleaned.
- you can set the default value to false so far... but I will have to
review all this nullable concept before pushing to the trunk.
Cheers, Jan
On 3 September 2014 11:13, Tudor Girba tudor@tudorgirba.com wrote:
Hi Jan,
I just spotted a little bug in the StartOfLineParser. It misses isNullable2. I wanted to commit, but I do not have access to your repo.
But, now that I stumbled across this, I have a question:
- why is it called isNullable2?
- why not have a default implementation for PPParser returning false?
Cheers, Doru
On Wed, Sep 3, 2014 at 9:14 AM, Jan Kurš kurs@iam.unibe.ch wrote:
Hey, it will be done. It is in my todo,...
And it seems we have a student (bachelor) who is interested in trying ruby importer to moose using islands. We will see, how far can one get with the islands and PEGs.
Cheers, Jan
On 3 September 2014 08:54, Tudor Girba tudor@tudorgirba.com wrote:
> Hi Jan, > > Would it be possible to clean PP-Islands so that it can be loaded > together with the rest of PetitParser? I would like to integrate it in the > main distribution because it is too cool :) > > Doru > > -- > www.tudorgirba.com > > "Every thing has its own flow" >
-- www.tudorgirba.com
"Every thing has its own flow"
-- www.tudorgirba.com
"Every thing has its own flow"
-- www.tudorgirba.com
"Every thing has its own flow"