Never mind. I read the wrong thing :)
Doru
On Apr 25, 2017, at 11:58 AM, Alexandre Bergel alexandre.bergel@me.com wrote:
Which question? Pavel did not ask a question :-)
Alexandre
On Apr 25, 2017, at 11:16 AM, Tudor Girba tudor@tudorgirba.com wrote:
I do not understand the question.
Doru
On Apr 25, 2017, at 10:41 AM, Pavel Krivanek pavel.krivanek@gmail.com wrote:
2017-04-24 17:53 GMT+02:00 Tudor Girba tudor@tudorgirba.com: I took a look at the code.
I think the transformColor: is exactly the relevant direction. But, I think there are still two issues to be addressed:
The logic does not yet work for everything. For example, lightRed is can be distinguished on white, but is barely so in the dark theme.
The more problematic issue is the mismatch between the script and the result.
Take a look at this example: view := RTMondrian new. view shape circle color: Color black. view nodes: (1 to: 42). view layout grid. view
On a white theme, it looks like:
<Playground-white.png>
On the dark theme, it would be:
<Playground-dark.png>
The problem is that in order to get the desired light gray result, I have to write “Color black” and this does not work.
White is only a shade of black :-)
How about introducing the notion of a ThemedColor?
Something like ThemedColor new for: RTDarkTheme use: Color lightGray; for: RTWhiteTheme use: Color black
And some derivates:
ThemedColor new forDark: Color lightGray; forWhite: Color black
Cheers, Doru
On Apr 24, 2017, at 4:52 PM, Pavel Krivanek pavel.krivanek@gmail.com wrote:
It's done. Thank you very much, Alex! We only need to tune some colors for the best result in both themes.
-- Pavel
2017-04-23 22:08 GMT+02:00 Tudor Girba tudor@tudorgirba.com: Hi,
As you could see, in Pharo we turned the Dark Theme on by default.
The question is what should we do with Moose. I think it would be great to have it working with the Dark Theme, but the problem is that the Roassal visualizations do not appropriate in the current theme because of two reasons:
- they were conceived on a white canvas
- the colors are hardcoded
Showing a white canvas in the Dark Theme is not an option. Either we introduce a mechanism to adapt the visualizations to the current theme, or we keep a different theme in Moose than in Pharo.
What do you think?
Cheers, Doru
-- www.tudorgirba.com www.feenk.com
"Not knowing how to do something is not an argument for how it cannot be done."
Moose-dev mailing list Moose-dev@list.inf.unibe.ch https://www.list.inf.unibe.ch/listinfo/moose-dev
Moose-dev mailing list Moose-dev@list.inf.unibe.ch https://www.list.inf.unibe.ch/listinfo/moose-dev
-- www.tudorgirba.com www.feenk.com
“The smaller and more pervasive the hardware becomes, the more physical the software gets."
Moose-dev mailing list Moose-dev@list.inf.unibe.ch https://www.list.inf.unibe.ch/listinfo/moose-dev
Moose-dev mailing list Moose-dev@list.inf.unibe.ch https://www.list.inf.unibe.ch/listinfo/moose-dev
-- www.tudorgirba.com www.feenk.com
"Next time you see your life passing by, say 'hi' and get to know her."
Moose-dev mailing list Moose-dev@list.inf.unibe.ch https://www.list.inf.unibe.ch/listinfo/moose-dev
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list Moose-dev@list.inf.unibe.ch https://www.list.inf.unibe.ch/listinfo/moose-dev
-- www.tudorgirba.com www.feenk.com
"No matter how many recipes we know, we still value a chef."