15 May
2012
15 May
'12
10:01 p.m.
Could it be a Pharo issue, because I think it happened since we moved to Pharo 1.4.
Doru
On 15 May 2012, at 21:51, Alexandre Bergel wrote:
Well… this happens since the changes in the collection
hierarchy a few weeks ago.
The tree layout should indeed preserver the order. I spent some time but I could not see
where the problem came from. I should spent some more time on this.
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
On May 13, 2012, at 11:21 PM, Tudor Girba wrote:
--
www.tudorgirba.com
Innovation comes in least expected form.
That is, if it is expected, it already happened.
Thanks, Alex.
But, it is not good in this case to fix the tests because the rendering should remain the
same :(.
For example, in the MetaBrowser I rely on the fact that the tree rendering remains the
same to highlight the currently selected property.
We need to investigate this issue closer because it is an important bug.
Cheers,
Doru
On 14 May 2012, at 04:04, Alexandre Bergel wrote:
--
www.tudorgirba.com
"Don't give to get. Just give."
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev >
I've seen you committed in the Mondrian rep about the rubber band drag and drop
facilities. This is indeed an interesting feature. However, I feel a bit more work is
necessary. Here are my suggestions:
> - can you make sure all the Mondrian tests are green. Apparently
MORoot>>resetFormCacheResursively disappeared.
>
Do you mean MONode>>resetFormCacheResursively which was renamed in
Mondrian-Core-AlexandreBergel.79 ?
I've searched back a few Mondrian-Core mcz files and not found
MORoot>>resetFormCacheResursively.
I fixed a few remaining references to this in Mondrian-Core-BenComan.80 et al.
Ok, I've produced a new version of Mondrian that includes your changes.
I fixed MOLayoutTest>>testTreeLayout
failure in Mondrian-Tests-BenComan.101.
There is one remaining failure that I can't work out. TestRunner cannot open a
debugger on it and after inserting 'self halt' it steps through to the end of the
method without a failure. Makes no sense to me. I need to leave this one to others.
The tree layout seems to randomly order the nodes. Type the following script in
an easel:
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
view shape rectangle withText.
view nodes: #(1 2 3 4 ).
view edgesFromAssociations: { 1 -> 2. 1 ->3 . 3 -> 4}.
view treeLayout
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Times to times it produces:
<Screen Shot 2012-05-13 at 10.02.08 PM.png>
times to times it produces:
<Screen Shot 2012-05-13 at 10.02.16 PM.png>
A few weeks ago, it had always produced the same rendering, and tests had been written
accordingly. Now it varies, so tests have to be adjusted. I fixed this.
The test is now green.
> - add new tests that capture your change of
MOCanvas>>mouseUp: , MOCanvas>>mouseOver:, and possibly for
MOCanvas>>drawOn:. Those methods are central to Mondrian, they need to be robust.
I will now start thinking about some tests for these.
Cool!
Alexandre
> Let me know how it goes. Currently the tests
of Mondrian are yellow.
>
> Cheers,
> Alexandre
>
>
> On 8 May 2012, at 16:42,
> admin(a)moosetechnology.org
> wrote:
>
>
>
>> See <http://hudson.moosetechnology.org/job/moose-latest-dev/972/>
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>>
>> Moose-dev(a)iam.unibe.ch
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>>
>>
>
>
>
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev