Hi Diego,
I only now got some time to review your browser. Nice job.
What I like:
- You integrated method editing
- You made it robust so that it can deal with configurations that do not have all parts
loaded
- You added the load / fetch commands and the associated refresh (through announcements)
- You kept the browser clean (often people have the tendency to add instance variables for
managing the browser state)
- You added a group view
What should be improved:
- You have two panes for specs and versions. We should unify them. Ideally, we should
build an intermediary model that keeps track both of the method and of the Metacello
version. Thus, when we select the version we should get the associated code as well.
- The cache instance variables should move into this model, as well.
- You used underlining to denote loaded code, and blue to denote configurations. I think
would like to keep color to denote when something has changed locally, but we can talk
about this.
- The group view should drill into dependencies as well. Like this we can see what is the
impact of loading a certain group.
- We need commit commands both for the configuration and for the packages :)
Btw, you worked on a separate package :). If you give me the StHub user, I add you to the
Moose team and we can work together on the GToolkit.
Cheers,
Doru
On Apr 12, 2013, at 11:05 AM, Diego Lont <diego.lont(a)delware.nl> wrote:
Hi Doru,
Maybe I did not follow all standards doing a remake of the configuration browser, but can
you take a look.
I fixed some performance bugs (not all,
dependencies still can be very slow).
I made it possible to edit the configuration.
I added the possibility
I set the layout to follow the Monticello standard instead of a new standard.
Maybe there is more work to be done, but please give your input how you like it so far.
Cheers,
Diego
<Deltawerken-Configuration-DiegoLont.7.mcz>
--
www.tudorgirba.com
"To lead is not to demand things, it is to make them happen."