yep... and then I forget about it :) I have a lot of things burning my brain this days... but I will do it today, sorry :P
Esteban
On Mar 13, 2013, at 9:28 AM, Usman Bhatti usman.bhatti@gmail.com wrote:
Doru,
I tested Thierry's fix and it corrected the problem with MorphTreeMorph, tests were green in Glamour. Thierry submitted a slice with the fix in Pharo inbox and Esteban was informed of the fix. He said that he'll it if the fix does not break tests.
Esteban, can you give an update on: SLICE-Issue-7345-DNU-with-Glamour-PaginatedMorphTreeMorphgtgtsetSelectedMorph-ThierryGoubier.2.mcz in pharo inbox?
tx. usman
On Tue, Mar 12, 2013 at 11:03 PM, Tudor Girba tudor@tudorgirba.com wrote: Hi,
Is there any update on this? It would be very useful to get Glamour working again :)
Cheers, Doru
On Mar 8, 2013, at 4:01 PM, Usman Bhatti usman.bhatti@gmail.com wrote:
Thierry,
The fix resolves the problem and the tests are green. Can you provide a slice to be included in Pharo2.0? you can upload slice here: http://code.google.com/p/moose-technology/issues/detail?id=905 tx.
usman
On Fri, Mar 8, 2013 at 2:59 PM, Usman Bhatti usman.bhatti@gmail.com wrote: Can you please send me the fix so that I can give it a try with Glamour and Moose browsers tests?
On Fri, Mar 8, 2013 at 2:55 PM, Goubier Thierry thierry.goubier@cea.fr wrote: Ok, I have a correction for that. How do I upload it ?
Technical: if pager is nil in a PaginatedMorphTreeMorph, do a ^ super update: to recover the original MorphTreeMorph behavior (i.e. a one line change).
Hum, I'm unable to try all Galmour tests. I ended with a nice segfault:(. At least I got GLMUpdateMorphicTest green.
Thierry
Le 08/03/2013 14:10, Usman Bhatti a écrit : Hello Thierry,
We are moving Moose to Pharo 2.0 and trying to make build green. There was a Glamour-related bug fix in MorphTreeMroph to correct this issue: http://code.google.com/p/moose-technology/issues/detail?id=905
The fix is integrated in Pharo2.0 and now when loading and running tests of Glamour and Moose-related browsers, there are a few failing tests and the trail leads to the update method in MorphTreeMorph because the pager is nil. Can you please have a look?
You can get the latest dev image of Moose on pharo2.0 here: https://ci.inria.fr/moose/job/Moose-latest-dev-4.8 and the problem can be reproduced when running glamour-related tests (e.g. GLMUpdateMorphicTest >>testInvalidateSelection).
tx,
Usman
On Thu, Mar 7, 2013 at 10:36 PM, Tudor Girba <tudor@tudorgirba.com mailto:tudor@tudorgirba.com> wrote:
Hi, Great. In the meantime, I fixed Mondrian and EyeSee to not throw errors. The problem was that in Pharo 2.0 Morphs send announcements, and these got confused with the specific announcements for Mondrian and EyeSee. Now Glamour has 7 errors but they are all due to the same problem of not being able to set the value of a port from outside when rendering a list. The issue comes from some internal modifications of MorphTreeMorph. It would be cool if someone could take a look at this. There are also a couple of Mondrian tests failing, but they are due to Easel accessing a missing class MorphicTextEditor which was already deprecated in 1.4. Nevertheless, the Easel is no longer really needed because we have one in Glamour. Cheers, Doru On Mar 7, 2013, at 4:26 PM, Usman Bhatti <usman.bhatti@gmail.com <mailto:usman.bhatti@gmail.com>> wrote: > For info. > > ---------- Forwarded message ---------- > From: Usman Bhatti <usman.bhatti@gmail.com <mailto:usman.bhatti@gmail.com>> > Date: Thu, Mar 7, 2013 at 4:15 PM > Subject: mini-moose sprint tomorrow > To: RMoD private list <lsehub-staff@lists.gforge.inria.fr <mailto:lsehub-staff@lists.gforge.inria.fr>> > > > Now that Moose has moved to SThub and we loading it on Pharo 2.0, there are some failing tests in Moose: https://ci.inria.fr/moose/job/Moose-latest-dev-4.8/lastCompletedBuild/testReport/ > > Tomorrow, we will try to make green FAMIX/Moose related tests. > > The place will be decided at "runtime" according to the number of participants. > > usman > -- www.tudorgirba.com <http://www.tudorgirba.com> "Every thing has its own flow."-- Thierry Goubier CEA list Laboratoire des Fondations des Systèmes Temps Réel Embarqués 91191 Gif sur Yvette Cedex France Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com
"We are all great at making mistakes."
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev