Thanks! I was able to reproduce the problem in Pharo 4.0. I have also integrated your fixes.
Cheers, Alexandre
On Dec 11, 2014, at 7:39 PM, Jan B. bliznjan@fit.cvut.cz wrote:
Hi, you should be able to reproduce it with any example/code with orthogonal multilines, for example RTRoassalExample new exampleOrthoVerticalLines2 open but this bug is in only in Pharo 4, it should work fine in Pharo 3 / Moose image. Pharo 4 has different behavior of Rectangle class than Pharo 3. My code should fix it for Pharo 4 which we use, but should not change behavior in Pharo 3 / Moose.
Just to save you searching in this thread... link to fix: http://www.mediafire.com/view/212hadou3uv9uiz/RTMultiLineFix.st link to fix + added balancing of middle line: http://www.mediafire.com/view/uzzue7f219x25bb/RTMultiLineFixWithBalance.st
Jan
abergel wrote
Hi Jan!
We are interested in fixing all the bugs :-) But I do not understand the one you describe. Can you provide a code snippet?
I have just tried:
v := RTView new.
v addAll: ((RTEllipse new size: 20; color: (Color red alpha: 0.3)) elementsOn: (1 to: 20)).
shape := RTMultiLine new. shape orthoVertical. shape color: (Color blue alpha: 0.3).
RTEdge buildEdgesFromObjects: (1 to: 20) from: [ :n | n // 3 ] to: #yourself using: shape inView: v.
v elements @ RTDraggable @ RTPopup.
RTTreeLayout on: v elements.
^ v
It works well on my image:
No?
Cheers, Alexandre
On Dec 11, 2014, at 5:44 PM, Jan B. <
bliznjan@.cvut
> wrote:
Hi
I'd like to ask whether you plan fixing this feature for Pharo 4 (by yourself or by using my code) or I should do it in my image. PS. I'm gonna need need the balancing feature for making orthogonal line made by two right-angled lines, which would be if I set balance to 0 or 1 (instead of default 0.5, which is the current behavior).
Jan
Jan B. wrote
Hi again
I found a reason why it behaves differently to me. There is differently implemented Rectangle's origin and corner behavior in Pharo 3.0 and in 4.0. In 3.0, calling Rectangle class >>#origin:corner: just sets this origin as origin and corner as corner, but in Pharo 4.0, it sets upper left 'corner' as origin and lower right 'corner' as corner, with code in previous message. So when you call edgeBound origin in Pharo 3.0, you get the original fromPoint, which could be any rectangle's corner, but in Pharo 4.0, you get always upper left corner of rectangle.
Jan Jan B. wrote
Interesting, I use Pharo 4.0 image #40370 Roassal2-AlexandreBergel.604.mcz Trachel-akevalion.240.mcz
I think that calling edgeBound origin x for 2nd point and edgeBound corner x for 3rd point should not work, because in Rectangle, "origin" is always top left and "corner" is always bottom right of it, even if you call fromPoint corner: toPoint, it sets its own corner in method Rectangle >>#setPoint:point:, which is called via RTMultiLine >>#orthoVertical Point >>#corner: Rectangle class >>#origin:corner: Rectangle >>#setPoint:point: and its code is origin := (pt1 x min: pt2 x)@(pt1 y min: pt2 y). corner := (pt1 x max: pt2 x)@(pt1 y max: pt2 y). meaning it always takes upper left corner as "origin" and lower right as "corner", no matter which original point were in which corner. abergel wrote
I do not understand. It works well on my image. Do you use Pharo 4 or a moose image?
Are you sure to have the last version of Roassal2 and Trachel?
Cheers, Alexandre
> On Nov 15, 2014, at 7:51 PM, Jan B. <
bliznjan@.cvut
> wrote: > > Hi, for example > RTRoassalExample new exampleOrthoVerticalLines2 open > you should see it right away > > > abergel wrote >> Hi Jan! >> >> First of all, how can I reproduce the bug? >> The following code seems to work well. At least it does in a moose >> image. >> >> -=-=-=-=-=-=-=-=-=-=-=-= >> v := RTView new. >> >> v addAll: ((RTEllipse new size: 20; color: (Color red alpha: 0.3)) >> elementsOn: (1 to: 20)). >> >> shape := RTMultiLine new. >> shape orthoVertical. >> shape color: (Color blue alpha: 0.3). >> >> RTEdge >> buildEdgesFromObjects: (1 to: 20) from: [ :n | n // 3 ] to: >> #yourself >> using: shape inView: v. >> >> v elements @ RTDraggable @ RTPopup. >> >> RTTreeLayout on: v elements. >> >> ^ v >> -=-=-=-=-=-=-=-=-=-=-=-= >> >> Cheers, >> Alexandre >> >> >>> On Nov 15, 2014, at 9:34 AM, Jan B. < > >> bliznjan@.cvut > >> > wrote: >>> >>> Hi, orthogonal modes of multiline do not seem to work right. Pretty >>> hard >>> to >>> describe, better to do it with picture: >>> https://monosnap.com/image/HyU0C2XV47uZqnLMHvP0qdEnDqjzu7.png >>> >>> I have a possible fix: >>> http://www.mediafire.com/view/212hadou3uv9uiz/RTMultiLineFix.st >>> >>> or the same fix with added ability to set balance of middle points, >>> ie. >>> ratio between fromPoint and toPoint: >>> http://www.mediafire.com/view/uzzue7f219x25bb/RTMultiLineFixWithBalance.st >>> ... possible uses: unknown, may just add code and cpu cycles for >>> nothing >>> >>> Jan >>> >>> >>> >>> -- >>> View this message in context: >>> http://forum.world.st/Roassal2-Orthogonal-multiline-bug-tp4790382.html >>> Sent from the Moose mailing list archive at Nabble.com. >>> _______________________________________________ >>> Moose-dev mailing list >>> > >> Moose-dev@.unibe > >>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev >> >> -- >> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: >> Alexandre Bergel http://www.bergel.eu >> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. >> >> >> >> >> _______________________________________________ >> Moose-dev mailing list > >> Moose-dev@.unibe > >> https://www.iam.unibe.ch/mailman/listinfo/moose-dev > > > > > > -- > View this message in context: > http://forum.world.st/Roassal2-Orthogonal-multiline-bug-tp4790382p4790435.ht... > Sent from the Moose mailing list archive at Nabble.com. > _______________________________________________ > Moose-dev mailing list >
Moose-dev@.unibe
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
-- View this message in context: http://forum.world.st/Roassal2-Orthogonal-multiline-bug-tp4790382p4795537.ht... Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list
Moose-dev@.unibe
-- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Moose-dev mailing list
Moose-dev@.unibe
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Screen Shot 2014-12-11 at 6.33.51 PM.png (15K) <http://forum.world.st/attachment/4795548/0/Screen%20Shot%202014-12-11%20at%2...;
-- View this message in context: http://forum.world.st/Roassal2-Orthogonal-multiline-bug-tp4790382p4795555.ht... Sent from the Moose mailing list archive at Nabble.com. _______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev