18 May
2011
18 May
'11
3:20 p.m.
---------- Forwarded message ----------
From: Tudor Girba <tudor(a)tudorgirba.com>
Date: 2011/5/18
Subject: Re: Mondrian
To: Santiago Vidal <santiago.a.vidal(a)gmail.com>
Cc: Alexandre Bergel <alexandre.bergel(a)me.com>om>, Claudia Marcos <
marcos.claudia(a)gmail.com>
Hi,
Please let's move this discussion to the moose-dev mailing list. It would be
a good documentation of Mondrian.
You can register here:
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
and send the mail here:
moose-dev(a)iam.unibe.ch
Cheers,
Doru
On 18 May 2011, at 14:55, Santiago Vidal wrote:
Hi,
I indented the methods and removed the 'MO' class prefix from each visit
method.
I'm not sure about the best way to avoid the
creation of a new visitor
each time a shape is displayed. Should I save a visitor
for each
MOGraphElement? The canvas changes each time that a shape is displayed? Can
you please tell me what is the cache that I have to moved to the visitor?
On another topic with Claudia we are advising the final work of two
student in
which we are going to use Moose. Specifically, we will use Moose
to compare different versions of an open source system with the goal of
identify differences in its modules. I would like to use Moose in my phd
thesis too, so this a first approach.
Cheers
Santiago
2011/5/17 Tudor Girba <tudor(a)tudorgirba.com>
Thanks. It works now:
http://ci.moosetechnology.org/job/mondrian-latest-dev-on-pharo-1.2/213/
Cheers,
Doru
On 17 May 2011, at 22:32, Alexandre Bergel wrote:
> Can you please lunch the build ?
>
> Cheers,
> Alexandre
>
>
> On 17 May 2011, at 16:03, Tudor Girba wrote:
>
>> Hi again,
>>
>> The build based on the 'default' configuration still says that
something is missing:
>>
http://ci.moosetechnology.org/job/mondrian-latest-dev-on-pharo-1.2/
>>
>> Cheers,
>> Doru
>>
>>
>> On 17 May 2011, at 21:43, Tudor Girba wrote:
>>
>>> Hi,
>>>
>>>
>>> On 17 May 2011, at 21:37, Alexandre Bergel wrote:
>>>
>>>> Hi Santiago,
>>>>
>>>> I updated the configuration. Your new package is now in.
>>>> The Jenkins should stop complaining by now :-)
>>>
>>> I started a build of Mondrian to check.
>>>
>>>> Each time a node is displayed, a new visitor is created. I do not
think this is necessary.
>>>
>>> This is actually not wanted at all because the renderer might have
some state later one.
>>>
>>> Cheers,
>>> Doru
>>>
>>>> Would you mind to indent the code with a tabulation at each line? For
example:
>>>> -=-=-=-=-=-=-=-=-=
>>>> acceptVisitor: aVisitor
>>>> ^aVisitor visitMODashedLineShape: self.
>>>> -=-=-=-=-=-=-=-=-=
>>>>
>>>> -=-=-=-=-=-=-=-=-=
>>>> acceptVisitor: aVisitor
>>>> ^ aVisitor visitMODashedLineShape: self.
>>>> -=-=-=-=-=-=-=-=-=
>>>>
>>>> Can you remove the 'MO' class prefix from each visit method?
(e.g.,
visitMODashedLineShape: -> visitDashedLineShape:)
>>>> I will do some benchmark to see if we
are slower, but we should not
be actually.
>>>>
>>>> Cheers,
>>>> Alexandre
>>>>
>>>>
>>>>
--
Ing. Santiago A. Vidal
ISISTAN Research Institute
UNICEN University
Paraje Arroyo Seco
Campus Universitario
(B7001BBO) Tandil,
Bs. As. - Argentina
Phone: 54 2293 439840 Ext. 42
Fax: 54 2293 439681
Email: svidal(a)exa.unicen.edu.ar
http://www.exa.unicen.edu.ar/~svidal