[Moose-dev] Re: fast job is broken

Yes. So first of all build is red because of mondrian conflicts. Mondrian defines acceptVisitor: aVisitor in Object as "aVisitor visitNode: self". This way if during parsing something wasn't parsed into an AST node with defined acceptVisitor: method, or wasn't initialized properly e.i. something returns nil then we end up in the infinite loop. That's why job is red and not yellow. Now the thing about the PetitJava. I see the parsed Java AST as wrapped expressions. This way type cast wraps expression that is casts into some type, negation expression wraps an expression that is negates. Chris sees it as properties for example accessor node has a property for cast and a flag for negation. Also in his vision a node should store an array of accessors if they follow each other whereas I say that there should be a couple of nodes wrapping each other. Also I think that code should be refactored as right now accessor node has negation flag with getters and setters, same is defined for method invocation. This functionality should be moved into a common superclass, same should be applied for type cast etc... Also it's a bit frustrating that one node can be created as a result of parsing several different grammar entities (you can read my full impression in previous PetitJava discussion). It's fine that we have different views on the development as we can develop two different things. But if we want to have one project in Moose platform, other members of community should help to decide what we are developing. Uko Надіслано з iPhone 30 черв. 2013 о 15:43 Tudor Girba <tudor(a)tudorgirba.com> написав(ла): _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev