Thanks, Nicolas.
On Mon, Dec 5, 2011 at 12:27 PM, Nicolas Anquetil nicolas.anquetil@inria.fr wrote:
I did several "improvements" to MooseChef. Reviews are welcome (Simon if you are around, please read this, specifically, at the end).
- Created withoutSelfLoops in MooseQueryObjectResult as discussed before
(see discussion on MooseChef end of november)
I will review that.
- Renamed all queryXxxIncoming/OutgoingDependencies to
queryXxxIncoming/OutgoingAssociations (see discussion on MooseChef & hidden dependencies last week)
I saw this one. Great.
- Introduced a virtual association : Instanciation that relates a variable
(structuredEntity to its type and a method (behaviouralEntity) to its returnType. I created MooseChefInstanciationAssociation for this. It is not in Famix as it is only intended to do queries.
I am not sure about introducing this entity.
In any case, the name is not good because: - Instanciation is not a word (Instantiation is) :) - instantiation conflicts with the dynamic meaning used in Dynamix
I would suggest MooseChefTypeDeclaration.
- Followed up with creating appropriate queryIncoming/OutgoingInstanciations
in FamixPackage, FamixClass, FamixMethod
All this has been tested and commited (this morning). Documentation on the web site was not updated
Meanwhile, I performed other modifications/corrections:
Better comment initiative: commented some MooseQueryResult classes
FamixPackage and FamixNamespace had the same classScope method that [only
makes sense to reject self loops in #collectAtScope:], I moved it to FAMIXScopingEntity.
- I found strange that there was no methodScope method, for consistency, I
added it, again in FAMIXScopingEntity.
- Still for consistency, I added a methodScope method to FamixType
Finally, I still have some questions (Simon?)
- the trait TScopingEntityQuery seems to exist only to be added to
FamixScopingEntity. Is that so?
Why having a trait in this case? Consistency? If so, may be it should be documented (comment).
- MooseOutgoingCompositionQueryResult does not use TDependencyQueryResult
whereas its sisters (MooseOutgoing/IncommingQueryResult) do. This means MooseOutgoingCompositionQueryResult is lacking many selectors that its sisters have (opposites, ...)
Error or feature?
nicolas
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev