Hoorah. Busted 8 failures in one swipe:
https://ci.inria.fr/moose/job/moose-latest-dev-4.8/86/testReport/
So now about details. After Fabrizio's example it wasn't hard to find out that
"1." is treated as a number literal and "1. variable" is treated as a
message send to a literal. After a fast talk with Marcus it turned out that Number
class>>readFrom: started to use ExtendedNumberParser instead of SqNumberParser. So
to fix the problem I've changed "Number readFrom: stream" to
"(SqNumberParser on: stream) nextNumber" in a number parser of
PPSmalltalkGrammar.
Cheers,
Uko
On 14 бер. 2013, at 21:58, Fabrizio Perin-3 [via moose-dev]
<ml-node+s97923n4026485h80(a)n3.nabble.com> wrote:
Hi I was checking at the code quickly and there is
problem that is related to unary expression parsing. Something like this:
whatever + 1.
variable := 2+2
will be recognized as: "whatever" "+" "1. variable"
so the second term is not just "1" but includes everything up to ":".
Did something changed with unary expression evaluation?
I tried to play with it but I couldn't fix it.
I will investigate further tomorrow.
Cheers,
Fabrizio
2013/3/13 Yuriy Tymchuk <[hidden email]>
Super. Now the only failing tests are the ones that I've mentioned at the
beginning. Maybe in Pharo 2.0 something changed with streams, but all the
failing test have the same problem: parser finishes parsing before the end
of the string. Maybe Lukas can take a look at it, because I'm quite new to
the PP implementation
--
View this message in context:
http://moose-dev.97923.n3.nabble.com/Failing-PetitSmalltalk-tests-tp4026442…
Sent from the moose-dev mailing list archive at
Nabble.com.
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
If you reply to this email, your message will be added to the discussion below:
http://moose-dev.97923.n3.nabble.com/Failing-PetitSmalltalk-tests-tp4026442…
To unsubscribe from Failing PetitSmalltalk tests, click here.
NAML
--
View this message in context:
http://moose-dev.97923.n3.nabble.com/Failing-PetitSmalltalk-tests-tp4026442…
Sent from the moose-dev mailing list archive at
Nabble.com.