[Moose-dev] Re: Issue 1079 in moose-technology: , (comma) should not be implemented in the FM*MultivalueLink classes

Comment #3 on issue 1079 by v.blonde...(a)gmail.com: , (comma) should not be implemented in the FM*MultivalueLink classes http://code.google.com/p/moose-technology/issues/detail?id=1079 Of course, when you copy a FMMultivalueLink you get a copy of the FMMultivalueLink. But don't forget that, by nature, the FMMultivalueLink is liked to an method accessor to update itself. In moose you don't do FMMultivalueLink new. But "FMMultivalueLink on: aFamixClass opposite: #parentType:" for instance. So "," do a copy of the receiver and add to this copy each element of the argument. But the add method in FMMultivalueLink is updating aFamixClass parentType (if we take the example). But parentType is an other FMMultivalueLink that is updating the "attribute" value of aFamixClass. And this value is the old FMMultivalue link (the old collection) and not the new one you just copied ! To summarize, by doing "," : - you just add nothing to your new collection - and you add something to a collection that you don't wanted to change... That is why I propose to remove it. And it's not late ! For the next using this method, it will be useful ! Does your head feel better? :) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings