Hi Alex,
unfortunately changes in TRCompositeShape created a regression, because now
TRRemoveCallbacks are executed multiple times.
the commit is Trachel-AlexandreBergel.266
Interestingly there is TRCompositeShapeTest>>testCallback01 which works,
but it doesn't use RTElement.
Here's a test case:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|v e executed|
v := RTView new.
e := RTElement new.
e + (RTBox new) + (RTEllipse new).
executed := 0.
e trachelShape addCallback: (TRRemoveCallback new block: [ :shape |
executed := executed + 1 ]).
v add: e.
TestAsserter new assert: executed equals: 0.
e remove.
TestAsserter new assert: executed equals: 1.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Now since you have discussed with Jan that the new behavior makes sense in
some circumstances, it would be better to have both behaviors.
So I would propose to make a distinction for RemoveCallback - to not
triggered them from TRCompositeShape, because it is not reentrant.
Thus when executed on composite shape, only non-removing callbacks would be
executed.
Additionally it seems very random that CompositeShape uses it's first
subshape for callbacks; what is so special about the first one? Why can't
composite shape hold it's own callbacks, or have an explicit way to specify
which one to use (first, second, none, ..)?
Since Composite Shape is recurring problematic theme, perhaps there should
be some wider discussion to collect all the use cases?
What do you think?
Peter
No. We only load the stable in Moose and release Moose 5.1 for Pharo 4.0
(we are overdue anyway).
Doru
On Wed, Apr 29, 2015 at 11:43 AM, Andrei Chis <chisvasileandrei(a)gmail.com>
wrote:
> Do we backport String>>#findAnySubstring:startingAt: to Pharo 4?
> It breaks the inspector in moose.
>
> Cheers,
> Andrei
>
> On Wed, Apr 29, 2015 at 10:57 AM, Andrei Chis <chisvasileandrei(a)gmail.com>
> wrote:
>
>> Now you also need to integrate
>> https://pharo.fogbugz.com/f/cases/15438/Update-Rubric as otherwise you
>> cannot use spotter/playground.
>> I'll also make another issue for updating the entire gtools suite.
>>
>> Cheers,
>> Andrei
>>
>> On Wed, Apr 29, 2015 at 10:43 AM, GitHub <noreply(a)github.com> wrote:
>>
>>> Branch: refs/heads/5.0
>>> Home: https://github.com/pharo-project/pharo-core
>>> Commit: 0b91cdb07971022da3f17f804d4d8a9eb355d341
>>>
>>> https://github.com/pharo-project/pharo-core/commit/0b91cdb07971022da3f17f80…
>>> Author: Jenkins Build Server <board(a)pharo-project.org>
>>> Date: 2015-04-29 (Wed, 29 Apr 2015)
>>>
>>> Changed paths:
>>> R
>>> Collections-Strings.package/String.class/instance/accessing/allRangesOfSubString_.st
>>> R
>>> Collections-Strings.package/String.class/instance/accessing/findAnySubStr_startingAt_.st
>>> A
>>> Collections-Strings.package/String.class/instance/accessing/findAnySubstring_startingAt_.st
>>> R
>>> Collections-Strings.package/String.class/instance/accessing/findBetweenSubStrs_.st
>>> A
>>> Collections-Strings.package/String.class/instance/accessing/findBetweenSubstrings_.st
>>> M
>>> Collections-Strings.package/String.class/instance/accessing/findLastOccurrenceOfString_startingAt_.st
>>> M
>>> Collections-Strings.package/String.class/instance/accessing/findString_.st
>>> M
>>> Collections-Strings.package/String.class/instance/accessing/findString_startingAt_.st
>>> M
>>> Collections-Strings.package/String.class/instance/accessing/findTokens_includes_.st
>>> M
>>> Collections-Strings.package/String.class/instance/accessing/includesSubstring_.st
>>> R
>>> Collections-Strings.package/String.class/instance/accessing/skipAnySubStr_startingAt_.st
>>> A
>>> Collections-Strings.package/String.class/instance/accessing/skipAnySubstring_startingAt_.st
>>> R
>>> Collections-Strings.package/String.class/instance/converting/subStrings_.st
>>> M
>>> Collections-Strings.package/String.class/instance/converting/substrings_.st
>>> R CollectionsTests.package/StringTest.class/instance/testing -
>>> converting/testSubStrings.st
>>> M
>>> CollectionsTests.package/TAsStringCommaAndDelimiterSequenceableTest.class/instance/tests
>>> - comma and delimiter/testAsCommaStringMore.st
>>> M
>>> CollectionsTests.package/TAsStringCommaAndDelimiterSequenceableTest.class/instance/tests
>>> - comma and delimiter/testAsStringOnDelimiterLastMore.st
>>> M
>>> CollectionsTests.package/TAsStringCommaAndDelimiterSequenceableTest.class/instance/tests
>>> - comma and delimiter/testAsStringOnDelimiterMore.st
>>> M
>>> CollectionsTests.package/TAsStringCommaAndDelimiterTest.class/instance/tests
>>> - as string comma delimiter sequenceable/testAsCommaStringMore.st
>>> M
>>> CollectionsTests.package/TAsStringCommaAndDelimiterTest.class/instance/tests
>>> - as string comma delimiter sequenceable/testAsStringOnDelimiterLastMore.st
>>> M
>>> CollectionsTests.package/TAsStringCommaAndDelimiterTest.class/instance/tests
>>> - as string comma delimiter sequenceable/testAsStringOnDelimiterMore.st
>>> M
>>> CollectionsTests.package/TPrintOnSequencedTest.class/instance/tests -
>>> printing/testPrintElementsOn.st
>>> M
>>> CollectionsTests.package/TPrintOnSequencedTest.class/instance/tests -
>>> printing/testPrintOn.st
>>> M
>>> CollectionsTests.package/TPrintOnSequencedTest.class/instance/tests -
>>> printing/testPrintOnDelimiter.st
>>> M
>>> CollectionsTests.package/TPrintOnSequencedTest.class/instance/tests -
>>> printing/testPrintOnDelimiterLast.st
>>> M CollectionsTests.package/TPrintTest.class/instance/tests -
>>> printing/testPrintElementsOn.st
>>> M CollectionsTests.package/TPrintTest.class/instance/tests -
>>> printing/testPrintOn.st
>>> M CollectionsTests.package/TPrintTest.class/instance/tests -
>>> printing/testPrintOnDelimiter.st
>>> M CollectionsTests.package/TPrintTest.class/instance/tests -
>>> printing/testPrintOnDelimiterLast.st
>>> M CollectionsTests.package/TPrintTest.class/instance/tests -
>>> printing/testStoreOn.st
>>> A
>>> Deprecated50.package/extension/String/instance/allRangesOfSubString_.st
>>> A
>>> Deprecated50.package/extension/String/instance/findAnySubStr_startingAt_.st
>>> A
>>> Deprecated50.package/extension/String/instance/findBetweenSubStrs_.st
>>> A
>>> Deprecated50.package/extension/String/instance/skipAnySubStr_startingAt_.st
>>> A Deprecated50.package/extension/String/instance/subStrings_.st
>>> M
>>> Morphic-Base.package/Paragraph.class/instance/selection/secondarySelection_.st
>>> M
>>> Morphic-Base.package/TextMorphForEditView.class/instance/find-replace/findNextString_startingAt_.st
>>> M
>>> Morphic-Base.package/TextMorphForEditView.class/instance/private/refreshExtraSelection.st
>>> M
>>> NECompletion.package/NECSymbols.class/class/query/startsWith_caseSensitive_do_.st
>>> M Network-Mail.package/MIMEHeaderValue.class/class/instance
>>> creation/fromMIMEHeader_.st
>>> M
>>> Refactoring-Critics.package/RBFutureDeprecationWarningRule.class/instance/private/plannedSelectorRenames.st
>>> A
>>> Reflectivity-Tests.package/ReflectiveMethodTest.class/instance/tests -
>>> links/testLinkWithConditionInvalidation.st
>>> A Reflectivity.package/MetaLink.class/instance/installing/
>>> invalidate.st
>>> M Reflectivity.package/MetaLink.class/instance/link api/arguments_.st
>>> M Reflectivity.package/MetaLink.class/instance/link api/condition_.st
>>> M Reflectivity.package/MetaLink.class/instance/link api/control_.st
>>> M Reflectivity.package/MetaLink.class/instance/link api/level_.st
>>> M Reflectivity.package/MetaLink.class/instance/link
>>> api/metaObject_.st
>>> M Reflectivity.package/MetaLink.class/instance/link api/selector_.st
>>> A Reflectivity.package/extension/RBProgramNode/instance/
>>> invalidate.st
>>> M
>>> SUnit-Core.package/TAssertable.class/instance/asserting/should_raise_whoseDescriptionDoesNotInclude_description_.st
>>> M
>>> SUnit-Core.package/TAssertable.class/instance/asserting/should_raise_whoseDescriptionIncludes_description_.st
>>> M
>>> SUnit-Core.package/TAssertable.class/instance/asserting/shouldnt_raise_whoseDescriptionDoesNotInclude_description_.st
>>> M
>>> SUnit-Core.package/TAssertable.class/instance/asserting/shouldnt_raise_whoseDescriptionIncludes_description_.st
>>> M
>>> ScriptLoader50.package/ScriptLoader.class/class/source/latestVersionOf_location_.st
>>> R ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/
>>> script627.st
>>> A ScriptLoader50.package/ScriptLoader.class/instance/pharo - scripts/
>>> script628.st
>>> R ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/
>>> update50018.st
>>> A ScriptLoader50.package/ScriptLoader.class/instance/pharo - updates/
>>> update50019.st
>>> M
>>> ScriptLoader50.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st
>>> M
>>> Text-Core.package/Text.class/instance/accessing/findString_startingAt_.st
>>> M
>>> Text-Core.package/Text.class/instance/accessing/findString_startingAt_caseSensitive_.st
>>> R
>>> Text-Edition.package/FindReplaceService.class/instance/services/findNextSubString_inTextMorph_.st
>>> M
>>> Text-Edition.package/TextEditor.class/instance/find-select/findNextString_startingAt_.st
>>> M Text-Edition.package/TextEditor.class/instance/menu
>>> messages/findAgain.st
>>> M Tool-Finder.package/MethodFinder.class/instance/initialize/
>>> initialize2.st
>>>
>>> Log Message:
>>> -----------
>>> 50019
>>> 14080 Nuke remaining subStringXyzs
>>> https://pharo.fogbugz.com/f/cases/14080
>>>
>>> 15435 MetaLink: invalidate all methods when state of link ist changed
>>> https://pharo.fogbugz.com/f/cases/15435
>>>
>>> http://files.pharo.org/image/50/50019.zip
>>>
>>>
>>>
>>
>
--
www.tudorgirba.com
"Every thing has its own flow"
Hi,
why can’t we put GLMRoassal2Presentation and related classes into roassal? For now when you load roassal into your image you cannot see roassal view in the inspector, you cannot see examples and so on. Glamour is by default now in Pharo image. Why should roassal related code be in special glamour repo and not in roassal repo?
Uko
… but it has GLMInputPresentation :)
shouldn’t we add #input to GLMCompositePresentation?
other questions: since Glamour now is part of Pharo, should glamour questions be redirected to pharo-dev?
Esteban
Hi,
I need to make horizontal scroll in tables and I don’t find the way. Is that possible?
I remember I did it a couple of years ago, but I don’t remember if is something I hacked or it was provided…
Esteban
Hi guys,
do you know, that if one loads Moose by hand in Pharo 4 by running:
Metacello new
smalltalkhubUser: 'Moose'
project: 'Moose';
configuration: 'Moose';
version: #development;
load
then you get a warning:
This package depends on the following classes:
MethodContext
You must resolve these dependencies before you will be able to load these definitions:
classOrMetaClass
messageName
and if you skip it, on any error an emergency evaluator will popup and wont go away.
Uko
Hi!
We just improved the SparkLine support in Roassal.
Consider:
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
v := RTView new.
cls := RTLayout withAllSubclasses.
s := RTSparkline new
width: 50; height: 30;
values: [ :cls | (cls methods collect: #numberOfLinesOfCode) sorted ].
es := s elementsOn: cls.
v addAll: es.
es @ RTPopup @ RTDraggable.
RTFlowLayout on: es.
v
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
This is still early work, but I still wanted to share it with you.
Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Dear All,
There is a possibility to do a postdoc at the University of Chile. The position is competitive: 3 years, good salary, and a budget you can spend as you wish.
Get in touch with me for more info.
Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
Hi all,
Glamour has been a really empowering framework for quick prototyping of
my ideas, but my browser starts to need more common user interface things:
1. A explicit menu with submenus on top of the browser windows (not
hidden behind the dots like now).
2. Better icons and a tool bar.
3. A contextual menu in each node of the tree for actions on that node.
I remember an introductory video of Tudor where he said that Moose is
not for general interface building (I can't find it right now) and If
I'm well some time ago versioner was made on Glamour.
So, my question is: If I want the features of a common interface, which
is the best approach? Rewrite the interface on Spec or mixing/extend
some parts of the browser with spec or anything else? If the last is the
case, there is any documentation or examples I can look?
Thanks,
Offray
