Hi
Apparently lot of tests are broken and things like union: do not work anymore. unionCollect: also.
So what do we do?
Stef
Yes and no :). Out of 108 tests only 4 are breaking, and they are not that critical. So, I would say it's not in a bad shape.
Doru
On Jun 13, 2008, at 5:26 PM, stéphane ducasse wrote:
Hi
Apparently lot of tests are broken and things like union: do not work anymore. unionCollect: also.
So what do we do?
Stef
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
-- www.tudorgirba.com www.tudorgirba.com/blog
"What we can governs what we wish."
I didn't maintain it any more, as I do not use VW any longer. All my Smalltalk stuff is now Squeak based, so please feel free to take it over. ..
cheers, AA
On 13 Jun 2008, at 17:26 , stéphane ducasse wrote:
Hi
Apparently lot of tests are broken and things like union: do not work anymore. unionCollect: also.
So what do we do?
Stef
Ok at least this is clear and I will happily hack in there.
Stef
On Jun 14, 2008, at 6:11 AM, Adrian Kuhn wrote:
I didn't maintain it any more, as I do not use VW any longer. All my Smalltalk stuff is now Squeak based, so please feel free to take it over. ..
cheers, AA
On 13 Jun 2008, at 17:26 , stéphane ducasse wrote:
Hi
Apparently lot of tests are broken and things like union: do not work anymore. unionCollect: also.
So what do we do?
Stef
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
union: is fixed. I will retry in 7.6. Next on the radar unionCollect:
Stef
Ok at least this is clear and I will happily hack in there.
Stef
On Jun 14, 2008, at 6:11 AM, Adrian Kuhn wrote:
I didn't maintain it any more, as I do not use VW any longer. All my Smalltalk stuff is now Squeak based, so please feel free to take it over. ..
cheers, AA
On 13 Jun 2008, at 17:26 , stéphane ducasse wrote:
Hi
Apparently lot of tests are broken and things like union: do not work anymore. unionCollect: also.
So what do we do?
Stef
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
In the method union: I don't understand why if the receiver is empty, the result of the method should be an empty Set. Shouldn't the result be the argument of the method?
Romain
-----Message d'origine----- De : moose-dev-bounces@iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch] De la part de Stéphane Ducasse Envoyé : samedi 14 juin 2008 10:02 À : Related to the development of Moose and other related tools Objet : [Moose-dev] Re: is CodeFoo maintained?
union: is fixed. I will retry in 7.6. Next on the radar unionCollect:
Stef
Ok at least this is clear and I will happily hack in there.
Stef
On Jun 14, 2008, at 6:11 AM, Adrian Kuhn wrote:
I didn't maintain it any more, as I do not use VW any longer. All my Smalltalk stuff is now Squeak based, so please feel free to take it over. ..
cheers, AA
On 13 Jun 2008, at 17:26 , stéphane ducasse wrote:
Hi
Apparently lot of tests are broken and things like union: do not work anymore. unionCollect: also.
So what do we do?
Stef
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
do you have an example that I can add to the test suite?
Stef
On Jun 14, 2008, at 10:34 AM, Romain PEIRS wrote:
In the method union: I don't understand why if the receiver is empty, the result of the method should be an empty Set. Shouldn't the result be the argument of the method?
Romain
-----Message d'origine----- De : moose-dev-bounces@iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch ] De la part de Stéphane Ducasse Envoyé : samedi 14 juin 2008 10:02 À : Related to the development of Moose and other related tools Objet : [Moose-dev] Re: is CodeFoo maintained?
union: is fixed. I will retry in 7.6. Next on the radar unionCollect:
Stef
Ok at least this is clear and I will happily hack in there.
Stef
On Jun 14, 2008, at 6:11 AM, Adrian Kuhn wrote:
I didn't maintain it any more, as I do not use VW any longer. All my Smalltalk stuff is now Squeak based, so please feel free to take it over. ..
cheers, AA
On 13 Jun 2008, at 17:26 , stéphane ducasse wrote:
Hi
Apparently lot of tests are broken and things like union: do not work anymore. unionCollect: also.
So what do we do?
Stef
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
I thought something like that: self assert: ((Set new union: #(1 2 4) asSet) equalsTo: #(1 2 4) asSet)
Romain
-----Message d'origine----- De : moose-dev-bounces@iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch] De la part de Stéphane Ducasse Envoyé : samedi 14 juin 2008 11:36 À : Related to the development of Moose and other related tools Objet : [Moose-dev] Re: is CodeFoo maintained?
do you have an example that I can add to the test suite?
Stef
On Jun 14, 2008, at 10:34 AM, Romain PEIRS wrote:
In the method union: I don't understand why if the receiver is empty, the result of the method should be an empty Set. Shouldn't the result be the argument of the method?
Romain
-----Message d'origine----- De : moose-dev-bounces@iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch
] De la part de Stéphane Ducasse Envoyé : samedi 14 juin 2008 10:02 À : Related to the development of Moose and other related tools Objet : [Moose-dev] Re: is CodeFoo maintained?
union: is fixed. I will retry in 7.6. Next on the radar unionCollect:
Stef
Ok at least this is clear and I will happily hack in there.
Stef
On Jun 14, 2008, at 6:11 AM, Adrian Kuhn wrote:
I didn't maintain it any more, as I do not use VW any longer. All my Smalltalk stuff is now Squeak based, so please feel free to take it over. ..
cheers, AA
On 13 Jun 2008, at 17:26 , stéphane ducasse wrote:
Hi
Apparently lot of tests are broken and things like union: do not work anymore. unionCollect: also.
So what do we do?
Stef
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________ Moose-dev mailing list Moose-dev@iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Excellent I fixed that and added it to the tests
Stef
I kept the functional style of union by creating a new set.
union: aSet "Answer the union of the receiver A and aSet B. The union is defined as { x | x in A or x in B }."
| set | self isEmpty ifTrue: [^aSet copy]. set := Set new. set addAll: aSet. set addAll: self. ^ set
Sequenceable>>union: aSet "Answer the union of the receiver A and aSet B. The union is defined as { x | x in A or x in B }."
| stream set | self isEmpty ifTrue: [^aSet copy ]. stream := (self species new: self size) writeStream. set := Set new. set addAll: aSet. set addAll: self. stream nextPutAll: set. ^stream contents
-
Adrian Kuhn -
Romain PEIRS -
stéphane ducasse -
Stéphane Ducasse -
Tudor Girba