Hi Veronica,
I took a look at your changes. titleIconValue should be implemented
simply like:
titleIconValue
^ self titleIcon notNil
ifTrue: [ self titleIcon glamourValue: self entity ]
ifFalse: [ self titleIcon ]
I fixed this in Glamour-Core-tg.41.
Regarding the Morphic rendering changes, I understand that you would
like to use your own widget library. In this case, I would rather
suggest to use another presentation keyword. Providing yet another
layer of indirection can lead to understanding problems. Otherwise, if
those widgets are open source (under a MIT license), perhaps we can
try to integrate them into Glamour. Yet another option is to subclass
the renderer altogether.
Or maybe you have some other reasons that I do not see for the moment.
Feel free to point them our :).
Cheers,
Doru
On 1 Nov 2009, at 21:20, Tudor Girba wrote:
Hi Veronica,
Indeed, Momo has just changed dramatically because Alain was nice
enough to work on a proper multi-selection tree widget. I am now
working on adopting the rendering to work with these changes.
Cheers,
Doru
On 1 Nov 2009, at 21:15, Veronica Isabel Uquillas Gomez wrote:
> done...
>
> few changes to allow me the use of subclasses with my own formatting.
>
> btw, the last version of Momo removed a method that is used when
> rendering the trees...
>
> regards,
> Veronica
>
>
> On 01 Nov 2009, at 20:32, Tudor Girba wrote:
>
>> Hi Veronica,
>>
>> Please publish them and I will check the differences and give you
>> feedback.
>>
>> Cheers,
>> Doru
>>
>>
>> On 1 Nov 2009, at 20:17, Veronica Isabel Uquillas Gomez wrote:
>>
>>> Hello Tudor,
>>>
>>> On Monday I extended Glamour to include a diff browser, I just
>>> noticed you already did that on thursday night :(
>>> Well, the point is that i am using my own MorphicLibrary to
>>> include new elements to the tags (e.g. icons, icons + text).
>>>
>>> So i have some changes that i would like to include in the last
>>> version... Am i allowed to publish them? or should i send you
>>> the changes?
>>>
>>> Thanks,
>>> Veronica Uquillas
>>>
>>
>> --
>>
www.tudorgirba.com
>>
>> "It's not what we do that matters most, it's how we do it."
>>
>
--
www.tudorgirba.com
"Being happy is a matter of choice."
--
www.tudorgirba.com
"Problem solving should be concentrated on describing
the problem in a way that is relevant for the solution."