Sorry guys for having been slow on fixing this. I've got a strong flue since
Saturday.
The benefit of this particular implementation is indeed weak. However, I would like to
stress the importance of having any non abstract shape instantiable with reasonable
default value. And so, whatever if the shape is produced by a builder or not.
Mondrian remains unfortunately very complex. We should improve it by making more user
friendly.
Cheers,
Alexandre
On 25 Aug 2010, at 09:34, Tudor Girba wrote:
Great. Please commit this fix. It is too costly for the weak
benefits.
Cheers,
Doru
On 25 Aug 2010, at 15:26, Veronica Isabel Uquillas Gomez wrote:
> Hi Doru/Simon/Jannik,
>
> Love you guys!!!
> indeed that validation is causing such horrible slowdown, I even removed the new
method and Torch flies :D
>
> why does Mondrian still keep that method?
>
> cheers,
> Veronica
>
>
>
> On 25 Aug 2010, at 14:26, Tudor Girba wrote:
>
>> Hi Veronica,
>>
>> Could you try removing the following line in MOShape>>new
>>
>> self isAbstractClass ifTrue: [ self error: 'An abstract class cannot be
instantiated' ].
>>
>> ?
>>
>> Jannik discovered that this line is responsible for a lag. I would like to know
if this has an impact on your code as well.
>>
>> Cheers,
>> Doru
>>
>> On 25 Aug 2010, at 14:18, Veronica Isabel Uquillas Gomez wrote:
>>
>>> Hi Alexandre
>>>
>>> I tried and I don't see any improvement. In fact, not only the popup
views are slows, but navigating through the different visualizations too, till the point
my image crashed!!!
>>>
>>> I was evaluating Torch with different slices and with the changes on Mondrian
itself.
>>>
>>> You can use this image (with the last version of Torch and the version 523 of
Mondrian)
>>> Torch-PharoCore-1.1-11411.zip
>>>
>>> - Go to the repository of Mondrian and open the history of the last version.
Here select the version loaded in the image, open the contextual menu and view the changes
with Torch.
>>> On the first visualization you can inspect the structures of any class by
pointing to their names or on the small dashed squares (you should see popup views).
>>> You can also move through the different visualizations.
>>> With this version, the navigation is fast.
>>>
>>> - Now load on the same image the lastest version of Mondrian and repeat the
previous comparison. You will notice the problem.
>>>
>>> I am already concerned. I thought that only the popup views were slow, but
now I see that also moving to the different visualizations.
>>>
>>> Please, let me know after you try.
>>>
>>> Regards,
>>> Veronica
>>>
>>>
>>> On 23 Aug 2010, at 03:11, Alexandre Bergel wrote:
>>>
>>>> Hi Veronica!
>>>>
>>>> Can you try with Version 546?
>>>>
>>>> Cheers,
>>>> Alexandre
>>>>
>>>>
>>>> On 16 Aug 2010, at 10:58, Veronica Isabel Uquillas Gomez wrote:
>>>>
>>>>> Hi Alexander,
>>>>>
>>>>> I updated my image today with the last version of Mondrian (541). I
had previously (523).
>>>>> The problem I noticed immediately is a terrible slowdown presenting
popup views... They are used a lot in Torch for presenting diffs!!
>>>>>
>>>>> Could you please find the problem?
>>>>>
>>>>> Regards,
>>>>> Veronica
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Moose-dev mailing list
>>>>> Moose-dev(a)iam.unibe.ch
>>>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>>
>>>> --
>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>> Alexandre Bergel
http://www.bergel.eu
>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>> Moose-dev(a)iam.unibe.ch
>>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> Moose-dev(a)iam.unibe.ch
>>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> --
>>
www.tudorgirba.com
>>
>> "Don't give to get. Just give."
>>
>>
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> Moose-dev(a)iam.unibe.ch
>>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
> _______________________________________________
> Moose-dev mailing list
> Moose-dev(a)iam.unibe.ch
>
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"To lead is not to demand things, it is to make them happen."
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev