Hi,
On Fri, Sep 26, 2014 at 2:39 PM, Anne Etien <anne.etien(a)univ-lille1.fr>
wrote:
By the way, we ran the test, it was the only thing
that call the method we
corrected. The test was green. But after your comments, we realize that the
method in the test was called on an empty collection. So we tried to apply
our change on a non empty collection and we realized that we introduced
bugs. We correct them. We have now almost the same representation except
the difference between HorizontalDominanceTreeLayout and
HorizontalTreeLayout. As Nicolas said, it is really difficult for us
without the knowledge of Roassal to do it.
Thanks. I did it now. I just had to copy the classes I mentioned to
Roassal2. I committed the change.
Concerning your question on text presentation, we are
not enough expert to
understand the question and see the difference. We had a look at how text
are used in the view build on Roassal and we arrived to this conclusion.
Never mind. It was a mistake on my side.
Cheers,
Doru
Gustavo and Anne
Le 26 sept. 2014 à 12:31, Tudor Girba <tudor(a)tudorgirba.com> a écrit :
Thanks.
I reviewed viewAllNamedParsers:
You replaced
horizontalDominanceTreeLayout with treeLayout. However, we do need
horizontalDominanceTreeLayout in this case. A better approach would be to
port RODominanceTreeLayout and ROHorizontalDominanceTreeLayout to Roassal2.
Could you look into this?
Also, why did you change the text presentation to the default one from
rubricText?
Doru
On Fri, Sep 26, 2014 at 12:01 PM, Anne Etien <anne.etien(a)univ-lille1.fr>
wrote:
Hi,
We just committed PPParser>>#viewAllNamedParsers
and are currently working on PPParser>>#visualizeStructureInGraph
Gustavo and Anne
Le 26 sept. 2014 à 11:34, Tudor Girba <tudor(a)tudorgirba.com> a écrit :
Hi,
Please send to the mailing list all progress about the migration from
Roassal1 to Roassal2.
Doru
--
www.tudorgirba.com
"Every thing has its own flow"
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"Every thing has its own flow"
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
--
www.tudorgirba.com
"Every thing has its own flow"