did union: work in the past? - Moose-dev - INF Mailman

List overview All Threads
Download

did union: work in the past?

is CodeFoo maintained?

A word about deprecated

stephane ducasse

13 Jun 2008 13 Jun '08

5:48 p.m.

hi all did union: work? Did it work on VW75? is it a bug only due to 76? Stef

Reply

Show replies by date

Romain PEIRS

13 Jun 13 Jun

9:15 p.m.

In VW 7.5, union: doesn't work if the receiver is not a SequenceableCollection. That's why the method testUnion fails. Romain -----Message d'origine----- De : moose-dev-bounces(a)iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch] De la part de stephane ducasse Envoyé : vendredi 13 juin 2008 17:49 À : Related to the development of Moose and other related tools Objet : [Moose-dev] did union: work in the past? hi all did union: work? Did it work on VW75? is it a bug only due to 76? Stef _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Stéphane Ducasse

10:45 p.m.

Thanks romain. I loaded Moose in 7.5 and tried it since I got no answer. Stef On Jun 13, 2008, at 9:15 PM, Romain PEIRS wrote:

In VW 7.5, union: doesn't work if the receiver is not a SequenceableCollection. That's why the method testUnion fails. Romain -----Message d'origine----- De : moose-dev-bounces(a)iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch ] De la part de stephane ducasse Envoyé : vendredi 13 juin 2008 17:49 À : Related to the development of Moose and other related tools Objet : [Moose-dev] did union: work in the past? hi all did union: work? Did it work on VW75? is it a bug only due to 76? Stef _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Tudor Girba

14 Jun 14 Jun

2:10 a.m.

Hi Stef, The code was always somehow broken because it tries to do too many things and putting Array and Set in the same pot does not work well. I do not know how to fix it to work with everything, but for now I am only using it for SequencebleCollection anyway. The test is red just to keep a reminder. Cheers, Doru On Jun 13, 2008, at 10:45 PM, Stéphane Ducasse wrote:

Thanks romain. I loaded Moose in 7.5 and tried it since I got no answer. Stef On Jun 13, 2008, at 9:15 PM, Romain PEIRS wrote:

In VW 7.5, union: doesn't work if the receiver is not a SequenceableCollection. That's why the method testUnion fails. Romain -----Message d'origine----- De : moose-dev-bounces(a)iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch ] De la part de stephane ducasse Envoyé : vendredi 13 juin 2008 17:49 À : Related to the development of Moose and other related tools Objet : [Moose-dev] did union: work in the past? hi all did union: work? Did it work on VW75? is it a bug only due to 76? Stef _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

-- www.tudorgirba.com www.tudorgirba.com/blog "What we can governs what we wish."

Reply

Stéphane Ducasse

9:34 a.m.

Hi Stef, The code was always somehow broken because it tries to do too many things and putting Array and Set in the same pot does not work well. I do not know how to fix it to work with everything, but for now I am only using it for SequencebleCollection anyway. The test is red just to keep a reminder.

hani is using sets but apparently is not able to send email to public forum. So it really helps. So I will fix it for Array and Set with a hack. Stef

Reply

Romain PEIRS

10:28 a.m.

Hi, I have a method union: with which the tests works fine. Here it is: union: aSet "Answer the union of the receiver A and aSet B. The union is defined as { x | x in A or x in B }." | stream set | self isEmpty ifTrue: [^aSet]. self isSequenceable ifTrue: [stream := (self species new: self size) writeStream] ifFalse: [stream := (OrderedCollection new: self size) writeStream]. "uses a stream to work also for Array." set := Set new. set addAll: aSet. set addAll: self. stream nextPutAll: set. ^stream contents Romain -----Message d'origine----- De : moose-dev-bounces(a)iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch] De la part de Stéphane Ducasse Envoyé : samedi 14 juin 2008 09:35 À : Related to the development of Moose and other related tools Objet : [Moose-dev] Re: did union: work in the past?

Hi Stef, The code was always somehow broken because it tries to do too many things and putting Array and Set in the same pot does not work well. I do not know how to fix it to work with everything, but for now I am only using it for SequencebleCollection anyway. The test is red just to keep a reminder.

hani is using sets but apparently is not able to send email to public forum. So it really helps. So I will fix it for Array and Set with a hack. Stef _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Stéphane Ducasse

11:37 a.m.

I did a similar hack and after I defined two methods on each of the class Set and Sequenceable. Stef

Hi, I have a method union: with which the tests works fine. Here it is: union: aSet "Answer the union of the receiver A and aSet B. The union is defined as { x | x in A or x in B }." | stream set | self isEmpty ifTrue: [^aSet]. self isSequenceable ifTrue: [stream := (self species new: self size) writeStream] ifFalse: [stream := (OrderedCollection new: self size) writeStream]. "uses a stream to work also for Array." set := Set new. set addAll: aSet. set addAll: self. stream nextPutAll: set. ^stream contents Romain -----Message d'origine----- De : moose-dev-bounces(a)iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch ] De la part de Stéphane Ducasse Envoyé : samedi 14 juin 2008 09:35 À : Related to the development of Moose and other related tools Objet : [Moose-dev] Re: did union: work in the past?

Hi Stef, The code was always somehow broken because it tries to do too many things and putting Array and Set in the same pot does not work well. I do not know how to fix it to work with everything, but for now I am only using it for SequencebleCollection anyway. The test is red just to keep a reminder.

hani is using sets but apparently is not able to send email to public forum. So it really helps. So I will fix it for Array and Set with a hack. Stef _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

Stéphane Ducasse

12:03 p.m.

I did Set>>union: aSet "Answer the union of the receiver A and aSet B. The union is defined as { x | x in A or x in B }." | set | self isEmpty ifTrue: [^Set new]. set := Set new. set addAll: aSet. set addAll: self. ^ set SequenceableCollection>>union: aSet "Answer the union of the receiver A and aSet B. The union is defined as { x | x in A or x in B }." | stream set | self isEmpty ifTrue: [^Set new]. stream := (self species new: self size) writeStream. set := Set new. set addAll: aSet. set addAll: self. stream nextPutAll: set. ^stream contents On Jun 14, 2008, at 11:37 AM, Stéphane Ducasse wrote:

I did a similar hack and after I defined two methods on each of the class Set and Sequenceable. Stef

Hi, I have a method union: with which the tests works fine. Here it is: union: aSet "Answer the union of the receiver A and aSet B. The union is defined as { x | x in A or x in B }." | stream set | self isEmpty ifTrue: [^aSet]. self isSequenceable ifTrue: [stream := (self species new: self size) writeStream] ifFalse: [stream := (OrderedCollection new: self size) writeStream]. "uses a stream to work also for Array." set := Set new. set addAll: aSet. set addAll: self. stream nextPutAll: set. ^stream contents Romain -----Message d'origine----- De : moose-dev-bounces(a)iam.unibe.ch [mailto:moose-dev-bounces@iam.unibe.ch ] De la part de Stéphane Ducasse Envoyé : samedi 14 juin 2008 09:35 À : Related to the development of Moose and other related tools Objet : [Moose-dev] Re: did union: work in the past?

Hi Stef, The code was always somehow broken because it tries to do too many things and putting Array and Set in the same pot does not work well. I do not know how to fix it to work with everything, but for now I am only using it for SequencebleCollection anyway. The test is red just to keep a reminder.

hani is using sets but apparently is not able to send email to public forum. So it really helps. So I will fix it for Array and Set with a hack. Stef _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev _______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

_______________________________________________ Moose-dev mailing list Moose-dev(a)iam.unibe.ch https://www.iam.unibe.ch/mailman/listinfo/moose-dev

Reply

6046

days inactive

6047

days old

moose-dev@list.inf.unibe.ch

Manage subscription

7 comments

4 participants

tags (0)

participants (4)

Romain PEIRS
stephane ducasse
Stéphane Ducasse
Tudor Girba