Re: Work on configurations browser - Moose-dev

16 Apr 2013

(let's keep the discussion on the mailing list)

Excellent. I added you to the Moose team.

More and more exciting things happen in the Moose-land :)

Doru

On Tue, Apr 16, 2013 at 9:02 AM, Diego Lont &lt;diego.lont(a)delware.nl&gt; wrote:

...
  Hi Doru,

 I just added myself on smalltalk hub. User DiegoLont. It would be nice if
 my work is used by others as well.

 I will make a model of the configuration, so we can store here the things
 we use in the configuration browser. Also I will move stuff back into the
 glamour tools package. I hope to be able to work on this tomorrow.

 Cheers,
 Diego

 On Apr 16, 2013, at 7:35 AM, Tudor Girba wrote:

  Hi Diego,

 I only now got some time to review your browser. Nice job.

 What I like:
 - You integrated method editing
 - You made it robust so that it can deal with configurations that do not  have all
parts loaded
  - You added the load / fetch commands and the
associated refresh  (through announcements)
  - You kept the browser clean (often people have
the tendency to add  instance variables for managing the browser state)
  - You added a group view

 What should be improved:
 - You have two panes for specs and versions. We should unify them.  Ideally, we
should build an intermediary model that keeps track both of the
 method and of the Metacello version. Thus, when we select the version we
 should get the associated code as well.
 I already thought this was needed. But I first wanted to be able to edit
 methods, and ran into trouble that I needed a different representation. I
 did not want to start with a model of the configuration.

  - The cache instance variables should move into
this model, as well.  That makes sense.

  - You used underlining to denote loaded code, and
blue to denote  configurations. I think would like to keep color to denote when
something
 has changed locally, but we can talk about this.
 I followed the monticello standard, to make it more uniform. I agree: we
 should keep blue for something that changed locally. So I will think of
 another way to paint projects.

  - The group view should drill into dependencies
as well. Like this we  can see what is the impact of loading a certain group.
 The model of the configuration should help for this.

  - We need commit commands both for the
configuration and for the  packages :)
 And for using the Metacello toolbox functions: like update this version
 for the package versions loaded.

-- 
www.tudorgirba.com

"Every thing has its own flow"