Issue 706 in moose-technology: Replace <property: ... > pragmas with <MSEProperty: ...> ones
11 Sep
2011
11 Sep
'11
10 p.m.
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Component-Famix
New issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... > pragmas
with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
Look for senders of:
propertySignature
<property: #XXX longName: 'YYY' description: 'ZZZ'>
And replace with:
propertySignature
<MSEProperty: #propertySignature type: #Number>
<MSEComment: 'ZZZ'>
19 Sep
19 Sep
9:56 a.m.
Comment #1 on issue 706 by stephane...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
so using MSEProperties how does the system links AFFC to this method?
afferentCoupling
"Afferent coupling for a class group is the number of classes that depend
upon this class group"
<property: #AFFC longName: 'Afferent Coupling' description: 'Afferent
Coupling of a class group'>
| cgClasses cgTypes |
cgClasses := self allClasses select: [:c | c isInstanceSide].
cgTypes := cgClasses flatCollect: [:c | c allRecursiveTypes].
^ (cgClasses flatCollect: [:aClass | aClass invokingClasses select: [: c |
(cgClasses contains: [:each | each = c]) not and: [(cgTypes contains:
[:each | each = c]) not and: [c isInstanceSide]]]]) asSet size
10:51 a.m.
Updates:
Labels: Milestone-4.6
Comment #2 on issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
I am not sure I understand what the issue is.
The annotations are not used for the internal computations. We do not
depend on this logic in any way.
The annotations are used for import/export and for the UI. The result of
the MSEProperty: annotation is the link of a FM3Property to the actual
Smalltalk method (so, not anymore depending on the key to look it up in a
dictionary).
Maybe what is confusion is the missing of a lookup. But, this simply means
that the computation is not being cached. That is all.
Does this clarify the matter?
23 Sep
23 Sep
5:32 p.m.
Comment #3 on issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
I created a rule to check for these usages and made it part of the
OnMooseReport.
10 Oct
10 Oct
12:08 p.m.
Comment #4 on issue 706 by fabrizio...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
Hi,
i was doing this change. Do i have to adapt the tests to?
E.g.
testAttributeMetrics
| attribute1 attribute2 |
attribute1 := self model entityNamed: #'Smalltalk::LANInterface.nextNode'.
attribute2 := self model entityNamed:
#'Smalltalk::LANOutputServer.serverType'.
self assert: (attribute1 propertyNamed: #NAA) = 3.
self assert: attribute1 numberOfAccesses = 3.
......
Became:
testAttributeMetrics
| attribute1 attribute2 |
attribute1 := self model entityNamed: #'Smalltalk::LANInterface.nextNode'.
attribute2 := self model entityNamed:
#'Smalltalk::LANOutputServer.serverType'.
self assert: (attribute1 propertyNamed: #numberOfAccesses) = 3.
self assert: attribute1 numberOfAccesses = 3.
........
3:25 p.m.
Comment #5 on issue 706 by fabrizio...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
Question. Which is the type of FAMIXMethod>>>timestamp? Number? Timestamp?
DateAndTime?...
3:41 p.m.
Comment #6 on issue 706 by andreho...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
#String
4:21 p.m.
Comment #7 on issue 706 by fabrizio...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
I did the change and i committed. Surely lots of tests will fail. Someone
which has the rights can run a build of MooseLatestDev and Moose-on-Moose
on the Moose CI. Please.
11:38 p.m.
Comment #8 on issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
Thanks a lot. I fixed the type references from #Date and #Text to #String.
And I also started a new build.
12 Oct
12 Oct
12:42 p.m.
New subject: Issue 706 in moose-technology: Replace <property: ... > pragmas with <MSEProperty: ...> ones
By loading the latest AST-Core package 6 failures got fixed themselves.
Cheers,
Fabrizio
On 10 Oct 2011, at 23:38, moose-technology(a)googlecode.com wrote:
Comment #8 on issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... > pragmas
with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
Thanks a lot. I fixed the type references from #Date and #Text to #String. And I also
started a new build.
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
10:31 p.m.
New subject: Issue 706 in moose-technology: Replace <property: ... > pragmas with <MSEProperty: ...> ones
What do you mean?
Doru
On Oct 12, 2011, at 12:42, Fabrizio Perin <perin(a)iam.unibe.ch> wrote:
By loading the latest AST-Core package 6 failures got
fixed themselves.
Cheers,
Fabrizio
On 10 Oct 2011, at 23:38, moose-technology(a)googlecode.com wrote:
Comment #8 on issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... > pragmas
with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
Thanks a lot. I fixed the type references from #Date and #Text to #String. And I also
started a new build.
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
10:37 p.m.
New subject: Issue 706 in moose-technology: Replace <property: ... > pragmas with <MSEProperty: ...> ones
I mean that there are two versions of that package that were not loaded in the MooseImage
so by loading those versions some failures get fix.
Cheers,
Fabrizio
On 12 Oct 2011, at 22:31, Tudor Girba wrote:
What do you mean?
Doru
On Oct 12, 2011, at 12:42, Fabrizio Perin <perin(a)iam.unibe.ch> wrote:
By loading the latest AST-Core package 6 failures
got fixed themselves.
Cheers,
Fabrizio
On 10 Oct 2011, at 23:38, moose-technology(a)googlecode.com wrote:
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Comment #8 on issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... > pragmas
with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
Thanks a lot. I fixed the type references from #Date and #Text to #String. And I also
started a new build.
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
11:10 p.m.
New subject: Issue 706 in moose-technology: Replace <property: ... > pragmas with <MSEProperty: ...> ones
I'm talking about the version
AST-Core-lr.89
That is not load into the image and that fix 6 failures and 4 errors from the
PetitSmalltalk-Tests package
Cheers,
Fabrizio
On 12 Oct 2011, at 22:37, Fabrizio Perin wrote:
I mean that there are two versions of that package
that were not loaded in the MooseImage so by loading those versions some failures get
fix.
Cheers,
Fabrizio
On 12 Oct 2011, at 22:31, Tudor Girba wrote:
What do you mean?
Doru
On Oct 12, 2011, at 12:42, Fabrizio Perin <perin(a)iam.unibe.ch> wrote:
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev By loading the latest AST-Core package 6 failures
got fixed themselves.
Cheers,
Fabrizio
On 10 Oct 2011, at 23:38, moose-technology(a)googlecode.com wrote:
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Comment #8 on issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... > pragmas
with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
Thanks a lot. I fixed the type references from #Date and #Text to #String. And I also
started a new build.
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
_______________________________________________
Moose-dev mailing list
Moose-dev(a)iam.unibe.ch
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
13 Oct
13 Oct
12:33 p.m.
Comment #9 on issue 706 by fabrizio...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
fixed the last 4 properties pointed out by the moose-on-moose rule
14 Nov
14 Nov
9:22 p.m.
Updates:
Status: Fixed
Comment #10 on issue 706 by tudor.gi...(a)gmail.com: Replace <property: ... >
pragmas with <MSEProperty: ...> ones
http://code.google.com/p/moose-technology/issues/detail?id=706
This issue is now fixed. Great.
4787
days inactive
4851
days old
14 comments
3 participants
participants (3)
-
Fabrizio Perin -
moose-technology＠googlecode.com -
Tudor Girba