Re: Issue 16 in moose-technology: implicit importer is wrong: an implicit variable should be attached to a method not a class
Comment #9 on issue 16 by cy.delaunay: implicit importer is wrong: an implicit variable should be attached to a method not a class http://code.google.com/p/moose-technology/issues/detail?id=16
after looking a bit more, I think we will have to change also the code about Invocations, which expect the parent of an ImplicitVariable to be a Class.
Comment #10 on issue 16 by cy.delaunay: implicit importer is wrong: an implicit variable should be attached to a method not a class http://code.google.com/p/moose-technology/issues/detail?id=16
I did something to fix that. For now it is in my own repository, you can load in the last 1.2 moose image by evaluating:
Gofer new squeaksource: 'DelaunayTmpStuffs'; package: 'Moose-SmalltalkImporter'; version: 'Moose-SmalltalkImporter-cyrille_delaunay.103'; package: 'Moose-Tests-SmalltalkImporter-Core'; version: 'Moose-Tests-SmalltalkImporter-Core-cyrille_delaunay.13'; package: 'Moose-Tests-SmalltalkImporter-LAN'; version: 'Moose-Tests-SmalltalkImporter-LAN-cyrille_delaunay.5'; package: 'Famix-Extensions'; version: 'Famix-Extensions-cyrille_delaunay.150'; load.
What I mainly changed: - added an instance variable in MooseImporter, to store them and be sure we will not create two times the same implicit variable (not sure if my solution is the best tn terms of performance, but it does not seem to take too much to create a model). - modify some tests that were expecting an implicitVariable to belong to a class - modify the code to compute an invocation's receiver's type.
Updates: Cc: tudor.girba
Comment #11 on issue 16 by cy.delaunay: implicit importer is wrong: an implicit variable should be attached to a method not a class http://code.google.com/p/moose-technology/issues/detail?id=16
(No comment was entered for this change.)
Updates: Labels: -Milestone-4.2 Milestone-4.3
Comment #12 on issue 16 by tudor.gi...@gmail.com: implicit importer is wrong: an implicit variable should be attached to a method not a class http://code.google.com/p/moose-technology/issues/detail?id=16
Cyrille, please publish this in the main repository.
Comment #13 on issue 16 by jannik.l...@gmail.com: implicit importer is wrong: an implicit variable should be attached to a method not a class http://code.google.com/p/moose-technology/issues/detail?id=16
cyrille did you publish it ? If it works, we can close the issue.
Comment #14 on issue 16 by tudor.gi...@gmail.com: implicit importer is wrong: an implicit variable should be attached to a method not a class http://code.google.com/p/moose-technology/issues/detail?id=16
Cyrille, is this published?
Updates: Status: Fixed Owner: --- Cc: stephane.ducasse Labels: -Platform-VW
Comment #15 on issue 16 by tudor.gi...@gmail.com: implicit importer is wrong: an implicit variable should be attached to a method not a class http://code.google.com/p/moose-technology/issues/detail?id=16
Ok. I integrated the fixes. The tests are green. Finally, fixed :)
-
moose-technology＠googlecode.com