Status: New Owner: damien.c...@gmail.com CC: tudor.gi...@gmail.com Labels: Type-Engineering Priority-Low
New issue 627 by damien.c...@gmail.com: Glamour-Morphic unit tests are fragile to changes in the submorphs tree http://code.google.com/p/moose-technology/issues/detail?id=627
Glamour-Morphic unit tests contain code like this:
treeMorph := window submorphs last submorphs first submorphs first submorphs first submorphs first. self assert: treeMorph class = LazyMorphTreeMorph.
Which is very fragile to any changes in the submorphs tree. I propose to replace each of these piece of code to something like:
treeMorph := self find: LazyMorphTreeMorph in: window
The method #find:in: could use something like Morph>>allMorphsDo: to find a corresponding morph in the submorphs tree.
I guess this would made the code slower but haven't tested it.
Comment #1 on issue 627 by tudor.gi...@gmail.com: Glamour-Morphic unit tests are fragile to changes in the submorphs tree http://code.google.com/p/moose-technology/issues/detail?id=627
Good point. We should change that :)
Updates: Status: Fixed Labels: Component-Glamour
Comment #2 on issue 627 by damien.c...@gmail.com: Glamour-Morphic unit tests are fragile to changes in the submorphs tree http://code.google.com/p/moose-technology/issues/detail?id=627
Name: Glamour-Tests-Morphic-DamienCassou.33 Author: DamienCassou Time: 11 May 2011, 9:24:34 pm UUID: ec2d3255-4e8d-45f1-8a09-cae086e69bc9 Ancestors: Glamour-Tests-Morphic-DamienCassou.32
- Adds GLMMorphicTest>>find:in: to avoid long sequences of #submorphs calls (issue 627) - Refactor GLMTreeMorphicTest to use the new method + some more cleaning
Updates: Labels: Milestone-4.4
Comment #3 on issue 627 by tudor.gi...@gmail.com: Glamour-Morphic unit tests are fragile to changes in the submorphs tree http://code.google.com/p/moose-technology/issues/detail?id=627
Cool. Thanks.