[Moose-dev] Re: Moved Hierarchical Graph

Hi Dennis, I went briefly over your code. I think the algorithm gets in a good state! - MalHgRepository should be removed from this level. It is essentially not used. It only adds global variables and it is not essential for the algorithm. - MooseAlgos is at the lowest level in Moose, and it should have no dependencies to other parts like FAMIX. Please fix the tests. - The MalHgVisitorTask hierarchy and MalHgBottomUpNodeVisitor are not used and should be removed from the package. - MalHgUtilities are not used within the package and should be removed from the package. - FILOStack is only used in a test so it seems to not be particularly useful. In general, we want to keep global state to a bare minimum because we want to enable unforeseen combinations at object-level. Caches can be built at a certain application level, but only if truly necessary. After we do this cleaning, we can move on to add the package to the configuration. Cheers, Doru On Apr 18, 2013, at 7:12 AM, Tudor Girba <tudor(a)tudorgirba.com> wrote: others might get interested as well. In case you think that you would waste other people's time, HierarchicalGraphs is now part of the 5.0 Roadmap :) wrote: tests to Moose-Tests-Algos-HierarchicalGraph. I also renamed the classes. Could you take a look and see if everything looks good from your point of view? which version the packages should be added. I assume 2.4? But did not see a version for this. merge the code bases, e.g. using classes like MalGraphNode and MalGraphEdge as parents of MalHgNode and MalHgEdge. I also made some utilities which I can guess are already implemented somewhere, like a linear equation generator. If you have some ideas there, or would like to code on this as well, tell me. -- www.tudorgirba.com "Sometimes the best solution is not the best solution."