[Moose-dev] Re: TreeMapLayout in Mondrian

Hi Doru, Thanks for your feedback. Some thoughts inline in your mail: On Tue, Feb 28, 2012 at 21:06, Tudor Girba <tudor(a)tudorgirba.com> wrote: Thanks for this, added it as an example to the tests. When initializing the graph (in doInitialize: aGraph) I do the following: ... graph removeAllNodes. graph addNode: rootNode. ... I remove all nodes and add only the root node. To draw the treemap I use a recursive function, which starts at the rootNode and goes through all "children" using the edge definitions. Then I layout (changing position, shape, color, etc.) the children nodes of the current node and add them back to the graph. I'm now pretty sure it has something to do with caching, because when I change colors and create the view anew, sometimes the old colors are still used. But this behavior most probably stems from the fact that the way I create this layout was not intended to be done like this. Since my layout inherits from MOAbstractGraphLayout I will study this class and its implementors some more. But any pointers how to do things more the Mondrian way would be appreciated. As you noted, there should be no decision regarding interaction and color For now I will leave colors and interactions out of the layout, I can add these outside of it, when creating the view itself to color leaf nodes differently for example. (But would be interested to solve the coloring / caching question nevertheless). Which size do you mean here? That of the shape of the node? Wouldn't that mean that I give each node a size, take this as a weight, and change the size of the node again? Also, sure there can be different kinds nodes, but I think one could deal with that in the weight block itself. What I'm currently trying to do, what should be possible imho, is to render some nodes in a certain way in Mondrian, with any layout, for example a gridLayout, but render the single nodes as Treemaps. In this case, I think it's okay that a node renders all of its children at once, because what I want in this case is a treemap of a single node, and I think Mondrian should be able to just render that, without me having to manually construct a nested graph. I have two goals with this layout at the moment: 1. I think it would be cool to have it in Mondrian as generic as possible and done in sync with all other layouts in terms of how to use it and how it works internally. But as you said, it is an edge case, so it I think it will have to deviate in some aspects. 2. My main goal is to port aspects of Softwarenaut to Pharo. That means at the end I would like to have similar visualizations as Softwarenaut provides in Pharo. The question will then just be how much will be in the layout itself and how much outside. Thanks again for the feedback, looking forward to discuss this some more :)